From: sashiko-bot@kernel.org
To: "Christian Marangi" <ansuelsmth@gmail.com>,
mfd@lists.linux.dev, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org, lee@kernel.org
Subject: Re: [RESEND PATCH 1/2] dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC
Date: Wed, 21 Oct 2026 11:46:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-180180@kernel.org> (raw)
In-Reply-To: <20261021113419.283015-2-ansuelsmth@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mfd: reference to missing schema airoha,an8855-switch.yaml
--
commit 8973f67919d9fd3d92a5417e6a75e38e2eb9cc42
Author: Christian Marangi <ansuelsmth@gmail.com>
dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC
This commit adds the devicetree binding schema for the Airoha AN8855
switch multi-function device, including its efuse, ethernet-switch, and
mdio subnodes.
> diff --git a/Documentation/devicetree/bindings/mfd/airoha,an8855.yaml b/Documentation/devicetree/bindings/mfd/airoha,an8855.yaml
> new file mode 100644
> index 0000000000000..48127e956c965
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/airoha,an8855.yaml
[ ... ]
> + efuse:
> + type: object
> + $ref: /schemas/nvmem/airoha,an8855-efuse.yaml
> + description: EFUSE exposed by the Airoha AN8855 SoC
> +
> + ethernet-switch:
> + type: object
> + $ref: /schemas/net/dsa/airoha,an8855-switch.yaml
> + description: Switch exposed by the Airoha AN8855 SoC
[Severity: Low]
Does this break make dt_binding_check?
In Documentation/devicetree/bindings/mfd/airoha,an8855.yaml,
properties:ethernet-switch references
/schemas/net/dsa/airoha,an8855-switch.yaml, and the examples section
instantiates an ethernet-switch child node with:
ethernet-switch {
compatible = "airoha,an8855-switch";
However, Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml
does not exist in the repository, causing dt-doc-validate, dt-mk-schema,
and dt-validate to fail on the unresolved $ref and the undocumented
airoha,an8855-switch compatible string.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021113419.283015-1-ansuelsmth@gmail.com?part=1
next prev parent reply other threads:[~2026-10-21 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 11:34 [RESEND PATCH 0/2] mfd: add Airoha AN8855 switch support Christian Marangi
2026-10-21 11:34 ` [RESEND PATCH 1/2] dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC Christian Marangi
2026-10-21 11:46 ` sashiko-bot [this message]
2026-10-21 13:35 ` Rob Herring (Arm)
2026-10-21 11:34 ` [RESEND PATCH 2/2] mfd: an8855: Add support for Airoha AN8855 Switch Christian Marangi
2026-10-21 12:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180180@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox