* [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards
@ 2026-10-21 14:21 vishnu.saini
2026-10-21 14:21 ` [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay vishnu.saini
` (6 more replies)
0 siblings, 7 replies; 11+ messages in thread
From: vishnu.saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang,
Mohit Dsor, Anand Tiwari, Shashank Maurya
Shikra EVK SoC cards (CQS, CQM, and IQS) are mounted on the Lyra carrier
card. The DSI0 interface from SoC card is routed to either the 22-pin DSI
connector on carrier card named as JDISP1 DSI0 or to the B2B connector
named as PDISP1 DSI0, though a MUX which can be selected by a hardware
DIP switch. There are multiple daughter cards designed that can be
connected to this PDISP1 DSI0 B2B connector.
The below B2B display interfaces are enabled by default in base DTB:
- IQS: DSI-to-HDMI using the LT9611UXD daughter card
- CQS/CMS: DLC0697 DSI panel using a DLC daughter card
This series adds DT overlays for additional display configurations:
- shikra-cqm-cqs-evk-hdmi: HDMI output for CQM/CQS with LT9611UXD
daughter card
- shikra-iqs-evk-dlc-panel: DLC0697 DSI panel for IQS with DLC daughter
card
- shikra-iqs-evk-lvds-auo,g133han01: AUO G133HAN01 LVDS panel for IQS
with LVDS daughter card
- shikra-iqs-evk-raspberrypi-dsi-7inch: Raspberry Pi 7-inch DSI
panel with touch via the 22-pin JDISP1 DSI0 connector for IQS
- shikra-iqs-evk-waveshare-dsi-8inch: Waveshare 8-inch DSI panel
with touch via the 22-pin JDISP1 DSI0 connector for IQS
These overlays are applied on top of the corresponding base board
DTBs.
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
Anand Tiwari (1):
arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS panel overlay
Mohit Dsor (1):
arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay
Shashank Maurya (2):
arm64: dts: qcom: shikra-iqs-evk: Add RPi 7-inch DSI panel overlay
arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay
Vishnu Saini (3):
arm64: dts: qcom: shikra-iqs-evk: Add DLC0697 panel overlay
arm64: defconfig: Enable RPi touchscreen V2 regulator and ILI9881C panel
arm64: defconfig: Enable Waveshare DSI panel and touch GPIO drivers
arch/arm64/boot/dts/qcom/Makefile | 15 +++
.../boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso | 90 +++++++++++++++
.../boot/dts/qcom/shikra-iqs-evk-dlc-panel.dtso | 78 +++++++++++++
.../qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso | 127 +++++++++++++++++++++
.../qcom/shikra-iqs-evk-raspberrypi-dsi-7inch.dtso | 91 +++++++++++++++
.../qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso | 77 +++++++++++++
arch/arm64/configs/defconfig | 4 +
7 files changed, 482 insertions(+)
---
base-commit: 6474fa070f2b8013b4b87350b775b8c3be6e8aac
change-id: 20261019-shikra_display_overlays-515c88f150b3
prerequisite-message-id: <20260930-shikra-dt-changes-v5-0-8eaf658a0e38@oss.qualcomm.com>
prerequisite-patch-id: 7631efa76e1fe98ae45c0f68e93ced4c523af27a
prerequisite-patch-id: 49396fb33427bd9b9214b537221a1c582d5d62ee
prerequisite-patch-id: 3cbb70da0a3009a2730813b562c29f432bd0fd8f
prerequisite-patch-id: 1c9ff594613a4cef8d605cfd37a3270866ba6414
prerequisite-message-id: <20261015-shikra-work-v5-0-5e075222b60a@oss.qualcomm.com>
prerequisite-patch-id: 326d8620d592d8f5f75fe62f88a2cb4dd8ec0b46
prerequisite-patch-id: 327308970dffdb2b218d4834e1badcc9e05cfd01
prerequisite-message-id: <20261008-lt9611c-v7-v17-0-1e8f5f2b2f19@oss.qualcomm.com>
prerequisite-patch-id: 49f1e01bb5594ce9c4301ce4b16715834ece7f41
prerequisite-patch-id: b909fe50eb311c7d8ca6778a29952e2c1a28d7ee
Best regards,
--
Vishnu Saini <vishnu.saini@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
@ 2026-10-21 14:21 ` vishnu.saini
2026-10-21 14:37 ` sashiko-bot
2026-10-21 14:21 ` [PATCH 2/7] arm64: dts: qcom: shikra-iqs-evk: Add DLC0697 panel overlay Vishnu Saini
` (5 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: vishnu.saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang,
Mohit Dsor
From: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Add a DT overlay for CQM and CQS, to enable HDMI output when LT9611UXD
DSI-to-HDMI daughter card connected to PDISP1 DSI0 on carrier card.
LT9611UXD is connected through I2C4, with reset and interrupt connected
to tlmm GPIO76 and GPIO85.
Disable the default DSI0 panel dt nodes and enable LT9611UXD
bridge for HDMI output.
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 6 ++
.../boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso | 90 ++++++++++++++++++++++
2 files changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 4e714251d5e6..c8907e77c893 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -377,6 +377,12 @@ shikra-iqs-evk-imx577-camera-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-imx577-ca
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-imx577-camera.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-imx577-camera.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-imx577-camera.dtb
+
+shikra-cqm-evk-hdmi-dtbs := shikra-cqm-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
+shikra-cqs-evk-hdmi-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
+
+dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-hdmi.dtb
+dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb
diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso b/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso
new file mode 100644
index 000000000000..a7b77114061a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso
@@ -0,0 +1,90 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+&{/} {
+ model = "Qualcomm Technologies, Inc. Shikra CQM/S EVK HDMI";
+
+ hdmi-connector {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_connector_out: endpoint {
+ remote-endpoint = <&hdmi_bridge_out>;
+ };
+ };
+ };
+};
+
+&i2c4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "okay";
+
+ hdmi-bridge@41 {
+ compatible = "lontium,lt9611uxd";
+ reg = <0x41>;
+ interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>;
+ reset-gpios = <&tlmm 76 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&lcd_bias>;
+ vdd-supply = <&pm4125_l15>;
+ pinctrl-0 = <&bridge_irq_pin &bridge_rst_pin>;
+ pinctrl-names = "default";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ hdmi_bridge_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ hdmi_bridge_out: endpoint {
+ remote-endpoint = <&hdmi_connector_out>;
+ };
+ };
+ };
+ };
+};
+
+&mdss_dsi0 {
+ panel@0 {
+ status = "disabled";
+ };
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&hdmi_bridge_in>;
+};
+
+&tlmm {
+ bridge_rst_pin: bridge-rst-state {
+ pins = "gpio76";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ bridge_irq_pin: bridge-irq-state {
+ pins = "gpio85";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/7] arm64: dts: qcom: shikra-iqs-evk: Add DLC0697 panel overlay
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
2026-10-21 14:21 ` [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay vishnu.saini
@ 2026-10-21 14:21 ` Vishnu Saini
2026-10-21 14:21 ` [PATCH 3/7] arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS " vishnu.saini
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Vishnu Saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang
Add a DT overlay for IQS, to enable DLC0697 panel when DLC daughter card
connected to PDISP1 DSI0 on carrier card.
Configure DLC0697 reset GPIO, supplies, pinctrl states and GPIO backlight
controlled through PM8150 GPIO 1.
Disable the default HDMI bridge and connector in favour of the DSI
panel.
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 3 +
.../boot/dts/qcom/shikra-iqs-evk-dlc-panel.dtso | 78 ++++++++++++++++++++++
2 files changed, 81 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index c8907e77c893..0c5a7b7f694b 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -380,9 +380,12 @@ dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-imx577-camera.dtb
shikra-cqm-evk-hdmi-dtbs := shikra-cqm-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
shikra-cqs-evk-hdmi-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
+shikra-iqs-evk-dlc-panel-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-dlc-panel.dtbo
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-hdmi.dtb
+dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-dlc-panel.dtb
+
dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-dlc-panel.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-dlc-panel.dtso
new file mode 100644
index 000000000000..2542abe59d34
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-dlc-panel.dtso
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+
+&{/} {
+ model = "Qualcomm Technologies, Inc. Shikra IQS EVK DLC Panel";
+
+ backlight: backlight {
+ compatible = "gpio-backlight";
+ gpios = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
+ default-on;
+ };
+};
+
+&hdmi_bridge {
+ status = "disabled";
+};
+
+&hdmi_connector {
+ status = "disabled";
+};
+
+&mdss_dsi0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "dlc,dlc0697", "ilitek,ili7807s";
+ reg = <0>;
+ backlight = <&backlight>;
+ reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
+ vddi-supply = <&pm8150_l15>;
+ avdd-supply = <&vreg_disp_3p3>;
+ avee-supply = <&vreg_disp_3p3>;
+ pinctrl-0 = <&panel_rst_n &panel_te_pin>;
+ pinctrl-1 = <&panel_rst_n_suspend>;
+ pinctrl-names = "default", "sleep";
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&panel_in>;
+};
+
+&tlmm {
+ panel_rst_n: panel-rst-n-state {
+ pins = "gpio3";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ panel_rst_n_suspend: panel-rst-n-suspend-state {
+ pins = "gpio3";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ panel_te_pin: panel-te-pin-state {
+ pins = "gpio86";
+ function = "mdp_vsync_p";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/7] arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS panel overlay
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
2026-10-21 14:21 ` [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay vishnu.saini
2026-10-21 14:21 ` [PATCH 2/7] arm64: dts: qcom: shikra-iqs-evk: Add DLC0697 panel overlay Vishnu Saini
@ 2026-10-21 14:21 ` vishnu.saini
2026-10-21 14:33 ` sashiko-bot
2026-10-21 14:21 ` [PATCH 4/7] arm64: defconfig: Enable RPi touchscreen V2 regulator and ILI9881C panel Vishnu Saini
` (3 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: vishnu.saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang,
Anand Tiwari
From: Anand Tiwari <anand.tiwari@oss.qualcomm.com>
Add a DT overlay for IQS, to enable LVDS interface when LVDS daughter card
is connected to PDISP1 DSI0 on carrier card.
There is SN65DSI84 DSI-to-LVDS bridge on the daughter card which is
connected through I2C3 with reset and interrupt connected to tlmm GPIO76
and GPIO85.
Backlight is connected to gpio87 with pdm_pwm functionality. Currently this
is not supported in linux-next yet, so pull the gpio high.
Enable support for AUO G133HAN01 LVDS panel connected to this daughter card
and disable the default HDMI bridge and connector in favour of the LVDS
panel.
Signed-off-by: Anand Tiwari <anand.tiwari@oss.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 2 +
.../qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso | 127 +++++++++++++++++++++
2 files changed, 129 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 0c5a7b7f694b..610fe640471b 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -381,10 +381,12 @@ dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-imx577-camera.dtb
shikra-cqm-evk-hdmi-dtbs := shikra-cqm-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
shikra-cqs-evk-hdmi-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
shikra-iqs-evk-dlc-panel-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-dlc-panel.dtbo
+shikra-iqs-evk-lvds-auo,g133han01-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-lvds-auo,g133han01.dtbo
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-dlc-panel.dtb
+dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-lvds-auo,g133han01.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso
new file mode 100644
index 000000000000..80b9dcc92061
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso
@@ -0,0 +1,127 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+&{/} {
+ backlight {
+ compatible = "gpio-backlight";
+ gpios = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
+ default-on;
+ pinctrl-0 = <&backlight_pwm>;
+ pinctrl-names = "default";
+ };
+
+ panel-lvds {
+ compatible = "auo,g133han01";
+ power-supply = <&vreg_lvds_3p3>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ dual-lvds-odd-pixels;
+
+ lvds_panel_out_a: endpoint {
+ remote-endpoint = <&sn65dsi84_out_a>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ dual-lvds-even-pixels;
+
+ lvds_panel_out_b: endpoint {
+ remote-endpoint = <&sn65dsi84_out_b>;
+ };
+ };
+ };
+ };
+
+ vreg_bridge_1p8: regulator-bridge-1p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_bridge_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ vreg_lvds_3p3: regulator-lvds-3p3 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_lvds_3p3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+};
+
+&hdmi_bridge {
+ status = "disabled";
+};
+
+&hdmi_connector {
+ status = "disabled";
+};
+
+&i2c3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bridge@2c {
+ compatible = "ti,sn65dsi84";
+ reg = <0x2c>;
+ enable-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>;
+ interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>;
+ vcc-supply = <&vreg_bridge_1p8>;
+ pinctrl-0 = <&bridge_irq_pin &bridge_rst_pin>;
+ pinctrl-names = "default";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ sn65dsi84_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ data-lanes = <1 2 3 4>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ sn65dsi84_out_a: endpoint {
+ remote-endpoint = <&lvds_panel_out_a>;
+ };
+ };
+
+ port@3 {
+ reg = <3>;
+
+ sn65dsi84_out_b: endpoint {
+ remote-endpoint = <&lvds_panel_out_b>;
+ };
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&sn65dsi84_in>;
+};
+
+&tlmm {
+ backlight_pwm: backlight-pwm-state {
+ pins = "gpio87";
+ function = "gpio";
+ bias-pull-up;
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/7] arm64: defconfig: Enable RPi touchscreen V2 regulator and ILI9881C panel
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
` (2 preceding siblings ...)
2026-10-21 14:21 ` [PATCH 3/7] arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS " vishnu.saini
@ 2026-10-21 14:21 ` Vishnu Saini
2026-10-21 14:21 ` [PATCH 5/7] arm64: dts: qcom: shikra-iqs-evk: Add RPi 7-inch DSI panel overlay vishnu.saini
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Vishnu Saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang
Enable the regulator driver for the Raspberry Pi touchscreen V2 power
and backlight controller, and the Ilitek ILI9881C DSI panel driver, as
modules, for the Raspberry Pi 7 inch DSI panel on the 22-pin JDISP1 DSI0
connector on Qualcomm Shikra EVK, Talos Lyra EVK boards.
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d18f72e55330..9c4c47a44af9 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -900,6 +900,7 @@ CONFIG_REGULATOR_QCOM_SMD_RPM=y
CONFIG_REGULATOR_QCOM_SPMI=y
CONFIG_REGULATOR_QCOM_USB_VBUS=m
CONFIG_REGULATOR_RAA215300=y
+CONFIG_REGULATOR_RASPBERRYPI_TOUCHSCREEN_V2=m
CONFIG_REGULATOR_RK808=y
CONFIG_REGULATOR_S2MPS11=y
CONFIG_REGULATOR_SGM3804=y
@@ -1029,6 +1030,7 @@ CONFIG_DRM_PANEL_HIMAX_HX83112A=m
CONFIG_DRM_PANEL_HIMAX_HX83112B=m
CONFIG_DRM_PANEL_ILITEK_ILI7807S=m
CONFIG_DRM_PANEL_ILITEK_ILI9806E_SPI=m
+CONFIG_DRM_PANEL_ILITEK_ILI9881C=m
CONFIG_DRM_PANEL_ILITEK_ILI9882T=m
CONFIG_DRM_PANEL_KHADAS_TS050=m
CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/7] arm64: dts: qcom: shikra-iqs-evk: Add RPi 7-inch DSI panel overlay
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
` (3 preceding siblings ...)
2026-10-21 14:21 ` [PATCH 4/7] arm64: defconfig: Enable RPi touchscreen V2 regulator and ILI9881C panel Vishnu Saini
@ 2026-10-21 14:21 ` vishnu.saini
2026-10-21 14:21 ` [PATCH 6/7] arm64: defconfig: Enable Waveshare DSI panel and touch GPIO drivers Vishnu Saini
2026-10-21 14:21 ` [PATCH 7/7] arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay vishnu.saini
6 siblings, 0 replies; 11+ messages in thread
From: vishnu.saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang,
Shashank Maurya
From: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
Add a DT overlay to enable Raspberry Pi 7-inch DSI panel connected to DSI
22pin on the carrier card.
DSI0 from SOC is routed through MUX which can be selected by DIP switch
S1016.5 ON for enabling this 22-pin JDISP1 DSI0 connector.
Add the regulator and backlight controller at I2C4 address 0x45,
Goodix GT911 touch controller, panel power and reset control, and a
2-lane DSI connection.
Disable the default HDMI bridge and connector in favour of the RPi
DSI panel.
Signed-off-by: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 2 +
.../qcom/shikra-iqs-evk-raspberrypi-dsi-7inch.dtso | 91 ++++++++++++++++++++++
2 files changed, 93 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 610fe640471b..6d64e7ce197e 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -382,11 +382,13 @@ shikra-cqm-evk-hdmi-dtbs := shikra-cqm-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
shikra-cqs-evk-hdmi-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
shikra-iqs-evk-dlc-panel-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-dlc-panel.dtbo
shikra-iqs-evk-lvds-auo,g133han01-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-lvds-auo,g133han01.dtbo
+shikra-iqs-evk-raspberrypi-dsi-7inch-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-raspberrypi-dsi-7inch.dtbo
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-dlc-panel.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-lvds-auo,g133han01.dtb
+dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-raspberrypi-dsi-7inch.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-raspberrypi-dsi-7inch.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-raspberrypi-dsi-7inch.dtso
new file mode 100644
index 000000000000..383dc5aadcfd
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-raspberrypi-dsi-7inch.dtso
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+
+&{/} {
+ model = "Qualcomm Technologies, Inc. Shikra IQS EVK Raspberry Pi 7inch DSI Panel";
+
+ display_bl: backlight {
+ compatible = "pwm-backlight";
+ power-supply = <®_display>;
+ pwms = <&mcu 0 255 0>;
+ };
+
+ reg_display: regulator-display {
+ compatible = "regulator-fixed";
+ regulator-name = "rpi-display";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ };
+
+ reg_dsi_touch: regulator-dsi-touch {
+ compatible = "regulator-fixed";
+ gpio = <&mcu 1 GPIO_ACTIVE_HIGH>;
+ regulator-name = "rpi-touch";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ startup-delay-us = <50000>;
+ enable-active-high;
+ };
+};
+
+&hdmi_bridge {
+ status = "disabled";
+};
+
+&hdmi_connector {
+ status = "disabled";
+};
+
+&i2c4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ mcu: gpio@45 {
+ compatible = "raspberrypi,touchscreen-panel-regulator-v2";
+ reg = <0x45>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ #pwm-cells = <3>;
+ };
+
+ touchscreen@5d {
+ compatible = "goodix,gt911";
+ reg = <0x5d>;
+ AVDD28-supply = <®_dsi_touch>;
+ touchscreen-size-x = <720>;
+ touchscreen-size-y = <1280>;
+ };
+};
+
+&mdss_dsi0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "raspberrypi,dsi-7inch", "ilitek,ili9881c";
+ reg = <0>;
+ reset-gpios = <&mcu 0 GPIO_ACTIVE_LOW>;
+ power-supply = <®_display>;
+ iovcc-supply = <&pm8150_s4>;
+ backlight = <&display_bl>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ data-lanes = <0 1>;
+ remote-endpoint = <&panel_in>;
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 6/7] arm64: defconfig: Enable Waveshare DSI panel and touch GPIO drivers
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
` (4 preceding siblings ...)
2026-10-21 14:21 ` [PATCH 5/7] arm64: dts: qcom: shikra-iqs-evk: Add RPi 7-inch DSI panel overlay vishnu.saini
@ 2026-10-21 14:21 ` Vishnu Saini
2026-10-21 14:21 ` [PATCH 7/7] arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay vishnu.saini
6 siblings, 0 replies; 11+ messages in thread
From: Vishnu Saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang
Enable the Waveshare DSI touch GPIO/backlight controller driver and the
Jadard JD9365DA-H3 DSI panel driver, as modules, for the Waveshare 8
inch DSI panel on the 22-pin JDISP1 DSI0 connector on the Qualcomm Shikra
EVK, Talos Lyra EVK boards.
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 9c4c47a44af9..73c07961f655 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -727,6 +727,7 @@ CONFIG_GPIO_SYSCON=y
CONFIG_GPIO_UNIPHIER=y
CONFIG_GPIO_VF610=y
CONFIG_GPIO_VISCONTI=y
+CONFIG_GPIO_WAVESHARE_DSI_TOUCH=m
CONFIG_GPIO_WCD934X=m
CONFIG_GPIO_XGENE=y
CONFIG_GPIO_XGENE_SB=y
@@ -1032,6 +1033,7 @@ CONFIG_DRM_PANEL_ILITEK_ILI7807S=m
CONFIG_DRM_PANEL_ILITEK_ILI9806E_SPI=m
CONFIG_DRM_PANEL_ILITEK_ILI9881C=m
CONFIG_DRM_PANEL_ILITEK_ILI9882T=m
+CONFIG_DRM_PANEL_JADARD_JD9365DA_H3=m
CONFIG_DRM_PANEL_KHADAS_TS050=m
CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m
CONFIG_DRM_PANEL_NOVATEK_NT36672A=m
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 7/7] arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
` (5 preceding siblings ...)
2026-10-21 14:21 ` [PATCH 6/7] arm64: defconfig: Enable Waveshare DSI panel and touch GPIO drivers Vishnu Saini
@ 2026-10-21 14:21 ` vishnu.saini
2026-10-21 14:37 ` sashiko-bot
6 siblings, 1 reply; 11+ messages in thread
From: vishnu.saini @ 2026-10-21 14:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-msm, devicetree, linux-kernel, linux-rpi-kernel,
linux-arm-kernel, Vishnu Saini, venkata.valluru, Jessica Zhang,
Shashank Maurya
From: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
Add a DT overlay to enable Waveshare 8-inch DSI panel connected to DSI
22pin on the carrier card.
DSI0 from SOC is routed through MUX which can be selected by DIP switch
S1016.5 ON, for enabling this 22-pin JDISP1 DSI0 connector.
Add the JD9365DA-H3 panel, GPIO expander at I2C4 address 0x45 for
panel power, reset and backlight, and the Goodix GT9271 touch
controller.
Disable the default HDMI bridge and connector in favour of the
Waveshare DSI panel.
Signed-off-by: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 2 +
.../qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso | 77 ++++++++++++++++++++++
2 files changed, 79 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6d64e7ce197e..2d25e3cc81f4 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -383,12 +383,14 @@ shikra-cqs-evk-hdmi-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-hdmi.dtbo
shikra-iqs-evk-dlc-panel-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-dlc-panel.dtbo
shikra-iqs-evk-lvds-auo,g133han01-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-lvds-auo,g133han01.dtbo
shikra-iqs-evk-raspberrypi-dsi-7inch-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-raspberrypi-dsi-7inch.dtbo
+shikra-iqs-evk-waveshare-dsi-8inch-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-waveshare-dsi-8inch.dtbo
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-hdmi.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-dlc-panel.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-lvds-auo,g133han01.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-raspberrypi-dsi-7inch.dtb
+dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-waveshare-dsi-8inch.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso
new file mode 100644
index 000000000000..d0aa115681ff
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso
@@ -0,0 +1,77 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+
+&{/} {
+ model = "Qualcomm Technologies, Inc. Shikra IQS EVK Waveshare 8inch DSI Panel";
+
+ panel_avdd: regulator-panel-avdd {
+ compatible = "regulator-fixed";
+ regulator-name = "panel-avdd";
+ gpios = <&wsgpio 0 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ panel_iovcc: regulator-panel-iovcc {
+ compatible = "regulator-fixed";
+ regulator-name = "panel-iovcc";
+ gpios = <&wsgpio 4 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+};
+
+&hdmi_bridge {
+ status = "disabled";
+};
+
+&hdmi_connector {
+ status = "disabled";
+};
+
+&i2c4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wsgpio: gpio@45 {
+ compatible = "waveshare,dsi-touch-gpio";
+ reg = <0x45>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ touchscreen@5d {
+ compatible = "goodix,gt9271";
+ reg = <0x5d>;
+ reset-gpios = <&wsgpio 9 GPIO_ACTIVE_HIGH>;
+ };
+};
+
+&mdss_dsi0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "waveshare,8.0-dsi-touch-a", "jadard,jd9365da-h3";
+ reg = <0>;
+ reset-gpios = <&wsgpio 1 GPIO_ACTIVE_LOW>;
+ vccio-supply = <&panel_iovcc>;
+ vdd-supply = <&panel_avdd>;
+ backlight = <&wsgpio>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&panel_in>;
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/7] arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS panel overlay
2026-10-21 14:21 ` [PATCH 3/7] arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS " vishnu.saini
@ 2026-10-21 14:33 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-21 14:33 UTC (permalink / raw)
To: vishnu.saini; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] arm64: dts: qcom: missing status okay on i2c3 node in lvds overlay
- [Medium] arm64: dts: qcom: missing backlight property in panel-lvds node
--
commit b4b78d829d507a91f08f278892b57ecc12f421d2
Author: Anand Tiwari <anand.tiwari@oss.qualcomm.com>
arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS panel overlay
This commit adds a device tree overlay for shikra-iqs-evk to support the
auo,g133han01 panel connected through a ti,sn65dsi84 bridge on i2c3, while
disabling the default hdmi bridge and connector.
> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso
> new file mode 100644
> index 0000000000000..80b9dcc920612
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso
> @@ -0,0 +1,127 @@
[ ... ]
> +&{/} {
> + backlight {
> + compatible = "gpio-backlight";
> + gpios = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
> + default-on;
> + pinctrl-0 = <&backlight_pwm>;
> + pinctrl-names = "default";
> + };
> +
> + panel-lvds {
> + compatible = "auo,g133han01";
> + power-supply = <&vreg_lvds_3p3>;
[Severity: Medium]
In arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso, the
backlight node is defined without a phandle label, and panel-lvds does not
have a backlight property referencing it.
When panel_simple_probe() in drivers/gpu/drm/panel/panel-simple.c probes
auo,g133han01, it looks up the panel backlight via drm_panel_of_backlight():
err = drm_panel_of_backlight(&panel->base);
if (err) {
dev_err_probe(dev, err, "Could not find backlight\n");
goto disable_pm_runtime;
}
Because the backlight property is missing on panel-lvds,
panel->base.backlight remains unset, so drm_panel_enable() and
drm_panel_disable() will not control the gpio-backlight device during
display blanking or system suspend and resume.
Should the backlight node be given a label and referenced from panel-lvds
with backlight = <&backlight>;?
[ ... ]
> +&i2c3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@2c {
> + compatible = "ti,sn65dsi84";
> + reg = <0x2c>;
[Severity: High]
In arch/arm64/boot/dts/qcom/shikra.dtsi, i2c3 is disabled by default:
i2c3: i2c@4a8c000 {
compatible = "qcom,geni-i2c";
...
status = "disabled";
};
Neither shikra-iqs-som.dtsi, shikra-evk.dtsi, nor shikra-iqs-evk.dts
enables i2c3. In
arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso, &i2c3
populates the bridge@2c child node and &mdss_dsi0_out is redirected to
&sn65dsi84_in, but &i2c3 does not set status = "okay";.
When this overlay is applied, i2c3 stays disabled, the ti,sn65dsi84 bridge
at bridge@2c is never instantiated, and
msm_dsi_modeset_init() -> drm_of_find_panel_or_bridge() defers probe
indefinitely waiting for sn65dsi84_in.
Does &i2c3 need status = "okay"; here so that the parent controller and
bridge@2c can probe?
[ ... ]
> +&mdss_dsi0_out {
> + remote-endpoint = <&sn65dsi84_in>;
> +};
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-shikra_display_overlays-v1-0-adaea735999f@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 7/7] arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay
2026-10-21 14:21 ` [PATCH 7/7] arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay vishnu.saini
@ 2026-10-21 14:37 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-21 14:37 UTC (permalink / raw)
To: vishnu.saini; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] arm64: dts: qcom: missing panel_vcc regulator on wsgpio 8 in Waveshare overlay
--
commit 8859b55c691118c8af80fdf98b5e594862815afd
Author: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay
This commit adds a devicetree overlay for the Waveshare 8-inch DSI panel on
the Shikra IQS EVK carrier board, configuring the jadard,jd9365da-h3 panel,
the waveshare,dsi-touch-gpio expander, and the goodix,gt9271 touchscreen
while disabling the default hdmi output.
> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso
> new file mode 100644
> index 0000000000000..d0aa115681ffd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-waveshare-dsi-8inch.dtso
> @@ -0,0 +1,77 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +&{/} {
> + model = "Qualcomm Technologies, Inc. Shikra IQS EVK Waveshare 8inch DSI Panel";
> +
> + panel_avdd: regulator-panel-avdd {
> + compatible = "regulator-fixed";
> + regulator-name = "panel-avdd";
> + gpios = <&wsgpio 0 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + panel_iovcc: regulator-panel-iovcc {
> + compatible = "regulator-fixed";
> + regulator-name = "panel-iovcc";
> + gpios = <&wsgpio 4 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +};
> +
> +&hdmi_bridge {
> + status = "disabled";
> +};
> +
> +&hdmi_connector {
> + status = "disabled";
> +};
> +
> +&i2c4 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + wsgpio: gpio@45 {
> + compatible = "waveshare,dsi-touch-gpio";
> + reg = <0x45>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> + touchscreen@5d {
> + compatible = "goodix,gt9271";
> + reg = <0x5d>;
> + reset-gpios = <&wsgpio 9 GPIO_ACTIVE_HIGH>;
> + };
> +};
[Severity: High]
Does this leave the Waveshare vcc rail unpowered?
In drivers/gpio/gpio-waveshare-dsi.c, the expander maps offset 8 to the vcc
rail and offset 9 to touchscreen reset:
enum {
GPIO_AVDD = 0,
GPIO_PANEL_RESET = 1,
GPIO_BL_ENABLE = 2,
GPIO_IOVCC = 4,
GPIO_VCC = 8,
GPIO_TS_RESET = 9,
};
During waveshare_gpio_probe()->waveshare_gpio_set(), state->poweron_state
starts at 0 and asserting offset 9 writes the upper byte of
state->poweron_state to the touch register:
last_val = state->poweron_state;
if (value)
last_val |= BIT(offset);
else
last_val &= ~BIT(offset);
state->poweron_state = last_val;
err = regmap_write(state->regmap, REG_TP, last_val >> 8);
if (!err)
err = regmap_write(state->regmap, REG_LCD, last_val & 0xff);
Because the overlay only defines panel_avdd (offset 0) and panel_iovcc
(offset 4) under &{/} and does not configure a regulator for wsgpio
offset 8, bit 0 of the touch register is driven low on every
waveshare_gpio_set() call and never enabled before goodix_ts_probe()
accesses touchscreen@5d.
Should &{/} also define a panel_vcc regulator for wsgpio offset 8 (as in
Documentation/devicetree/bindings/gpio/waveshare,dsi-touch-gpio.yaml, or
wired to touchscreen@5d) so the vcc rail is enabled?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-shikra_display_overlays-v1-0-adaea735999f@oss.qualcomm.com?part=7
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay
2026-10-21 14:21 ` [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay vishnu.saini
@ 2026-10-21 14:37 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-21 14:37 UTC (permalink / raw)
To: vishnu.saini; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: unit_address_vs_reg warning on panel@0 in HDMI overlay
--
commit 76425af69dfb56a6561d933cc0de85c2b87df761
Author: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay
This commit adds a device tree overlay for the Shikra evaluation kits to
enable hdmi output via the lt9611uxd bridge on i2c4 and disable the default
dsi0 panel node.
> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso b/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso
> new file mode 100644
> index 0000000000000..a7b77114061a5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso
[ ... ]
> +&mdss_dsi0 {
> + panel@0 {
> + status = "disabled";
> + };
> +};
[Severity: Low]
Does defining panel@0 inside &mdss_dsi0 without a reg property trigger a
dtc unit_address_vs_reg warning when building device trees with extra
warnings enabled?
In scripts/Makefile.dtbs, -Wno-unit_address_vs_reg is not passed to dtc
when extra warnings are enabled:
scripts/Makefile.dtbs:
ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
DTC_FLAGS += -Wno-unit_address_vs_reg \
...
When dtc compiles shikra-cqm-cqs-evk-hdmi.dtso, check_unit_address_vs_reg()
in scripts/dtc/checks.c only exempts the fragment node that directly
contains __overlay__, not child nodes nested inside __overlay__:
scripts/dtc/checks.c:check_unit_address_vs_reg() {
if (get_subnode(node, "__overlay__")) {
/* HACK: Overlay fragments are a special case */
return;
}
...
} else {
if (unitname[0])
FAIL(c, dti, node, "node has a unit name, but no reg or ranges property");
}
}
Because panel@0 has a unit address and no reg property in the overlay, dtc
warns on /fragment@2/__overlay__/panel@0.
Could panel@0 be given a label in arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
and arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts so the overlay can disable it
via a top-level phandle reference (or specify #address-cells, #size-cells,
and reg = <0> here)?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-shikra_display_overlays-v1-0-adaea735999f@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-10-21 14:37 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-21 14:21 [PATCH 0/7] arm64: dts: qcom: shikra: Add display overlays for EVK boards vishnu.saini
2026-10-21 14:21 ` [PATCH 1/7] arm64: dts: qcom: shikra-cqm-evk, shikra-cqs-evk: Add HDMI overlay vishnu.saini
2026-10-21 14:37 ` sashiko-bot
2026-10-21 14:21 ` [PATCH 2/7] arm64: dts: qcom: shikra-iqs-evk: Add DLC0697 panel overlay Vishnu Saini
2026-10-21 14:21 ` [PATCH 3/7] arm64: dts: qcom: shikra-iqs-evk: Add AUO G133HAN01 LVDS " vishnu.saini
2026-10-21 14:33 ` sashiko-bot
2026-10-21 14:21 ` [PATCH 4/7] arm64: defconfig: Enable RPi touchscreen V2 regulator and ILI9881C panel Vishnu Saini
2026-10-21 14:21 ` [PATCH 5/7] arm64: dts: qcom: shikra-iqs-evk: Add RPi 7-inch DSI panel overlay vishnu.saini
2026-10-21 14:21 ` [PATCH 6/7] arm64: defconfig: Enable Waveshare DSI panel and touch GPIO drivers Vishnu Saini
2026-10-21 14:21 ` [PATCH 7/7] arm64: dts: qcom: shikra-iqs-evk: Add Waveshare 8-inch DSI panel overlay vishnu.saini
2026-10-21 14:37 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox