Re: [PATCH 4/6] arm64: dts: qcom: sm8250-hdk: Enable the PCIe ports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: undefined phandle reference vreg_3p3 in pcie2 node
--

commit be0d22fcb00f618941a1790f86db070c0405b5a5
Author: redstonee <1516235445@qq.com>

arm64: dts: qcom: sm8250-hdk: Enable the PCIe ports

This commit enables the pcie0 and pcie2 controller and PHY nodes in
arch/arm64/boot/dts/qcom/sm8250-hdk.dts for the on-board WiFi and M.2
connector.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-hdk.dts b/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
> index 9ff15d9d7f0f6..77273b6c2216a 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
> @@ -712,3 +712,24 @@ pm8150b_typec_sbu_out: endpoint {
>  &usb_1_qmpphy_dp_in {
>  	remote-endpoint = <&mdss_dp_out>;
>  };
> +
> +&pcie0 {
> +	status = "okay";
> +};
> +
> +&pcie0_phy {
> +	vdda-phy-supply = <&vreg_l5a_0p88>;
> +	vdda-pll-supply = <&vreg_l9a_1p2>;
> +	status = "okay";
> +};
> +
> +&pcie2 {
> +	status = "okay";
> +	vddpe-3v3-supply = <&vreg_3p3>;
> +};

[Severity: Medium]
Does enabling pcie2 with vddpe-3v3-supply = <&vreg_3p3> in
arch/arm64/boot/dts/qcom/sm8250-hdk.dts break building qcom/sm8250-hdk.dtb at
this commit?

Neither arch/arm64/boot/dts/qcom/sm8250-hdk.dts nor any of its included files
(sm8250.dtsi, pm8150.dtsi, pm8150b.dtsi, pm8150l.dtsi) defines the vreg_3p3
label at this point in the series, which causes dtc to fail with a reference
to a non-existent node or label.

The vreg_3p3 fixed-regulator node is only introduced in the subsequent commit
b98ad1ad783f ("arm64: dts: qcom: sm8250-hdk: Add the QCA6390 NIC"). Should the
vreg_3p3 regulator definition be moved into or before this commit so that each
commit in the series builds cleanly for bisection?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022113601.2320940-1-dc_redstone@outlook.com?part=4