From: sashiko-bot@kernel.org
To: "Xilin Wu" <sophon@radxa.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: add missing Iris IOMMU SID
Date: Thu, 29 Oct 2026 16:25:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-189658@kernel.org> (raw)
In-Reply-To: <20261030-sc8280xp-iris-iommu-v1-1-1e3fb8562b3d@radxa.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: sc8280xp iris iommus exceeds sm8250-venus schema maxItems
--
commit 6441bb3f503ae341ba67b0bfcbe9378b5b24f71b
Author: Xilin Wu <sophon@radxa.com>
arm64: dts: qcom: sc8280xp: add missing Iris IOMMU SID
This commit adds the missing 0x2a07 IOMMU stream ID to the Iris VPU node
on SC8280XP so that both access paths are mapped by the SMMU during video
decode.
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index d17475c3e66c9..4ab01ef9ac053 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -4268,7 +4268,8 @@ &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
> "video-mem";
>
> operating-points-v2 = <&iris_opp_table>;
> - iommus = <&apps_smmu 0x2a00 0x400>;
> + iommus = <&apps_smmu 0x2a00 0x400>,
> + <&apps_smmu 0x2a07 0x400>;
[Severity: Low]
Does Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml also
need an update for this change?
In arch/arm64/boot/dts/qcom/sc8280xp.dtsi, the iris (video-codec@aa00000)
node matches Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml:
properties:
compatible:
oneOf:
- const: qcom,sm8250-venus
- items:
- enum:
- qcom,sc8280xp-iris
- qcom,sm8350-iris
- const: qcom,sm8250-venus
...
iommus:
maxItems: 1
Adding a second entry to iommus without updating maxItems in the binding
schema causes dtbs_check to fail on SC8280XP and SA8540P device trees.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030-sc8280xp-iris-iommu-v1-1-1e3fb8562b3d@radxa.com?part=1
prev parent reply other threads:[~2026-10-29 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 16:14 [PATCH] arm64: dts: qcom: sc8280xp: add missing Iris IOMMU SID Xilin Wu
2026-10-29 16:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-189658@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sophon@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox