Re: [PATCH net-next v4 01/10] dt-bindings: net: airoha: Add EN7581 ethernet-ports properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `ethernet-port` subnode schema strictly rejects standard Ethernet configuration properties, preventing functional device tree definitions.
- [High] The `if` condition matching the `reg` property uses an invalid schema structure, causing the condition to silently fail and incorrectly reject `ethernet-port` nodes.
--

commit 72efd994288c48f80a1fe4d15ff7c3fd115c30a4
Author: Lorenzo Bianconi <lorenzo@kernel.org>

dt-bindings: net: airoha: Add EN7581 ethernet-ports properties

This commit introduces the ethernet-port property to model multiple
net_devices connected to the same GDM3 or GDM4 port on EN7581 and AN7583
SoCs. It updates the airoha,en7581-eth binding to allow external
ethernet port IDs on specific MAC ports.

> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> --- a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
[ ... ]
>      allOf:
>        - if:
>            properties:
>              reg:
>                items:
>                  - enum:
>                      - 3
>                      - 4

Does this condition correctly match the reg property? In dt-schema, the reg
property is evaluated as a matrix (an array of arrays). Using items: - enum:
with integers attempts to match the first element (which is an array) against
an integer, which will always evaluate to false.

Because this condition silently fails, the then clause below is never applied,
and device trees using ethernet-port nodes on MAC 3 or 4 will fail validation.
Standard bindings typically match specific reg values using an enum directly
under reg, or by differentiating compatible strings.

>          then:
>            patternProperties:
>              "^ethernet-port@[0-5]$":
>                type: object
>                unevaluatedProperties: false
>                description: External ethernet port ID available on the GDM port
>  
>                properties:
>                  compatible:
>                    const: airoha,eth-port
>  
>                  reg:
>                    maxItems: 1
>                    description: External ethernet port identifier

Will this strict schema reject standard Ethernet configuration properties?

Since unevaluatedProperties is set to false and only compatible and reg
are defined, any device tree attempting to configure essential networking
properties (like mac-address, phy-handle, or phy-mode) for these ports
will fail validation.

Should this subnode include a reference to
/schemas/net/ethernet-controller.yaml# to permit functional networking
definitions?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507-airoha-eth-multi-serdes-v4-0-af613b61ae02@kernel.org?part=1