Re: [PATCH v3 4/6] arm64: dts: qcom: Add device tree for Lemans GearVM variant

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: duplicate reserved-memory nodes in lemans-gearvm.dtsi
--

commit 2d9e6864e7af49f91d36dd5dcddab2e975bc9d47
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Lemans GearVM variant

This commit adds lemans-gearvm.dtsi for the Lemans GearVM variant (SA8255P),
which manages platform resources such as clocks, interconnects, and most TLMM
settings via SCMI over a Qualcomm SMC/HVC transport. It also labels the
firmware, scm, and reserved-memory nodes in lemans.dtsi so they can be
overridden by label in lemans-gearvm.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
> new file mode 100644
> index 0000000000000..91c97a55f2787
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
> @@ -0,0 +1,3224 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include "lemans.dtsi"

[ ... ]

> +&reserved_memory {

[ ... ]

> +	firmware_mem: firmware-region@b0000000 {
> +		reg = <0x0 0xb0000000 0x0 0x800000>;
> +		no-map;
> +	};

[ ... ]

> +	firmware_logs_mem: firmware-logs@d0040000 {
> +		reg = <0x0 0xd0040000 0x0 0x10000>;
> +		no-map;
> +	};
> +
> +	firmware_audio_mem: firmware-audio@d0050000 {
> +		reg = <0x0 0xd0050000 0x0 0x4000>;
> +		no-map;
> +	};
> +
> +	firmware_camera_mem: firmware-camera@d0054000 {
> +		no-map;
> +		reg = <0x0 0xd0054000 0x0 0x2000>;
> +	};
> +
> +	firmware_reserved_mem: firmware-reserved@d0056000 {
> +		reg = <0x0 0xd0056000 0x0 0x9a000>;
> +		no-map;
> +	};
> +
> +	firmware_quantum_test_mem: firmware-quantum-test@d00f0000 {
> +		reg = <0x0 0xd00f0000 0x0 0x10000>;
> +		no-map;
> +	};
> +
> +	tags_mem: tags@d0100000 {
> +		reg = <0x0 0xd0100000 0x0 0x1200000>;
> +		no-map;
> +	};
> +
> +	qtee_mem: qtee@d1300000 {
> +		reg = <0x0 0xd1300000 0x0 0x500000>;
> +		no-map;
> +	};
> +
> +	deepsleep_backup_mem: deepsleep-backup@d1800000 {
> +		reg = <0x0 0xd1800000 0x0 0x100000>;
> +		no-map;
> +	};
> +
> +	trusted_apps_mem: trusted-apps@d1900000 {
> +		reg = <0x0 0xd1900000 0x0 0x3800000>;
> +		no-map;
> +	};
> +
> +	tz_stat_mem: tz-stat@db100000 {
> +		reg = <0x0 0xdb100000 0x0 0x100000>;
> +		no-map;
> +	};
> +
> +	cpucp_fw_mem: cpucp-fw@db200000 {
> +		reg = <0x0 0xdb200000 0x0 0x100000>;
> +		no-map;
> +	};

[Severity: Low]
This isn't a bug, but since lemans-gearvm.dtsi includes lemans.dtsi and
overrides &reserved_memory by label, nine child nodes that are neither deleted
nor modified in &reserved_memory are redefined here with the exact same
unit-addresses, labels, reg ranges, and no-map properties as in lemans.dtsi:

  firmware_mem (firmware-region@b0000000)
  firmware_logs_mem (firmware-logs@d0040000)
  firmware_audio_mem (firmware-audio@d0050000)
  firmware_quantum_test_mem (firmware-quantum-test@d00f0000)
  tags_mem (tags@d0100000)
  qtee_mem (qtee@d1300000)
  deepsleep_backup_mem (deepsleep-backup@d1800000)
  tz_stat_mem (tz-stat@db100000)
  cpucp_fw_mem (cpucp-fw@db200000)

Could these unchanged child nodes be omitted from &reserved_memory in
lemans-gearvm.dtsi so they are inherited from lemans.dtsi like the other
unchanged reserved-memory regions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261031131042.1200862-1-shengchao.guo@oss.qualcomm.com?part=4