Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ADLINK

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: vendor-prefixes: adlink entry added out of alphabetical order
- [Low] dt-bindings: vendor-prefixes: Author and Signed-off-by email mismatch
--

commit dba9f5e74cdb4e9777b31ecece91c151c0904cf4
Author: Dinesh kumar v <dineshkumarv85@gmail.com>

dt-bindings: vendor-prefixes: Add ADLINK

This commit adds the adlink vendor prefix for ADLINK Technology Inc. to the
device tree vendor-prefixes schema.

>     dt-bindings: vendor-prefixes: Add ADLINK
>     
>     Add the ADLINK Technology Inc. vendor prefix for device tree
>     compatible strings used by ADLINK hardware.
>     
>     Signed-off-by: Dinesh kumar v <dinesh.v@adlinktech.com>

[Severity: Low]
The commit Author email address (dineshkumarv85@gmail.com) does not match the
Signed-off-by email address (dinesh.v@adlinktech.com), which triggers a
checkpatch FROM_SIGN_OFF_MISMATCH warning. Should the Author and Signed-off-by
addresses be aligned?

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index c981a133753e9..eee3764fab51e 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -70,6 +70,8 @@ patternProperties:
>      description: ADI Engineering, Inc.
>    "^admatec,.*":
>      description: admatec GmbH
> +  "^adlink,.*":
> +    description: ADLINK Technology Inc.

[Severity: Low]
The patternProperties list in
Documentation/devicetree/bindings/vendor-prefixes.yaml specifies:

  # Keep list in alphabetical order.

Should the "^adlink,.*" entry be placed before "^admatec,.*" rather than after
it to maintain alphabetical ordering?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102102653.272056-1-dinesh.v@adlinktech.com?part=1