Re: [PATCH v4 04/22] ASoC: dt-bindings: Add binding for Apple Silicon Mac audio

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: dt-bindings: apple,macaudio: drop unnecessary #address-cells/#size-cells
--

commit 7babcc38fd08c53ef9be38d7c4acfca64730a1a5
Author: Martin Povišer <povik+lin@cutebit.org>

ASoC: dt-bindings: Add binding for Apple Silicon Mac audio

This commit adds a Devicetree binding schema for the primary audio
subsystem found on Apple Silicon Macs, integrating the SoC I2S peripheral
and codecs for the headphone jack and speaker arrays.

> diff --git a/Documentation/devicetree/bindings/sound/apple,macaudio.yaml b/Documentation/devicetree/bindings/sound/apple,macaudio.yaml
> new file mode 100644
> index 0000000000000..7a97ce5bb7a1d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/apple,macaudio.yaml
> @@ -0,0 +1,195 @@

[ ... ]

> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +  model:
> +    description:
> +      Model name for presentation to users
> +    $ref: /schemas/types.yaml#/definitions/string
> +
> +patternProperties:
> +  "^([a-z]+-)?dai-link$":
> +    description: Node for each sound peripheral such as the speaker array,
> +      headphones jack, or microphone.
> +    type: object
> +    $ref: tdm-slot.yaml#
> +    unevaluatedProperties: false

[ ... ]

> +required:
> +  - '#address-cells'
> +  - '#size-cells'
> +  - compatible
> +  - model

[Severity: Low]
Are #address-cells and #size-cells needed in this binding?

The only child nodes permitted under the sound node match the pattern
^([a-z]+-)?dai-link$ with unevaluatedProperties: false, which forbids unit
addresses in the child node names and disallows reg and ranges properties
on the child nodes. The parent sound node also sets additionalProperties:
false without allowing ranges or dma-ranges.

Because these properties are marked as required, any conforming devicetree
source file will trigger a dtc avoid_unnecessary_addr_size warning when
compiled with W=1 in scripts/dtc/checks.c:check_avoid_unnecessary_addr_size():

	FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\", \"dma-ranges\" or child \"reg\" or \"ranges\" property");

Should #address-cells and #size-cells be dropped from properties, required,
and examples in Documentation/devicetree/bindings/sound/apple,macaudio.yaml?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-macaudio-v4-0-637484efe46d@gmail.com?part=4