Re: [PATCH v4 11/22] arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] arm64: dts: apple: t8103-j274: unnecessary #address-cells/#size-cells in sound
- [Low] arm64: dts: apple: t8103-j274: duplicate &i2c2 and root node blocks
--

commit 5f98a7f1339930a19f607ba0ee5a326410be0b76
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes

This commit adds the TI TAS5770L speaker amplifier and Cirrus CS42L83
headset jack codec nodes to the M1 Mac mini (J274) device tree, along
with the sound node linking them to the MCA controller.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
> index 1212852251e07..2fcadd77b1c90 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
> @@ -75,4 +75,74 @@ &i2c2 {
>  	status = "okay";
>  };
>  
> +/* Audio codecs */
> +&i2c1 {
> +	status = "okay";
> +
> +	speaker: codec@31 {
> +		compatible = "ti,tas5770l";
> +		reg = <0x31>;
> +		interrupts-extended = <&pinctrl_ap 182 IRQ_TYPE_LEVEL_LOW>;
> +		shutdown-gpios = <&pinctrl_ap 181 GPIO_ACTIVE_HIGH>;
> +		#sound-dai-cells = <0>;
> +		ti,imon-slot-no = <0>;
> +		ti,vmon-slot-no = <2>;
> +	};
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +
> +	jack_codec: codec@48 {
[ ... ]
> +	};
> +};
> +
> +/ {

[Severity: Low]
As reported by Sashiko on v3 [1], arch/arm64/boot/dts/apple/t8103-j274.dts
already has an &i2c2 block just above &i2c1 that sets status = "okay", as
well as a root / { ... }; node at the top of the file:

    / {
    	compatible = "apple,j274", "apple,t8103", "apple,arm-platform";
    	model = "Apple Mac mini (M1, 2020)";
    	chassis-type = "desktop";

    	aliases {
    		ethernet0 = &ethernet0;
    	};
    };

Could jack_codec be placed inside the existing &i2c2 block (or replace the
earlier stub) and the sound node be placed inside the existing root / node
instead of opening duplicate &i2c2 and / blocks in the same file?

> +	sound: sound {
> +		compatible = "apple,j274-macaudio";
> +		model = "Mac mini J274";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;

[Severity: Low]
Does defining #address-cells and #size-cells in the sound node trigger a
dtc avoid_unnecessary_addr_size warning when building dtbs with W=1?

Neither the sound node nor its headphone-dai-link and speaker-dai-link
child nodes define reg, ranges, or dma-ranges properties, which causes
check_avoid_unnecessary_addr_size() in scripts/dtc/checks.c to warn:

    FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\", \"dma-ranges\" or child \"reg\" or \"ranges\" property");

Should #address-cells and #size-cells be removed from both the sound node
here and Documentation/devicetree/bindings/sound/apple,macaudio.yaml?

[1] https://lore.kernel.org/r/20261018-macaudio-v3-10-abdff7741dea@gmail.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-macaudio-v4-0-637484efe46d@gmail.com?part=11