Re: [PATCH 1/5] dt-bindings: arm: qcom: Document Microsoft Surface Pro X

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: arm: qcom: commit message duplicates carina and omits caspar
--

commit c0354ee6a701cd3d9a5f7b5512415336071339b5
Author: Val Packett <val@packett.cool>

dt-bindings: arm: qcom: Document Microsoft Surface Pro X

This commit replaces the generic microsoft,surface-prox compatible string in
Documentation/devicetree/bindings/arm/qcom.yaml with three model-specific
compatible strings for the Surface Pro X variants.

>     dt-bindings: arm: qcom: Document Microsoft Surface Pro X
>     
>     The Surface Pro X tablet was listed as a single generic compatible in
>     dt-bindings, but a device tree using it has not landed upstream.
>     
>     Replace it with three model-specific compatibles:
>     * microsoft,cambria for the orginal SQ1 model (with cellular)
>     * microsoft,carina for the Wi-Fi-only (SQ1) model
>     * microsoft,carina for the SQ2 refresh
>     
>     Signed-off-by: Val Packett <val@packett.cool>
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 121ca557ce1ef..74f46697a363f 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -925,7 +925,9 @@ properties:
>        - items:
>            - enum:
>                - lenovo,flex-5g
> -              - microsoft,surface-prox
> +              - microsoft,cambria
> +              - microsoft,carina
> +              - microsoft,caspar

[Severity: Low]
In Documentation/devicetree/bindings/arm/qcom.yaml under
properties.compatible, the schema adds microsoft,cambria, microsoft,carina,
and microsoft,caspar, but the commit message lists microsoft,carina twice
(for both the Wi-Fi-only SQ1 model and the SQ2 refresh) and omits
microsoft,caspar.

Should the Wi-Fi-only (SQ1) entry in the commit description say
microsoft,caspar instead of microsoft,carina?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104070441.74127-1-val@packett.cool?part=1