Re: [PATCH 1/2] dt-bindings: sound: Add Tegra268 ADMAIF support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: sound: unwieldy per-compatible conditionals in tegra210-admaif
--

commit 8b302b26b4687658ab926b6d8c1160f749d509a9
Author: Anupama Kunkulagunta <akunkulagunt@nvidia.com>

dt-bindings: sound: Add Tegra268 ADMAIF support

This commit adds the nvidia,tegra268-admaif compatible string and its
per-compatible DMA channel constraints for five RX and five TX channels to
the Tegra210 ADMAIF device tree binding schema.

> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> index 2ce4049f94acc..054bacf602349 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml

[ ... ]

> @@ -134,6 +135,27 @@ allOf:
>            minItems: 1
>            maxItems: 64
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: nvidia,tegra268-admaif
> +    then:
> +      properties:
> +        dmas:
> +          description:
> +            DMA channel specifiers, equally divided for Tx and Rx.
> +          minItems: 1
> +          maxItems: 10
> +        dma-names:
> +          items:
> +            pattern: "^[rt]x[1-5]$"
> +          description:
> +            Should be "rx1", "rx2" ... "rx5" for DMA Rx channel
> +            Should be "tx1", "tx2" ... "tx5" for DMA Tx channel
> +          minItems: 1
> +          maxItems: 10

[Severity: Low]
This isn't a bug, but in Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml,
the top-level properties section leaves dmas and dma-names as bare true
booleans:

  dmas: true

  dma-names: true

while the allOf section already contains three per-compatible if-then blocks
for nvidia,tegra210-admaif, nvidia,tegra186-admaif, and
nvidia,tegra264-admaif. Adding a fourth per-compatible if-then block here for
nvidia,tegra268-admaif duplicates the dmas and dma-names descriptions,
minItems/maxItems bounds, and dma-names pattern structure again.

Since the per-compatible conditionals in this schema are becoming unwieldy
due to variant differences, would it be cleaner to split the variants into
separate schema documents or factor the shared dmas and dma-names definitions
into the top-level properties section instead of piling on another
conditional block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104111836.1100527-1-sheetal@nvidia.com?part=1