Re: [PATCH 6/7] arm64: dts: qcom: sm8350: Add SoundWire and LPASS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: sm8350: wrong PDC wakeup interrupt on swr2 node
--

commit e0bc0fd5876d3b09082c8770bf88a52e98e61a79
Author: Demeter Barna <me@fromdisposition.org>

arm64: dts: qcom: sm8350: Add SoundWire and LPASS

This commit adds the LPASS RX, TX, and VA macro nodes, the RX and TX
SoundWire controller nodes along with the LPASS audio clock controller,
and the LPI pin configuration states for SoundWire and DMICs on SM8350.

> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 55b32050ce9c8..85476a04ea3fd 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
[ ... ]
> @@ -2022,6 +2023,133 @@ compute-cb@5 {
[ ... ]
> +		swr2: soundwire@3230000 {
> +			compatible = "qcom,soundwire-v1.6.0";
> +			reg = <0 0x03230000 0 0x2000>;
> +			interrupts-extended = <&intc GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pdc 130 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "core", "wakeup";

[Severity: Medium]
Should the wakeup interrupt on swr2 use PDC pin 70 instead of 130 on
SM8350?

When swr2 enters runtime suspend via swrm_runtime_suspend() in
drivers/soundwire/qcom.c, it stops the bus clock and enables
ctrl->wake_irq so that a peripheral pulling TX data lane 0
(WCD_SWR_TX_DATA0, LPI gpio1 / TLMM gpio169 on SM8350) high can wake the
controller.

In drivers/pinctrl/qcom/pinctrl-sm8350.c, sm8350_pdc_map routes TLMM
gpio169 to PDC pin 70 (which pdc maps to GIC_SPI 520 via
qcom,pdc-ranges), whereas PDC pin 130 is the SC7280 mapping and is not
mapped to any GPIO on SM8350:

drivers/pinctrl/qcom/pinctrl-sm8350.c:sm8350_pdc_map[] = {
	...
	{ 169, 70 }, { 172, 132 }, { 174, 87 }, { 175, 88 }, { 177, 89 },
	...
};

With <&pdc 130 IRQ_TYPE_LEVEL_HIGH>, peripheral wakeup events on the TX
SoundWire bus will not fire during runtime suspend.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-b4-sm8350-sound-v1-0-4c872df294fa@fromdisposition.org?part=6