Re: [PATCH 1/7] dt-bindings: clock: qcom,sc8280xp-lpasscc: Add SM8350 LPASS audio CSR

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: clock: missing sc7280 header in qcom,sc8280xp-lpasscc See also
--

commit dee8eaeed95bbc7385e8c1208d78c9a4483b6760
Author: Demeter Barna <me@fromdisposition.org>

dt-bindings: clock: qcom,sc8280xp-lpasscc: Add SM8350 LPASS audio CSR

This commit adds the qcom,sm8350-lpassaudiocc compatible to the
qcom,sc8280xp-lpasscc binding schema for the SM8350 LPASS audio CSR block,
which only provides resets to the OS and uses the SC7280 reset IDs.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
> index f235b4e24cc70..3d4a794abf134 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
> @@ -22,6 +22,7 @@ properties:
>        - enum:
>            - qcom,sc8280xp-lpassaudiocc
>            - qcom,sc8280xp-lpasscc
> +          - qcom,sm8350-lpassaudiocc

[Severity: Low]
As noted in the commit message and implemented in
drivers/clk/qcom/lpassaudiocc-sc7280.c, qcom,sm8350-lpassaudiocc binds to
lpass_audio_cc_reset_sc7280_desc and uses the reset IDs from
include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h:

  LPASS_AUDIO_SWR_RX_CGCR  0
  LPASS_AUDIO_SWR_TX_CGCR  1
  LPASS_AUDIO_SWR_WSA_CGCR 2

However, the description property in
Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml only
lists the SC8280XP header:

  description: |
    Qualcomm LPASS core and audio clock control module provides the clocks,
    and reset on SC8280XP.

    See also:
      include/dt-bindings/clock/qcom,lpasscc-sc8280xp.h

In include/dt-bindings/clock/qcom,lpasscc-sc8280xp.h, the same macro names
have different numeric values (with LPASS_AUDIO_SWR_WSA_CGCR defined as 1
and LPASS_AUDIO_SWR_TX_CGCR defined as 0 for the LPASS TCSR block).

Should include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h also be listed
under "See also:" in description so that users of this binding know where
the SM8350 reset IDs are defined?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-b4-sm8350-sound-v1-0-4c872df294fa@fromdisposition.org?part=1