[PATCH 1/1] Revert "arm64: dts: imx8qm-ss-conn: add usbotg3 iommu information"

[PATCH 1/1] Revert "arm64: dts: imx8qm-ss-conn: add usbotg3 iommu information"

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

This reverts commit 73c3b40e536d9cb624db90b460bc384147576a57. There is
a hack in U-Boot, which calls sc_rm_set_master_sid() to set the SID for
bus masters that depend on power domain information of the node. But
cdns_usb is a child node of the glue driver, which does not need power
domain information.

More time is needed to find a good method to program sc_rm_set_master_sid()
in the kernel and reduce U-Boot dependence. So revert this patch first to
get USB host working again.

Reported-by: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
Link: https://lore.kernel.org/imx/b911ff91-ce7b-462e-a7fb-f8c6d682c85b@gmail.com/
Cc: Peng Fan <peng.fan@oss.nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi
index f25f62d51f69e..1d1cde2bd879d 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi
@@ -67,7 +67,3 @@ &usdhc3 {
 	compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
 	iommus = <&smmu 0x11 0x7f80>;
 };
-
-&usbotg3_cdns3 {
-	iommus = <&smmu 0x4 0x7f80>;
-};
-- 
2.43.0

Re: [PATCH 1/1] Revert "arm64: dts: imx8qm-ss-conn: add usbotg3 iommu information"

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: imx8qm-ss-conn: missing Fixes trailer on revert of
  73c3b40e536d
--

commit c86416aa16fabe358034dcb770ee1f94d28923c0
Author: Frank Li <Frank.Li@nxp.com>

> Revert "arm64: dts: imx8qm-ss-conn: add usbotg3 iommu information"
>
> This reverts commit 73c3b40e536d9cb624db90b460bc384147576a57. There is
> a hack in U-Boot, which calls sc_rm_set_master_sid() to set the SID for
> bus masters that depend on power domain information of the node. But
> cdns_usb is a child node of the glue driver, which does not need power
> domain information.
>
> More time is needed to find a good method to program sc_rm_set_master_sid()
> in the kernel and reduce U-Boot dependence. So revert this patch first to
> get USB host working again.
>
> Reported-by: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
> Link: https://lore.kernel.org/imx/b911ff91-ce7b-462e-a7fb-f8c6d682c85b@gmail.com/
> Cc: Peng Fan <peng.fan@oss.nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

[Severity: Low]
Since this revert fixes a regression that broke USB host mode, should the
commit trailers include:

  Fixes: 73c3b40e536d ("arm64: dts: imx8qm-ss-conn: add usbotg3 iommu information")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106161809.3512378-1-Frank.Li@oss.nxp.com?part=1