Re: [PATCH v2 4/4] arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: apple: t8132: root model placed before compatible
  breaks strict style
- [Low] arm64: dts: apple: t8132: #address-cells after nonposted-mmio
  and unsorted props
--

commit 85a1def59cfd948af8883a7bded0a54104bc0b30
Author: Yureka Lilian <yureka@cyberchaos.dev>

arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues

This commit reorders nodes and properties in the Apple t8132 device trees to
address strict dt-check-style warnings.

> diff --git a/arch/arm64/boot/dts/apple/t8132-j604.dts b/arch/arm64/boot/dts/apple/t8132-j604.dts
> index 93076cd923a93..ebf25fb1bd3cd 100644
> --- a/arch/arm64/boot/dts/apple/t8132-j604.dts
> +++ b/arch/arm64/boot/dts/apple/t8132-j604.dts
> @@ -14,8 +14,8 @@
>  #include <dt-bindings/leds/common.h>
>  
>  / {
> -	compatible = "apple,j604", "apple,t8132", "apple,arm-platform";
>  	model = "Apple MacBook Pro (14-inch, M4, 2024)";
> +	compatible = "apple,j604", "apple,t8132", "apple,arm-platform";
>  
>  	led-controller {
>  		compatible = "pwm-leds";

[Severity: Low]
Does placing model before compatible in the root node introduce a
dt-check-style --mode=strict regression here and in t8132-j623.dts,
t8132-j624.dts, t8132-j713.dts, t8132-j715.dts, and t8132-j773g.dts?

Per Documentation/devicetree/bindings/dts-coding-style.rst and
scripts/dtc/dt-check-style, compatible belongs to the first canonical group
whereas model is a general property, so swapping them triggers a new
property-order warning that compatible should sort before model.

[ ... ]

> diff --git a/arch/arm64/boot/dts/apple/t8132.dtsi b/arch/arm64/boot/dts/apple/t8132.dtsi
> index b1e77a8ae4066..e2e79c7e7fd07 100644
> --- a/arch/arm64/boot/dts/apple/t8132.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8132.dtsi
[ ... ]
> @@ -190,50 +197,44 @@ l2_cache_1: l2-cache-1 {
>  		};
>  	};
>  
> -	clkref: clock-ref {
> -		compatible = "fixed-clock";
> -		#clock-cells = <0>;
> -		clock-frequency = <24000000>;
> -		clock-output-names = "clkref";
> -	};
> -
>  	soc: soc {
>  		compatible = "simple-bus";
> -		#address-cells = <2>;
> -		#size-cells = <2>;
>  
>  		ranges;
>  		nonposted-mmio;
>  
> +		#address-cells = <2>;
> +		#size-cells = <2>;

[Severity: Low]
Should #address-cells be placed before nonposted-mmio in soc?
dt-check-style --mode=strict sorts standard properties alphabetically by
their #-stripped names (address-cells, nonposted-mmio, size-cells), so
placing #address-cells after nonposted-mmio still triggers a property-order
warning.

Several other within-group alphabetical property-order warnings under
--mode=strict also remain in these files: cpu_e0..cpu_p3 (cpu-release-addr
after enable-method, and cache properties in reverse order),
pinctrl_nub/smc/aop/ap (gpio-controller before #gpio-cells,
interrupt-controller before #interrupt-cells, and power-domains before
gpio-controller), l2_cache_0..1, i2c0..i2c4, fpwm1, serial0, and led-0 in
t8132-j604.dts, t8132-j713.dts, and t8132-j715.dts.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-apple-dts-m4-dt-style-check-v2-0-1e715e80b066@cyberchaos.dev?part=4