* [PATCH v2 1/4] arm64: dts: apple: t8132: Fix indentation-related dt-check-style issues
2026-11-06 16:56 [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Yureka Lilian
@ 2026-11-06 16:56 ` Yureka Lilian
2026-11-06 16:56 ` [PATCH v2 2/4] arm64: dts: apple: t8132: Fix blank-lines-related " Yureka Lilian
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Yureka Lilian @ 2026-11-06 16:56 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel, Yureka Lilian
This fixes `dt-check-style --mode=strict` issues related to
indentation in the t8132 device trees, specifically replacing the use of
8 or more spaces for alignment with n//8 tabs + n%8 spaces.
Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
---
arch/arm64/boot/dts/apple/t8132.dtsi | 64 ++++++++++++++++++------------------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/apple/t8132.dtsi b/arch/arm64/boot/dts/apple/t8132.dtsi
index afec92a06015..58805c6ab002 100644
--- a/arch/arm64/boot/dts/apple/t8132.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132.dtsi
@@ -241,12 +241,12 @@ pinctrl_nub: pinctrl@3881f0000 {
#interrupt-cells = <2>;
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 499 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 500 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 501 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 502 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 503 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 504 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 505 IRQ_TYPE_LEVEL_HIGH>;
+ <AIC_IRQ 500 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 501 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 502 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 503 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 504 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 505 IRQ_TYPE_LEVEL_HIGH>;
};
pmgr_mini: power-management@388280000 {
@@ -278,12 +278,12 @@ pinctrl_smc: pinctrl@38c820000 {
#interrupt-cells = <2>;
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 552 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 553 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 554 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 555 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 556 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 557 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 558 IRQ_TYPE_LEVEL_HIGH>;
+ <AIC_IRQ 553 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 554 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 555 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 556 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 557 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 558 IRQ_TYPE_LEVEL_HIGH>;
};
pinctrl_aop: pinctrl@390824000 {
@@ -299,12 +299,12 @@ pinctrl_aop: pinctrl@390824000 {
#interrupt-cells = <2>;
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 423 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 424 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 425 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 426 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 427 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 428 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 429 IRQ_TYPE_LEVEL_HIGH>;
+ <AIC_IRQ 424 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 425 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 426 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 427 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 428 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 429 IRQ_TYPE_LEVEL_HIGH>;
};
pinctrl_ap: pinctrl@39a000000 {
@@ -321,36 +321,36 @@ pinctrl_ap: pinctrl@39a000000 {
#interrupt-cells = <2>;
interrupt-parent = <&aic>;
interrupts = <AIC_IRQ 303 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 304 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 305 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 306 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 307 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 308 IRQ_TYPE_LEVEL_HIGH>,
- <AIC_IRQ 309 IRQ_TYPE_LEVEL_HIGH>;
+ <AIC_IRQ 304 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 305 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 306 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 307 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 308 IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_IRQ 309 IRQ_TYPE_LEVEL_HIGH>;
i2c0_pins: i2c0-pins {
pinmux = <APPLE_PINMUX(104, 1)>,
- <APPLE_PINMUX(103, 1)>;
+ <APPLE_PINMUX(103, 1)>;
};
i2c1_pins: i2c1-pins {
pinmux = <APPLE_PINMUX(106, 1)>,
- <APPLE_PINMUX(105, 1)>;
+ <APPLE_PINMUX(105, 1)>;
};
i2c2_pins: i2c2-pins {
pinmux = <APPLE_PINMUX(44, 1)>,
- <APPLE_PINMUX(43, 1)>;
+ <APPLE_PINMUX(43, 1)>;
};
i2c3_pins: i2c3-pins {
pinmux = <APPLE_PINMUX(42, 1)>,
- <APPLE_PINMUX(41, 1)>;
+ <APPLE_PINMUX(41, 1)>;
};
i2c4_pins: i2c4-pins {
pinmux = <APPLE_PINMUX(108, 1)>,
- <APPLE_PINMUX(107, 1)>;
+ <APPLE_PINMUX(107, 1)>;
};
};
@@ -458,9 +458,9 @@ timer {
interrupt-parent = <&aic>;
interrupt-names = "phys", "virt", "hyp-phys", "hyp-virt";
interrupts = <AIC_FIQ AIC_TMR_GUEST_PHYS IRQ_TYPE_LEVEL_HIGH>,
- <AIC_FIQ AIC_TMR_GUEST_VIRT IRQ_TYPE_LEVEL_HIGH>,
- <AIC_FIQ AIC_TMR_HV_PHYS IRQ_TYPE_LEVEL_HIGH>,
- <AIC_FIQ AIC_TMR_HV_VIRT IRQ_TYPE_LEVEL_HIGH>;
+ <AIC_FIQ AIC_TMR_GUEST_VIRT IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_FIQ AIC_TMR_HV_PHYS IRQ_TYPE_LEVEL_HIGH>,
+ <AIC_FIQ AIC_TMR_HV_VIRT IRQ_TYPE_LEVEL_HIGH>;
};
};
--
2.56.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/4] arm64: dts: apple: t8132: Fix blank-lines-related dt-check-style issues
2026-11-06 16:56 [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Yureka Lilian
2026-11-06 16:56 ` [PATCH v2 1/4] arm64: dts: apple: t8132: Fix indentation-related dt-check-style issues Yureka Lilian
@ 2026-11-06 16:56 ` Yureka Lilian
2026-11-06 16:56 ` [PATCH v2 3/4] arm64: dts: apple: t8132: Fix line-length-related " Yureka Lilian
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Yureka Lilian @ 2026-11-06 16:56 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel, Yureka Lilian
This fixes `dt-check-style --mode=strict` issues related to blank lines
in the t8132 device tres.
Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
---
arch/arm64/boot/dts/apple/t8132-j604.dts | 1 +
arch/arm64/boot/dts/apple/t8132-j713.dts | 1 +
arch/arm64/boot/dts/apple/t8132-j715.dts | 1 +
arch/arm64/boot/dts/apple/t8132-jxxx.dtsi | 1 +
arch/arm64/boot/dts/apple/t8132.dtsi | 8 ++++++++
5 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t8132-j604.dts b/arch/arm64/boot/dts/apple/t8132-j604.dts
index c4be915cb33a..93076cd923a9 100644
--- a/arch/arm64/boot/dts/apple/t8132-j604.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j604.dts
@@ -19,6 +19,7 @@ / {
led-controller {
compatible = "pwm-leds";
+
led-0 {
pwms = <&fpwm1 0 40000>;
label = "kbd_backlight";
diff --git a/arch/arm64/boot/dts/apple/t8132-j713.dts b/arch/arm64/boot/dts/apple/t8132-j713.dts
index e1fc5d47f487..892a3812bc65 100644
--- a/arch/arm64/boot/dts/apple/t8132-j713.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j713.dts
@@ -19,6 +19,7 @@ / {
led-controller {
compatible = "pwm-leds";
+
led-0 {
pwms = <&fpwm1 0 40000>;
label = "kbd_backlight";
diff --git a/arch/arm64/boot/dts/apple/t8132-j715.dts b/arch/arm64/boot/dts/apple/t8132-j715.dts
index 2672914ea76c..212d194bd1ae 100644
--- a/arch/arm64/boot/dts/apple/t8132-j715.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j715.dts
@@ -19,6 +19,7 @@ / {
led-controller {
compatible = "pwm-leds";
+
led-0 {
pwms = <&fpwm1 0 40000>;
label = "kbd_backlight";
diff --git a/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
index 9882ea3f85e6..b0c5d71943b6 100644
--- a/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
@@ -26,6 +26,7 @@ framebuffer0: framebuffer@0 {
reg = <0 0 0 0>; /* To be filled by loader */
power-domains = <&ps_disp_fe>, <&ps_dptx_phy>;
/* Format properties will be added by loader */
+
status = "disabled";
};
};
diff --git a/arch/arm64/boot/dts/apple/t8132.dtsi b/arch/arm64/boot/dts/apple/t8132.dtsi
index 58805c6ab002..6d070306e29a 100644
--- a/arch/arm64/boot/dts/apple/t8132.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132.dtsi
@@ -24,18 +24,23 @@ cluster0 {
core0 {
cpu = <&cpu_e0>;
};
+
core1 {
cpu = <&cpu_e1>;
};
+
core2 {
cpu = <&cpu_e2>;
};
+
core3 {
cpu = <&cpu_e3>;
};
+
core4 {
cpu = <&cpu_e4>;
};
+
core5 {
cpu = <&cpu_e5>;
};
@@ -45,12 +50,15 @@ cluster1 {
core0 {
cpu = <&cpu_p0>;
};
+
core1 {
cpu = <&cpu_p1>;
};
+
core2 {
cpu = <&cpu_p2>;
};
+
core3 {
cpu = <&cpu_p3>;
};
--
2.56.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 3/4] arm64: dts: apple: t8132: Fix line-length-related dt-check-style issues
2026-11-06 16:56 [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Yureka Lilian
2026-11-06 16:56 ` [PATCH v2 1/4] arm64: dts: apple: t8132: Fix indentation-related dt-check-style issues Yureka Lilian
2026-11-06 16:56 ` [PATCH v2 2/4] arm64: dts: apple: t8132: Fix blank-lines-related " Yureka Lilian
@ 2026-11-06 16:56 ` Yureka Lilian
2026-11-06 16:56 ` [PATCH v2 4/4] arm64: dts: apple: t8132: Fix ordering-related " Yureka Lilian
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Yureka Lilian @ 2026-11-06 16:56 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel, Yureka Lilian
This fixes `dt-check-style --mode=strict` issues related to line
length.
Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
---
arch/arm64/boot/dts/apple/t8132-jxxx.dtsi | 3 ++-
arch/arm64/boot/dts/apple/t8132.dtsi | 24 ++++++++++++++++--------
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
index b0c5d71943b6..9d9aeb4d074e 100644
--- a/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
@@ -22,7 +22,8 @@ chosen {
stdout-path = "serial0";
framebuffer0: framebuffer@0 {
- compatible = "apple,simple-framebuffer", "simple-framebuffer";
+ compatible = "apple,simple-framebuffer",
+ "simple-framebuffer";
reg = <0 0 0 0>; /* To be filled by loader */
power-domains = <&ps_disp_fe>, <&ps_dptx_phy>;
/* Format properties will be added by loader */
diff --git a/arch/arm64/boot/dts/apple/t8132.dtsi b/arch/arm64/boot/dts/apple/t8132.dtsi
index 6d070306e29a..b1e77a8ae406 100644
--- a/arch/arm64/boot/dts/apple/t8132.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132.dtsi
@@ -206,7 +206,8 @@ soc: soc {
nonposted-mmio;
pmgr: power-management@380700000 {
- compatible = "apple,t8132-pmgr", "apple,t8103-pmgr", "syscon", "simple-mfd";
+ compatible = "apple,t8132-pmgr", "apple,t8103-pmgr",
+ "syscon", "simple-mfd";
#address-cells = <1>;
#size-cells = <1>;
reg = <0x3 0x80700000 0 0x14000>;
@@ -225,18 +226,21 @@ aic: interrupt-controller@381000000 {
affinities {
e-core-pmu-affinity {
apple,fiq-index = <AIC_CPU_PMU_E>;
- cpus = <&cpu_e0 &cpu_e1 &cpu_e2 &cpu_e3 &cpu_e4 &cpu_e5>;
+ cpus = <&cpu_e0 &cpu_e1 &cpu_e2
+ &cpu_e3 &cpu_e4 &cpu_e5>;
};
p-core-pmu-affinity {
apple,fiq-index = <AIC_CPU_PMU_P>;
- cpus = <&cpu_p0 &cpu_p1 &cpu_p2 &cpu_p3>;
+ cpus = <&cpu_p0 &cpu_p1
+ &cpu_p2 &cpu_p3>;
};
};
};
pinctrl_nub: pinctrl@3881f0000 {
- compatible = "apple,t8132-pinctrl", "apple,t8103-pinctrl";
+ compatible = "apple,t8132-pinctrl",
+ "apple,t8103-pinctrl";
reg = <0x3 0x881f0000 0x0 0x4000>;
power-domains = <&ps_nub_gpio>;
@@ -258,7 +262,8 @@ pinctrl_nub: pinctrl@3881f0000 {
};
pmgr_mini: power-management@388280000 {
- compatible = "apple,t8132-pmgr", "apple,t8103-pmgr", "syscon", "simple-mfd";
+ compatible = "apple,t8132-pmgr", "apple,t8103-pmgr",
+ "syscon", "simple-mfd";
#address-cells = <1>;
#size-cells = <1>;
reg = <0x3 0x88280000 0 0x4000>;
@@ -274,7 +279,8 @@ wdt: watchdog@3882b0000 {
};
pinctrl_smc: pinctrl@38c820000 {
- compatible = "apple,t8132-pinctrl", "apple,t8103-pinctrl";
+ compatible = "apple,t8132-pinctrl",
+ "apple,t8103-pinctrl";
reg = <0x3 0x8c820000 0x0 0x4000>;
gpio-controller;
@@ -295,7 +301,8 @@ pinctrl_smc: pinctrl@38c820000 {
};
pinctrl_aop: pinctrl@390824000 {
- compatible = "apple,t8132-pinctrl", "apple,t8103-pinctrl";
+ compatible = "apple,t8132-pinctrl",
+ "apple,t8103-pinctrl";
reg = <0x3 0x90824000 0x0 0x4000>;
gpio-controller;
@@ -316,7 +323,8 @@ pinctrl_aop: pinctrl@390824000 {
};
pinctrl_ap: pinctrl@39a000000 {
- compatible = "apple,t8132-pinctrl", "apple,t8103-pinctrl";
+ compatible = "apple,t8132-pinctrl",
+ "apple,t8103-pinctrl";
reg = <0x3 0x9a000000 0x0 0x100000>;
power-domains = <&ps_gpio>;
--
2.56.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 4/4] arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues
2026-11-06 16:56 [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Yureka Lilian
` (2 preceding siblings ...)
2026-11-06 16:56 ` [PATCH v2 3/4] arm64: dts: apple: t8132: Fix line-length-related " Yureka Lilian
@ 2026-11-06 16:56 ` Yureka Lilian
2026-11-06 17:08 ` sashiko-bot
2026-11-06 17:48 ` [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Neal Gompa
2026-11-06 19:51 ` Sven Peter
5 siblings, 1 reply; 8+ messages in thread
From: Yureka Lilian @ 2026-11-06 16:56 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel, Yureka Lilian
This fixes `dt-check-style --mode=strict` issues related to node and
property ordering in the t8132 device tres.
Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
---
arch/arm64/boot/dts/apple/t8132-j604.dts | 2 +-
arch/arm64/boot/dts/apple/t8132-j623.dts | 2 +-
arch/arm64/boot/dts/apple/t8132-j624.dts | 2 +-
arch/arm64/boot/dts/apple/t8132-j713.dts | 2 +-
arch/arm64/boot/dts/apple/t8132-j715.dts | 2 +-
arch/arm64/boot/dts/apple/t8132-j773g.dts | 2 +-
arch/arm64/boot/dts/apple/t8132-jxxx.dtsi | 15 +++----
arch/arm64/boot/dts/apple/t8132.dtsi | 65 +++++++++++++++++--------------
8 files changed, 49 insertions(+), 43 deletions(-)
diff --git a/arch/arm64/boot/dts/apple/t8132-j604.dts b/arch/arm64/boot/dts/apple/t8132-j604.dts
index 93076cd923a9..ebf25fb1bd3c 100644
--- a/arch/arm64/boot/dts/apple/t8132-j604.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j604.dts
@@ -14,8 +14,8 @@
#include <dt-bindings/leds/common.h>
/ {
- compatible = "apple,j604", "apple,t8132", "apple,arm-platform";
model = "Apple MacBook Pro (14-inch, M4, 2024)";
+ compatible = "apple,j604", "apple,t8132", "apple,arm-platform";
led-controller {
compatible = "pwm-leds";
diff --git a/arch/arm64/boot/dts/apple/t8132-j623.dts b/arch/arm64/boot/dts/apple/t8132-j623.dts
index 508e26056022..9b5f6d484c8e 100644
--- a/arch/arm64/boot/dts/apple/t8132-j623.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j623.dts
@@ -13,6 +13,6 @@
#include "t8132-jxxx.dtsi"
/ {
- compatible = "apple,j623", "apple,t8132", "apple,arm-platform";
model = "Apple iMac (24-inch, 2x USB-C, M4, 2024)";
+ compatible = "apple,j623", "apple,t8132", "apple,arm-platform";
};
diff --git a/arch/arm64/boot/dts/apple/t8132-j624.dts b/arch/arm64/boot/dts/apple/t8132-j624.dts
index 84bdd8e343eb..b1d4fa1b6208 100644
--- a/arch/arm64/boot/dts/apple/t8132-j624.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j624.dts
@@ -13,6 +13,6 @@
#include "t8132-jxxx.dtsi"
/ {
- compatible = "apple,j624", "apple,t8132", "apple,arm-platform";
model = "Apple iMac (24-inch, 4x USB-C, M4, 2024)";
+ compatible = "apple,j624", "apple,t8132", "apple,arm-platform";
};
diff --git a/arch/arm64/boot/dts/apple/t8132-j713.dts b/arch/arm64/boot/dts/apple/t8132-j713.dts
index 892a3812bc65..6ffef1f1d242 100644
--- a/arch/arm64/boot/dts/apple/t8132-j713.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j713.dts
@@ -14,8 +14,8 @@
#include <dt-bindings/leds/common.h>
/ {
- compatible = "apple,j713", "apple,t8132", "apple,arm-platform";
model = "Apple MacBook Air (13-inch, M4, 2025)";
+ compatible = "apple,j713", "apple,t8132", "apple,arm-platform";
led-controller {
compatible = "pwm-leds";
diff --git a/arch/arm64/boot/dts/apple/t8132-j715.dts b/arch/arm64/boot/dts/apple/t8132-j715.dts
index 212d194bd1ae..391cb9f6f5dc 100644
--- a/arch/arm64/boot/dts/apple/t8132-j715.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j715.dts
@@ -14,8 +14,8 @@
#include <dt-bindings/leds/common.h>
/ {
- compatible = "apple,j715", "apple,t8132", "apple,arm-platform";
model = "Apple MacBook Air (15-inch, M4, 2025)";
+ compatible = "apple,j715", "apple,t8132", "apple,arm-platform";
led-controller {
compatible = "pwm-leds";
diff --git a/arch/arm64/boot/dts/apple/t8132-j773g.dts b/arch/arm64/boot/dts/apple/t8132-j773g.dts
index 0583cb9d19f6..b76ea6ffa1fd 100644
--- a/arch/arm64/boot/dts/apple/t8132-j773g.dts
+++ b/arch/arm64/boot/dts/apple/t8132-j773g.dts
@@ -13,8 +13,8 @@
#include "t8132-jxxx.dtsi"
/ {
- compatible = "apple,j773g", "apple,t8132", "apple,arm-platform";
model = "Apple Mac mini (M4, 2024)";
+ compatible = "apple,j773g", "apple,t8132", "apple,arm-platform";
};
/*
diff --git a/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
index 9d9aeb4d074e..bfe6701f35d6 100644
--- a/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132-jxxx.dtsi
@@ -15,9 +15,10 @@ aliases {
};
chosen {
+ ranges;
+
#address-cells = <2>;
#size-cells = <2>;
- ranges;
stdout-path = "serial0";
@@ -32,17 +33,17 @@ framebuffer0: framebuffer@0 {
};
};
+ memory@800000000 {
+ device_type = "memory";
+ reg = <0x8 0 0x2 0>; /* To be filled by loader */
+ };
+
reserved-memory {
+ ranges;
#address-cells = <2>;
#size-cells = <2>;
- ranges;
/* To be filled by loader */
};
-
- memory@800000000 {
- device_type = "memory";
- reg = <0x8 0 0x2 0>; /* To be filled by loader */
- };
};
&serial0 {
diff --git a/arch/arm64/boot/dts/apple/t8132.dtsi b/arch/arm64/boot/dts/apple/t8132.dtsi
index b1e77a8ae406..e2e79c7e7fd0 100644
--- a/arch/arm64/boot/dts/apple/t8132.dtsi
+++ b/arch/arm64/boot/dts/apple/t8132.dtsi
@@ -15,6 +15,13 @@ / {
#address-cells = <2>;
#size-cells = <2>;
+ clkref: clock-ref {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <24000000>;
+ clock-output-names = "clkref";
+ };
+
cpus {
#address-cells = <2>;
#size-cells = <0>;
@@ -66,8 +73,8 @@ core3 {
};
cpu_e0: cpu@0 {
- compatible = "apple,donan-e";
device_type = "cpu";
+ compatible = "apple,donan-e";
reg = <0x0 0x0>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -77,8 +84,8 @@ cpu_e0: cpu@0 {
};
cpu_e1: cpu@1 {
- compatible = "apple,donan-e";
device_type = "cpu";
+ compatible = "apple,donan-e";
reg = <0x0 0x1>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -88,8 +95,8 @@ cpu_e1: cpu@1 {
};
cpu_e2: cpu@2 {
- compatible = "apple,donan-e";
device_type = "cpu";
+ compatible = "apple,donan-e";
reg = <0x0 0x2>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -99,8 +106,8 @@ cpu_e2: cpu@2 {
};
cpu_e3: cpu@3 {
- compatible = "apple,donan-e";
device_type = "cpu";
+ compatible = "apple,donan-e";
reg = <0x0 0x3>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -110,8 +117,8 @@ cpu_e3: cpu@3 {
};
cpu_e4: cpu@4 {
- compatible = "apple,donan-e";
device_type = "cpu";
+ compatible = "apple,donan-e";
reg = <0x0 0x4>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -121,8 +128,8 @@ cpu_e4: cpu@4 {
};
cpu_e5: cpu@5 {
- compatible = "apple,donan-e";
device_type = "cpu";
+ compatible = "apple,donan-e";
reg = <0x0 0x5>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -132,8 +139,8 @@ cpu_e5: cpu@5 {
};
cpu_p0: cpu@10100 {
- compatible = "apple,donan-p";
device_type = "cpu";
+ compatible = "apple,donan-p";
reg = <0x0 0x10100>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -143,8 +150,8 @@ cpu_p0: cpu@10100 {
};
cpu_p1: cpu@10101 {
- compatible = "apple,donan-p";
device_type = "cpu";
+ compatible = "apple,donan-p";
reg = <0x0 0x10101>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -154,8 +161,8 @@ cpu_p1: cpu@10101 {
};
cpu_p2: cpu@10102 {
- compatible = "apple,donan-p";
device_type = "cpu";
+ compatible = "apple,donan-p";
reg = <0x0 0x10102>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -165,8 +172,8 @@ cpu_p2: cpu@10102 {
};
cpu_p3: cpu@10103 {
- compatible = "apple,donan-p";
device_type = "cpu";
+ compatible = "apple,donan-p";
reg = <0x0 0x10103>;
enable-method = "spin-table";
cpu-release-addr = <0 0>;
@@ -190,50 +197,44 @@ l2_cache_1: l2-cache-1 {
};
};
- clkref: clock-ref {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <24000000>;
- clock-output-names = "clkref";
- };
-
soc: soc {
compatible = "simple-bus";
- #address-cells = <2>;
- #size-cells = <2>;
ranges;
nonposted-mmio;
+ #address-cells = <2>;
+ #size-cells = <2>;
+
pmgr: power-management@380700000 {
compatible = "apple,t8132-pmgr", "apple,t8103-pmgr",
"syscon", "simple-mfd";
+ reg = <0x3 0x80700000 0 0x14000>;
#address-cells = <1>;
#size-cells = <1>;
- reg = <0x3 0x80700000 0 0x14000>;
/* child nodes are added in t8132-pmgr.dtsi */
};
aic: interrupt-controller@381000000 {
compatible = "apple,t8132-aic3", "apple,t8122-aic3";
- #interrupt-cells = <3>;
- interrupt-controller;
reg = <0x3 0x81000000 0x0 0x1cc000>,
<0x3 0x81040000 0x0 0x4000>;
reg-names = "core", "event";
+ #interrupt-cells = <3>;
+ interrupt-controller;
power-domains = <&ps_aic>;
affinities {
e-core-pmu-affinity {
- apple,fiq-index = <AIC_CPU_PMU_E>;
cpus = <&cpu_e0 &cpu_e1 &cpu_e2
&cpu_e3 &cpu_e4 &cpu_e5>;
+ apple,fiq-index = <AIC_CPU_PMU_E>;
};
p-core-pmu-affinity {
- apple,fiq-index = <AIC_CPU_PMU_P>;
cpus = <&cpu_p0 &cpu_p1
&cpu_p2 &cpu_p3>;
+ apple,fiq-index = <AIC_CPU_PMU_P>;
};
};
};
@@ -247,7 +248,6 @@ pinctrl_nub: pinctrl@3881f0000 {
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&pinctrl_nub 0 0 32>;
- apple,npins = <32>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -259,14 +259,16 @@ pinctrl_nub: pinctrl@3881f0000 {
<AIC_IRQ 503 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 504 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 505 IRQ_TYPE_LEVEL_HIGH>;
+
+ apple,npins = <32>;
};
pmgr_mini: power-management@388280000 {
compatible = "apple,t8132-pmgr", "apple,t8103-pmgr",
"syscon", "simple-mfd";
+ reg = <0x3 0x88280000 0 0x4000>;
#address-cells = <1>;
#size-cells = <1>;
- reg = <0x3 0x88280000 0 0x4000>;
/* child nodes are added in t8132-pmgr.dtsi */
};
@@ -286,7 +288,6 @@ pinctrl_smc: pinctrl@38c820000 {
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&pinctrl_smc 0 0 18>;
- apple,npins = <18>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -298,6 +299,8 @@ pinctrl_smc: pinctrl@38c820000 {
<AIC_IRQ 556 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 557 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 558 IRQ_TYPE_LEVEL_HIGH>;
+
+ apple,npins = <18>;
};
pinctrl_aop: pinctrl@390824000 {
@@ -308,7 +311,6 @@ pinctrl_aop: pinctrl@390824000 {
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&pinctrl_aop 0 0 57>;
- apple,npins = <57>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -320,6 +322,8 @@ pinctrl_aop: pinctrl@390824000 {
<AIC_IRQ 427 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 428 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 429 IRQ_TYPE_LEVEL_HIGH>;
+
+ apple,npins = <57>;
};
pinctrl_ap: pinctrl@39a000000 {
@@ -331,7 +335,6 @@ pinctrl_ap: pinctrl@39a000000 {
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&pinctrl_ap 0 0 224>;
- apple,npins = <224>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -344,6 +347,8 @@ pinctrl_ap: pinctrl@39a000000 {
<AIC_IRQ 308 IRQ_TYPE_LEVEL_HIGH>,
<AIC_IRQ 309 IRQ_TYPE_LEVEL_HIGH>;
+ apple,npins = <224>;
+
i2c0_pins: i2c0-pins {
pinmux = <APPLE_PINMUX(104, 1)>,
<APPLE_PINMUX(103, 1)>;
@@ -472,11 +477,11 @@ serial0: serial@3ad200000 {
timer {
compatible = "arm,armv8-timer";
interrupt-parent = <&aic>;
- interrupt-names = "phys", "virt", "hyp-phys", "hyp-virt";
interrupts = <AIC_FIQ AIC_TMR_GUEST_PHYS IRQ_TYPE_LEVEL_HIGH>,
<AIC_FIQ AIC_TMR_GUEST_VIRT IRQ_TYPE_LEVEL_HIGH>,
<AIC_FIQ AIC_TMR_HV_PHYS IRQ_TYPE_LEVEL_HIGH>,
<AIC_FIQ AIC_TMR_HV_VIRT IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "phys", "virt", "hyp-phys", "hyp-virt";
};
};
--
2.56.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues
2026-11-06 16:56 ` [PATCH v2 4/4] arm64: dts: apple: t8132: Fix ordering-related " Yureka Lilian
@ 2026-11-06 17:08 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-11-06 17:08 UTC (permalink / raw)
To: Yureka Lilian; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: apple: t8132: root model placed before compatible
breaks strict style
- [Low] arm64: dts: apple: t8132: #address-cells after nonposted-mmio
and unsorted props
--
commit 85a1def59cfd948af8883a7bded0a54104bc0b30
Author: Yureka Lilian <yureka@cyberchaos.dev>
arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues
This commit reorders nodes and properties in the Apple t8132 device trees to
address strict dt-check-style warnings.
> diff --git a/arch/arm64/boot/dts/apple/t8132-j604.dts b/arch/arm64/boot/dts/apple/t8132-j604.dts
> index 93076cd923a93..ebf25fb1bd3cd 100644
> --- a/arch/arm64/boot/dts/apple/t8132-j604.dts
> +++ b/arch/arm64/boot/dts/apple/t8132-j604.dts
> @@ -14,8 +14,8 @@
> #include <dt-bindings/leds/common.h>
>
> / {
> - compatible = "apple,j604", "apple,t8132", "apple,arm-platform";
> model = "Apple MacBook Pro (14-inch, M4, 2024)";
> + compatible = "apple,j604", "apple,t8132", "apple,arm-platform";
>
> led-controller {
> compatible = "pwm-leds";
[Severity: Low]
Does placing model before compatible in the root node introduce a
dt-check-style --mode=strict regression here and in t8132-j623.dts,
t8132-j624.dts, t8132-j713.dts, t8132-j715.dts, and t8132-j773g.dts?
Per Documentation/devicetree/bindings/dts-coding-style.rst and
scripts/dtc/dt-check-style, compatible belongs to the first canonical group
whereas model is a general property, so swapping them triggers a new
property-order warning that compatible should sort before model.
[ ... ]
> diff --git a/arch/arm64/boot/dts/apple/t8132.dtsi b/arch/arm64/boot/dts/apple/t8132.dtsi
> index b1e77a8ae4066..e2e79c7e7fd07 100644
> --- a/arch/arm64/boot/dts/apple/t8132.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8132.dtsi
[ ... ]
> @@ -190,50 +197,44 @@ l2_cache_1: l2-cache-1 {
> };
> };
>
> - clkref: clock-ref {
> - compatible = "fixed-clock";
> - #clock-cells = <0>;
> - clock-frequency = <24000000>;
> - clock-output-names = "clkref";
> - };
> -
> soc: soc {
> compatible = "simple-bus";
> - #address-cells = <2>;
> - #size-cells = <2>;
>
> ranges;
> nonposted-mmio;
>
> + #address-cells = <2>;
> + #size-cells = <2>;
[Severity: Low]
Should #address-cells be placed before nonposted-mmio in soc?
dt-check-style --mode=strict sorts standard properties alphabetically by
their #-stripped names (address-cells, nonposted-mmio, size-cells), so
placing #address-cells after nonposted-mmio still triggers a property-order
warning.
Several other within-group alphabetical property-order warnings under
--mode=strict also remain in these files: cpu_e0..cpu_p3 (cpu-release-addr
after enable-method, and cache properties in reverse order),
pinctrl_nub/smc/aop/ap (gpio-controller before #gpio-cells,
interrupt-controller before #interrupt-cells, and power-domains before
gpio-controller), l2_cache_0..1, i2c0..i2c4, fpwm1, serial0, and led-0 in
t8132-j604.dts, t8132-j713.dts, and t8132-j715.dts.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-apple-dts-m4-dt-style-check-v2-0-1e715e80b066@cyberchaos.dev?part=4
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4
2026-11-06 16:56 [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Yureka Lilian
` (3 preceding siblings ...)
2026-11-06 16:56 ` [PATCH v2 4/4] arm64: dts: apple: t8132: Fix ordering-related " Yureka Lilian
@ 2026-11-06 17:48 ` Neal Gompa
2026-11-06 19:51 ` Sven Peter
5 siblings, 0 replies; 8+ messages in thread
From: Neal Gompa @ 2026-11-06 17:48 UTC (permalink / raw)
To: Yureka Lilian
Cc: Sven Peter, Janne Grunau, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, asahi, linux-arm-kernel, devicetree, linux-kernel
On Fri, Nov 6, 2026 at 11:56 AM Yureka Lilian <yureka@cyberchaos.dev> wrote:
>
> Hi,
>
> mirroring recent changes to the M3 and M3 Pro/Max/Ultra device trees,
> this makes the M4 device trees broadly compliant with
> `dt-check-style --mode=strict`, leaving the same exceptions:
>
> - the property-order and line-length issues in the generated pmgr nodes
> are left as-is
>
> I checked carefully that the modifications do not cause any functional
> change in the compiled DTs.
>
> Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
> ---
> Changes in v2:
> - Also fix indentation related dt-check-style issues (mixed-indent-chars)
> - Change the ordering only where the issue is still present against
> current linux-next dt-check-style.
> - Also fix any remaining line length issues in the t8132 dts except t8132-pmgr.dtsi.
> - Link to v1: https://patch.msgid.link/20260924-apple-dts-m4-dt-style-check-v1-0-3ec651d75baf@cyberchaos.dev
>
> ---
> Yureka Lilian (4):
> arm64: dts: apple: t8132: Fix indentation-related dt-check-style issues
> arm64: dts: apple: t8132: Fix blank-lines-related dt-check-style issues
> arm64: dts: apple: t8132: Fix line-length-related dt-check-style issues
> arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues
>
> arch/arm64/boot/dts/apple/t8132-j604.dts | 3 +-
> arch/arm64/boot/dts/apple/t8132-j623.dts | 2 +-
> arch/arm64/boot/dts/apple/t8132-j624.dts | 2 +-
> arch/arm64/boot/dts/apple/t8132-j713.dts | 3 +-
> arch/arm64/boot/dts/apple/t8132-j715.dts | 3 +-
> arch/arm64/boot/dts/apple/t8132-j773g.dts | 2 +-
> arch/arm64/boot/dts/apple/t8132-jxxx.dtsi | 19 ++--
> arch/arm64/boot/dts/apple/t8132.dtsi | 157 +++++++++++++++++-------------
> 8 files changed, 109 insertions(+), 82 deletions(-)
> ---
> base-commit: eea4f3b5e9e19389af3b99af64cdf7352b67c298
> change-id: 20260924-apple-dts-m4-dt-style-check-6e1f9dc92807
>
LGTM.
Reviewed-by: Neal Gompa <neal@gompa.dev>
--
真実はいつも一つ！/ Always, there's only one truth!
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4
2026-11-06 16:56 [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Yureka Lilian
` (4 preceding siblings ...)
2026-11-06 17:48 ` [PATCH v2 0/4] arm64: dts: apple: dt-check-style strict fixes for Apple M4 Neal Gompa
@ 2026-11-06 19:51 ` Sven Peter
5 siblings, 0 replies; 8+ messages in thread
From: Sven Peter @ 2026-11-06 19:51 UTC (permalink / raw)
To: Janne Grunau, Neal Gompa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Yureka Lilian
Cc: Sven Peter, asahi, linux-arm-kernel, devicetree, linux-kernel
On Fri, 06 Nov 2026 17:56:12 +0100, Yureka Lilian wrote:
> mirroring recent changes to the M3 and M3 Pro/Max/Ultra device trees,
> this makes the M4 device trees broadly compliant with
> `dt-check-style --mode=strict`, leaving the same exceptions:
>
> - the property-order and line-length issues in the generated pmgr nodes
> are left as-is
>
> [...]
Applied to git@github.com:AsahiLinux/linux.git (apple-soc/dt-7.5), thanks!
[1/4] arm64: dts: apple: t8132: Fix indentation-related dt-check-style issues
https://github.com/AsahiLinux/linux/commit/c1d0c2e46812
[2/4] arm64: dts: apple: t8132: Fix blank-lines-related dt-check-style issues
https://github.com/AsahiLinux/linux/commit/e63df4a6b4af
[3/4] arm64: dts: apple: t8132: Fix line-length-related dt-check-style issues
https://github.com/AsahiLinux/linux/commit/0199d5131009
[4/4] arm64: dts: apple: t8132: Fix ordering-related dt-check-style issues
https://github.com/AsahiLinux/linux/commit/84a1163b0a3e
Best regards,
--
Sven Peter <sven@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread