From: sashiko-bot@kernel.org
To: "Sasha Finkelstein" <k@chaosmail.tech>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v11 5/6] spmi: apple: lock around FIFOs
Date: Sun, 08 Nov 2026 04:59:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-203569@kernel.org> (raw)
In-Reply-To: <20261107-t603x-spmi-v11-5-322490215f58@chaosmail.tech>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] spmi: apple: missing Fixes trailer for FIFO locking in
spmi_raw_cmd()
--
commit d27b65725fd5286319f9551943331b7836effecd
Author: Alba Mendez <me@alba.sh>
> spmi: apple: lock around FIFOs
>
> The driver was missing locking around register interactions.
>
> Signed-off-by: Alba Mendez <me@alba.sh>
> Reviewed-by: Janne Grunau <j@jannau.net>
> Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
[Severity: Low]
The SPMI core invokes controller callbacks without controller-wide
serialization, so concurrent register accesses have been unserialized
since the driver was introduced. Should this include:
Fixes: 77ca75e80c71 ("spmi: add a spmi driver for Apple SoC")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-t603x-spmi-v11-0-322490215f58@chaosmail.tech?part=5
next prev parent reply other threads:[~2026-11-08 4:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 20:36 [PATCH v11 0/6] spmi: apple: Additional commands and interrupt support Sasha Finkelstein
2026-11-07 20:36 ` [PATCH v11 1/6] dt-bindings: spmi: apple,spmi: Add t603x and t8122 Sasha Finkelstein
2026-11-07 20:36 ` [PATCH v11 2/6] spmi: apple: Validate FIFO state Sasha Finkelstein
2026-11-07 20:36 ` [PATCH v11 3/6] spmi: apple: check transaction status Sasha Finkelstein
2026-11-07 20:36 ` [PATCH v11 4/6] spmi: apple: Implement remaining commands Sasha Finkelstein
2026-11-07 20:36 ` [PATCH v11 5/6] spmi: apple: lock around FIFOs Sasha Finkelstein
2026-11-08 4:59 ` sashiko-bot [this message]
2026-11-07 20:36 ` [PATCH v11 6/6] spmi: apple: Add interrupt functionality Sasha Finkelstein
2026-11-08 5:18 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203569@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k@chaosmail.tech \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox