From: sashiko-bot@kernel.org
To: "Richard Acayan" <mailingradian@gmail.com>, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 7/9] arm64: dts: qcom: pm660l: add analog audio codec
Date: Mon, 09 Nov 2026 20:34:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-205586@kernel.org> (raw)
In-Reply-To: <20261107022453.159341-8-mailingradian@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: pm660l: sound-name-prefix violates analog
codec DT schema
--
commit 2cdb7e07dbee3037de67d0c38e09df937ce70258
Author: Richard Acayan <mailingradian@gmail.com>
arm64: dts: qcom: pm660l: add analog audio codec
This commit adds the analog audio codec node to the PM660L PMIC device tree.
> diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> index 3f8b9eafe1641..608c1c2120c96 100644
> --- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> @@ -87,6 +87,43 @@ pm660l_wled: leds@d800 {
> status = "disabled";
> };
>
> + pm660l_codec: audio-codec@f000 {
> + compatible = "qcom,pm660l-wcd-analog-codec",
> + "qcom,pm8953-wcd-analog-codec";
> + reg = <0xf000>;
> + interrupts = <0x3 0xf0 0x0 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x1 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x2 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x3 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x4 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x5 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x6 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf0 0x7 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf1 0x0 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf1 0x1 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf1 0x2 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf1 0x3 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf1 0x4 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xf1 0x5 IRQ_TYPE_EDGE_BOTH>;
> + interrupt-names = "cdc_spk_cnp_int",
> + "cdc_spk_clip_int",
> + "cdc_spk_ocp_int",
> + "mbhc_ins_rem_det1",
> + "mbhc_but_rel_det",
> + "mbhc_but_press_det",
> + "mbhc_ins_rem_det",
> + "mbhc_switch_int",
> + "cdc_ear_ocp_int",
> + "cdc_hphr_ocp_int",
> + "cdc_hphl_ocp_det",
> + "cdc_ear_cnp_int",
> + "cdc_hphr_cnp_int",
> + "cdc_hphl_cnp_int";
> + sound-name-prefix = "Analog";
[Severity: Low]
Does sound-name-prefix here cause a make dtbs_check failure for boards
including pm660l.dtsi?
Documentation/devicetree/bindings/sound/qcom,pm8916-wcd-analog-codec.yaml
sets additionalProperties: false without listing sound-name-prefix or
referencing dai-common.yaml#.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107022453.159341-1-mailingradian@gmail.com?part=7
next prev parent reply other threads:[~2026-11-09 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 2:24 [PATCH v3 0/9] ADSP for SDM670 and sound on Google Pixel 3a Richard Acayan
2026-11-07 2:24 ` [PATCH v3 1/9] dt-bindings: soc: qcom,smp2p: add sleepstate support Richard Acayan
2026-11-07 2:24 ` [PATCH v3 2/9] dt-bindings: soc: qcom: aoss: Add compatible for SDM670 Richard Acayan
2026-11-07 2:24 ` [PATCH v3 3/9] dt-bindings: remoteproc: qcom: adsp: Add SDM670 ADSP compatible Richard Acayan
2026-11-09 20:04 ` sashiko-bot
2026-11-07 2:24 ` [PATCH v3 4/9] remoteproc: qcom: pas: Add SDM670 ADSP support Richard Acayan
2026-11-07 2:24 ` [PATCH v3 5/9] arm64: dts: qcom: sdm670: add adsp Richard Acayan
2026-11-09 20:22 ` sashiko-bot
2026-11-07 2:24 ` [PATCH v3 6/9] arm64: dts: qcom: sdm670-google: enable adsp Richard Acayan
2026-11-07 2:24 ` [PATCH v3 7/9] arm64: dts: qcom: pm660l: add analog audio codec Richard Acayan
2026-11-09 13:25 ` Konrad Dybcio
2026-11-09 20:34 ` sashiko-bot [this message]
2026-11-07 2:24 ` [PATCH v3 8/9] arm64: dts: qcom: sdm670: add digital " Richard Acayan
2026-11-09 20:55 ` sashiko-bot
2026-11-07 2:24 ` [PATCH v3 9/9] arm64: dts: qcom: sdm670-google: add sound card Richard Acayan
2026-11-08 20:08 ` (subset) [PATCH v3 0/9] ADSP for SDM670 and sound on Google Pixel 3a Bjorn Andersson
2026-11-09 13:23 ` Konrad Dybcio
2026-11-11 2:18 ` Richard Acayan
2026-11-10 4:34 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205586@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox