Re: [PATCH 3/6] arm64: dts: qcom: pmi632: Add LCDB regulator node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: pmi632: undocumented regulator@ec00 breaks
  dtbs_check
--

commit 59a61b0cda3ab4cae16c1eae412c4c0a133346c4
Author: Val Packett <val@packett.cool>

arm64: dts: qcom: pmi632: Add LCDB regulator node

This commit adds the pmi632_lcdb LCD bias regulator node and its ldo and
ncp child nodes to pmi632.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/pmi632.dtsi b/arch/arm64/boot/dts/qcom/pmi632.dtsi
> index b0ed35094a98d..ab850050eb22a 100644
> --- a/arch/arm64/boot/dts/qcom/pmi632.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi632.dtsi
> @@ -204,5 +204,19 @@ pmi632_vib: vibrator@5700 {
>  			reg = <0x5700>;
>  			status = "disabled";
>  		};
> +
> +		pmi632_lcdb: regulator@ec00 {
> +			compatible = "qcom,pmi632-lcdb", "qcom,pm8150l-lcdb";
> +			reg = <0xec00>;
> +			interrupts = <0x3 0xec 0x1 IRQ_TYPE_EDGE_RISING>;
> +
> +			status = "disabled";
> +
> +			pmi632_lcdb_ldo: ldo {
> +			};
> +
> +			pmi632_lcdb_ncp: ncp {
> +			};
> +		};
>  	};
>  };

[Severity: Medium]
Are the Devicetree binding schema and driver for qcom,pmi632-lcdb and
qcom,pm8150l-lcdb missing from the tree?

Neither compatible string is documented under
Documentation/devicetree/bindings/ or matched by an in-tree regulator
driver, and Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml has
additionalProperties: false without a pattern permitting regulator@[0-9a-f]+
child nodes.  Adding regulator@ec00 causes dtbs_check schema validation
failures on every board DTB that includes pmi632.dtsi, and boards enabling
pmi632_lcdb will fail to resolve the pmi632_lcdb_ldo and pmi632_lcdb_ncp
supplies at runtime.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109221453.658316-1-val@packett.cool?part=3