* Re: [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
2026-11-07 3:26 [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain Qianhui Xu
@ 2026-11-07 3:33 ` sashiko-bot
2026-11-09 14:16 ` Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-11-07 3:33 UTC (permalink / raw)
To: Qianhui Xu; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: sm8750: missing Fixes trailer for commit
be9d54c35312
--
commit 3e2d2cedc67ebfc939a205a1181e0f73888ada0d
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
>
> On SM8750 the ADSP fastrpc instance used by the sensor core (and by the
> other non-secure ADSP users) is the one the firmware exposes as
> non-secure; the CDSP fastrpc node already carries
> "qcom,non-secure-domain", the ADSP one does not. With the fastrpc driver
> keying the secure/non-secure split off that property, the ADSP only
> instantiates /dev/fastrpc-adsp-secure and userspace never gets
> /dev/fastrpc-adsp, so libssc/hexagonrpcd cannot attach to the sensor PD
> (qrtr service 400) and iio-sensor-proxy reports no sensors at all.
>
> Observed on the Lenovo Legion Tab Y700 Gen4 (TB322FC), which is SM8750
> based: without this property /dev/fastrpc-adsp never appears and
> iio-sensor-proxy exposes neither accelerometer, ambient light nor
> proximity; with it, qrtr shows the "Snapdragon Sensor Core service"
> (id 400) and all three sensor types report as available. The change is
> one property on one node, matching what the CDSP node already does.
>
> Tested with `make CHECK_DTBS=y qcom/sm8750-mtp.dtb` (no new warnings; the
> single avoid_unnecessary_addr_size warning on dsi@ae96000 is present
> before and after).
>
> *** AI-assistance disclosure ***
> This patch and its commit message were prepared with the help of an LLM
> coding assistant. The author reviewed the change line by line, ran the
> checks quoted above on his own hardware and takes full responsibility
> for the content.
>
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
[Severity: Low]
Since this fixes the ADSP fastrpc node added in be9d54c35312 ("arm64: dts:
qcom: sm8750: add ADSP fastrpc-compute-cb nodes"), should this include:
Fixes: be9d54c35312 ("arm64: dts: qcom: sm8750: add ADSP fastrpc-compute-cb nodes")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107032646.32363-1-xiaqinghuan@mail.ustc.edu.cn?part=1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
2026-11-07 3:26 [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain Qianhui Xu
2026-11-07 3:33 ` sashiko-bot
@ 2026-11-09 14:16 ` Konrad Dybcio
2026-11-10 2:31 ` [PATCH v2] " Qianhui Xu
2026-11-11 3:57 ` [PATCH v3] " Qianhui Xu
3 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-11-09 14:16 UTC (permalink / raw)
To: Qianhui Xu, andersson, konradybcio, Ekansh Gupta,
Dmitry Baryshkov, Srinivas Kandagatla
Cc: robh, krzk+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel
On 11/7/26 4:26 AM, Qianhui Xu wrote:
> On SM8750 the ADSP fastrpc instance used by the sensor core (and by the
> other non-secure ADSP users) is the one the firmware exposes as
> non-secure; the CDSP fastrpc node already carries
> "qcom,non-secure-domain", the ADSP one does not. With the fastrpc driver
> keying the secure/non-secure split off that property, the ADSP only
> instantiates /dev/fastrpc-adsp-secure and userspace never gets
> /dev/fastrpc-adsp, so libssc/hexagonrpcd cannot attach to the sensor PD
> (qrtr service 400) and iio-sensor-proxy reports no sensors at all.
Hm, this is a nuanced case - adding +Ekansh, +Dmitry and +Srini
> Observed on the Lenovo Legion Tab Y700 Gen4 (TB322FC), which is SM8750
> based: without this property /dev/fastrpc-adsp never appears and
> iio-sensor-proxy exposes neither accelerometer, ambient light nor
> proximity; with it, qrtr shows the "Snapdragon Sensor Core service"
> (id 400) and all three sensor types report as available. The change is
> one property on one node, matching what the CDSP node already does.
>
> Tested with `make CHECK_DTBS=y qcom/sm8750-mtp.dtb` (no new warnings; the
> single avoid_unnecessary_addr_size warning on dsi@ae96000 is present
> before and after).
>
> *** AI-assistance disclosure ***
> This patch and its commit message were prepared with the help of an LLM
> coding assistant. The author reviewed the change line by line, ran the
> checks quoted above on his own hardware and takes full responsibility
> for the content.
Please keep that under the --- line so it doesn't end up in the commit
log.
Konrad
>
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> ---
> arch/arm64/boot/dts/qcom/sm8750.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index cf947acc57..9302481b11 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2571,6 +2571,7 @@ fastrpc {
> compatible = "qcom,fastrpc";
> qcom,glink-channels = "fastrpcglink-apps-dsp";
> label = "adsp";
> + qcom,non-secure-domain;
> memory-region = <&adsp_rpc_remote_heap_mem>;
> qcom,vmids = <QCOM_SCM_VMID_LPASS
> QCOM_SCM_VMID_ADSP_HEAP>;
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
2026-11-07 3:26 [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain Qianhui Xu
2026-11-07 3:33 ` sashiko-bot
2026-11-09 14:16 ` Konrad Dybcio
@ 2026-11-10 2:31 ` Qianhui Xu
2026-11-10 2:41 ` sashiko-bot
2026-11-11 3:57 ` [PATCH v3] " Qianhui Xu
3 siblings, 1 reply; 6+ messages in thread
From: Qianhui Xu @ 2026-11-10 2:31 UTC (permalink / raw)
To: andersson, konradybcio
Cc: robh, krzk+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel
v2: add the Fixes tag requested in the sashiko review
(<sashiko-outbox-202531@kernel.org>). The diff is unchanged from v1.
On SM8750 the ADSP fastrpc instance used by the sensor core (and by the
other non-secure ADSP users) is the one the firmware exposes as
non-secure; the CDSP fastrpc node already carries
"qcom,non-secure-domain", the ADSP one does not. With the fastrpc driver
keying the secure/non-secure split off that property, the ADSP only
instantiates /dev/fastrpc-adsp-secure and userspace never gets
/dev/fastrpc-adsp, so libssc/hexagonrpcd cannot attach to the sensor PD
(qrtr service 400) and iio-sensor-proxy reports no sensors at all.
Observed on the Lenovo Legion Tab Y700 Gen4 (TB322FC), which is SM8750
based: without this property /dev/fastrpc-adsp never appears and
iio-sensor-proxy exposes neither accelerometer, ambient light nor
proximity; with it, qrtr shows the "Snapdragon Sensor Core service"
(id 400) and all three sensor types report as available. The change is
one property on one node, matching what the CDSP node already does.
Tested with `make CHECK_DTBS=y qcom/sm8750-mtp.dtb` (no new warnings; the
single avoid_unnecessary_addr_size warning on dsi@ae96000 is present
before and after).
*** AI-assistance disclosure ***
This patch and its commit message were prepared with the help of an LLM
coding assistant. The author reviewed the change line by line, ran the
checks quoted above on his own hardware and takes full responsibility
for the content.
Fixes: be9d54c35312479ed92c85aec3cd43153513210d ("arm64: dts: qcom: sm8750: add ADSP fastrpc-compute-cb nodes")
Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
---
arch/arm64/boot/dts/qcom/sm8750.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index cf947acc57..9302481b11 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2571,6 +2571,7 @@ fastrpc {
compatible = "qcom,fastrpc";
qcom,glink-channels = "fastrpcglink-apps-dsp";
label = "adsp";
+ qcom,non-secure-domain;
memory-region = <&adsp_rpc_remote_heap_mem>;
qcom,vmids = <QCOM_SCM_VMID_LPASS
QCOM_SCM_VMID_ADSP_HEAP>;
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
2026-11-10 2:31 ` [PATCH v2] " Qianhui Xu
@ 2026-11-10 2:41 ` sashiko-bot
0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-11-10 2:41 UTC (permalink / raw)
To: Qianhui Xu; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: sm8750: v2 revision note placed in commit
message body
- [Low] arm64: dts: qcom: sm8750: qcom,non-secure-domain placed before
memory-region
--
commit a18d45b6dd4c9437dfa6368a1222360ec6bb808a
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
>
> v2: add the Fixes tag requested in the sashiko review
> (<sashiko-outbox-202531@kernel.org>). The diff is unchanged from v1.
>
> On SM8750 the ADSP fastrpc instance used by the sensor core (and by the
> other non-secure ADSP users) is the one the firmware exposes as
> non-secure; the CDSP fastrpc node already carries
> "qcom,non-secure-domain", the ADSP one does not. With the fastrpc driver
> keying the secure/non-secure split off that property, the ADSP only
> instantiates /dev/fastrpc-adsp-secure and userspace never gets
> /dev/fastrpc-adsp, so libssc/hexagonrpcd cannot attach to the sensor PD
> (qrtr service 400) and iio-sensor-proxy reports no sensors at all.
>
> Observed on the Lenovo Legion Tab Y700 Gen4 (TB322FC), which is SM8750
> based: without this property /dev/fastrpc-adsp never appears and
> iio-sensor-proxy exposes neither accelerometer, ambient light nor
> proximity; with it, qrtr shows the "Snapdragon Sensor Core service"
> (id 400) and all three sensor types report as available. The change is
> one property on one node, matching what the CDSP node already does.
>
> Tested with `make CHECK_DTBS=y qcom/sm8750-mtp.dtb` (no new warnings; the
> single avoid_unnecessary_addr_size warning on dsi@ae96000 is present
> before and after).
>
> *** AI-assistance disclosure ***
> This patch and its commit message were prepared with the help of an LLM
> coding assistant. The author reviewed the change line by line, ran the
> checks quoted above on his own hardware and takes full responsibility
> for the content.
>
> Fixes: be9d54c35312479ed92c85aec3cd43153513210d ("arm64: dts: qcom: sm8750: add ADSP fastrpc-compute-cb nodes")
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
[Severity: Low]
This isn't a bug, but the v2 patch changelog paragraph belongs below the
--- separator line so git am strips it rather than recording it in the
permanent commit history. Also, the Fixes: tag should use a 12-character
SHA prefix:
Fixes: be9d54c35312 ("arm64: dts: qcom: sm8750: add ADSP fastrpc-compute-cb nodes")
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index cf947acc57602..9302481b112af 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2571,6 +2571,7 @@ fastrpc {
> compatible = "qcom,fastrpc";
> qcom,glink-channels = "fastrpcglink-apps-dsp";
> label = "adsp";
> + qcom,non-secure-domain;
> memory-region = <&adsp_rpc_remote_heap_mem>;
> qcom,vmids = <QCOM_SCM_VMID_LPASS
> QCOM_SCM_VMID_ADSP_HEAP>;
[Severity: Low]
This isn't a bug, but per the Devicetree coding style and
scripts/dtc/dt-check-style, standard properties such as memory-region
should precede vendor-prefixed properties, so qcom,non-secure-domain
should be placed after memory-region.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110023153.84262-1-xiaqinghuan@mail.ustc.edu.cn?part=1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
2026-11-07 3:26 [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain Qianhui Xu
` (2 preceding siblings ...)
2026-11-10 2:31 ` [PATCH v2] " Qianhui Xu
@ 2026-11-11 3:57 ` Qianhui Xu
3 siblings, 0 replies; 6+ messages in thread
From: Qianhui Xu @ 2026-11-11 3:57 UTC (permalink / raw)
To: andersson, konradybcio
Cc: robh, krzk+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel
On SM8750 the ADSP fastrpc instance used by the sensor core (and by the
other non-secure ADSP users) is the one the firmware exposes as
non-secure; the CDSP fastrpc node already carries
"qcom,non-secure-domain", the ADSP one does not. With the fastrpc driver
keying the secure/non-secure split off that property, the ADSP only
instantiates /dev/fastrpc-adsp-secure and userspace never gets
/dev/fastrpc-adsp, so libssc/hexagonrpcd cannot attach to the sensor PD
(qrtr service 400) and iio-sensor-proxy reports no sensors at all.
Observed on the Lenovo Legion Tab Y700 Gen4 (TB322FC), which is SM8750
based: without this property /dev/fastrpc-adsp never appears and
iio-sensor-proxy exposes neither accelerometer, ambient light nor
proximity; with it, qrtr shows the "Snapdragon Sensor Core service"
(id 400) and all three sensor types report as available. The change is
one property on one node, matching what the CDSP node already does.
Tested with `make CHECK_DTBS=y qcom/sm8750-mtp.dtb` (no new warnings; the
single avoid_unnecessary_addr_size warning on dsi@ae96000 is present
before and after).
*** AI-assistance disclosure ***
This patch and its commit message were prepared with the help of an LLM
coding assistant. The author reviewed the change line by line, ran the
checks quoted above on his own hardware and takes full responsibility
for the content.
Fixes: be9d54c35312 ("arm64: dts: qcom: sm8750: add ADSP fastrpc-compute-cb nodes")
Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
---
v3: move the changelog below the --- line, use a 12-character Fixes hash and
place the new property after memory-region, as requested in review.
v2: add the Fixes tag requested in the sashiko review
(<sashiko-outbox-202531@kernel.org>). The diff is unchanged from v1.
arch/arm64/boot/dts/qcom/sm8750.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index cf947acc57..9302481b11 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2571,6 +2571,7 @@ fastrpc {
compatible = "qcom,fastrpc";
qcom,glink-channels = "fastrpcglink-apps-dsp";
label = "adsp";
memory-region = <&adsp_rpc_remote_heap_mem>;
+ qcom,non-secure-domain;
qcom,vmids = <QCOM_SCM_VMID_LPASS
QCOM_SCM_VMID_ADSP_HEAP>;
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread