Re: [PATCH v3 4/8] ARM: dts: imx6ulz: Pull down BSH SMM-M2 active-high WLAN IRQ

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] ARM: dts: imx6ulz: unexplained removal of cap-sdio-irq from
  usdhc2
- [Low] ARM: dts: imx6ulz: missing Fixes trailer for WLAN IRQ pull-down
  fix
--

commit 61c3fd2805764ab0c52e0d5e388368c4a4afb1cd
Author: Roman Smrž <roman@amarulasolutions.com>

> ARM: dts: imx6ulz: Pull down BSH SMM-M2 active-high WLAN IRQ
>
> The pin is active when high, so pull-up configuration can trigger
> unwanted interrupts during module loading or unloading. Change the
> configuration to pull-down to avoid crashes there.
>
> Signed-off-by: Roman Smrž <roman@amarulasolutions.com>
> Signed-off-by: Haoning Cheng <Haoning.CHENG@cn.bosch.com>

[Severity: Low]
This fixes the pull-up configuration on the active-high WLAN IRQ pin.  Should
this include a Fixes tag?

  Fixes: eb197dfe389a ("ARM: dts: imx6ulz-bsh-smm-m2: Add BSH SMM-M2 IMX6ULZ SystemMaster")

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> index dabe17222f139..91c76909c0867 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> @@ -81,7 +81,6 @@ &usdhc2 {
>  	non-removable;
>  	cap-power-off-card;
>  	keep-power-in-suspend;
> -	cap-sdio-irq;
>  	mmc-pwrseq = <&usdhc2_pwrseq>;
>  	status = "okay";

[Severity: Low]
Why is cap-sdio-irq removed from usdhc2 here?  The commit message only
describes changing the MX6UL_PAD_UART1_CTS_B__GPIO1_IO18 pad configuration,
and sdhci_setup_host() sets MMC_CAP_SDIO_IRQ unconditionally regardless of
this property.  If dropping the redundant property is intentional, could it
be mentioned in the commit message or split into a separate commit?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-add-bsh-smm-m2-v3-0-4abdf10e9a7f@cn.bosch.com?part=4