From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org,
conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH 9/9] arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link
Date: Thu, 12 Nov 2026 00:17:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-209895@kernel.org> (raw)
In-Reply-To: <20261111-dtbs-marvell-v1-9-938788aff3ae@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: marvell: missing Fixes trailer for gl-mv1000
fixed-link fix
--
commit a68eb6dc3b861d90e5a107b8b38a297faa592448
Author: Rob Herring (Arm) <robh@kernel.org>
> arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link
>
> As the switch port 0 has an 'ethernet' phandle, 'phy-mode' and one of
> 'fixed-link', 'phy-handle' or 'managed' are required by the DSA schema.
> The expressobin has appears to have a similar configuration, so copy it
> and use 'fixed-link'.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
[Severity: Low]
Without phy-mode and fixed-link on CPU port 0, dsa_shared_port_validate_of()
fails validation and skips phylink registration for the switch CPU port.
Should this include a Fixes tag for the commit that added the board DTS:
Fixes: 6d5a6740f6df ("arm64: dts: marvell: add DTS for GL.iNet GL-MV1000")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=9
prev parent reply other threads:[~2026-11-12 0:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 22:42 [PATCH 0/9] arm64: dts: marvell: DT warning fixes Rob Herring (Arm)
2026-11-11 22:42 ` [PATCH 1/9] dt-bindings: mfd: Add Marvell AP806/CP110 system controller schema Rob Herring (Arm)
2026-11-12 0:21 ` sashiko-bot
2026-11-11 22:42 ` [PATCH 2/9] arm64: dts: marvell: Add AP806/CP110 syscon compatibles Rob Herring (Arm)
2026-11-12 0:21 ` sashiko-bot
2026-11-11 22:43 ` [PATCH 3/9] arm64: dts: marvell: Drop unused USB connector PHY supplies Rob Herring (Arm)
2026-11-12 0:19 ` sashiko-bot
2026-11-11 22:43 ` [PATCH 4/9] arm64: dts: marvell: Drop SPI max frequency Rob Herring (Arm)
2026-11-11 22:43 ` [PATCH 5/9] arm64: dts: marvell: Fix node names Rob Herring (Arm)
2026-11-12 0:21 ` sashiko-bot
2026-11-11 22:43 ` [PATCH 6/9] arm64: dts: marvell: Fix w25q32 compatible strings Rob Herring (Arm)
2026-11-11 22:43 ` [PATCH 7/9] arm64: dts: marvell: Drop unused USB 'phy-names' Rob Herring (Arm)
2026-11-11 22:43 ` [PATCH 8/9] arm64: dts: marvell: cn9131-cf-solidwan: Drop st,m41t80 reset-gpios Rob Herring (Arm)
2026-11-11 22:43 ` [PATCH 9/9] arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link Rob Herring (Arm)
2026-11-12 0:17 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209895@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox