[PATCH 0/9] arm64: dts: marvell: DT warning fixes

[PATCH 0/9] arm64: dts: marvell: DT warning fixes

[Rob Herring (Arm)]

Another batch of DT schema warning fixes for Marvell platforms. This
fixes most of the remaining warnings on Marvell platforms.

It's best if the whole series is taken together.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Rob Herring (Arm) (9):
      dt-bindings: mfd: Add Marvell AP806/CP110 system controller schema
      arm64: dts: marvell: Add AP806/CP110 syscon compatibles
      arm64: dts: marvell: Drop unused USB connector PHY supplies
      arm64: dts: marvell: Drop SPI max frequency
      arm64: dts: marvell: Fix node names
      arm64: dts: marvell: Fix w25q32 compatible strings
      arm64: dts: marvell: Drop unused USB 'phy-names'
      arm64: dts: marvell: cn9131-cf-solidwan: Drop st,m41t80 reset-gpios
      arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link

 .../mfd/marvell,ap806-cp110-system-controller.yaml | 59 ++++++++++++++++++++++
 arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi      |  2 +-
 .../boot/dts/marvell/armada-3720-gl-mv1000.dts     |  6 +++
 .../boot/dts/marvell/armada-3720-turris-mox.dts    |  1 -
 arch/arm64/boot/dts/marvell/armada-7040-db.dts     |  2 -
 .../dts/marvell/armada-8040-clearfog-gt-8k.dts     |  5 +-
 arch/arm64/boot/dts/marvell/armada-8040-db.dts     |  1 -
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi |  3 +-
 .../boot/dts/marvell/armada-8040-puzzle-m801.dts   | 11 ++--
 arch/arm64/boot/dts/marvell/armada-ap80x.dtsi      |  6 ++-
 arch/arm64/boot/dts/marvell/armada-cp11x.dtsi      |  6 ++-
 arch/arm64/boot/dts/marvell/cn9130-crb-A.dts       |  2 -
 arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi     |  2 -
 arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts |  1 -
 .../boot/dts/marvell/cn9131-db-comexpress.dtsi     |  4 +-
 15 files changed, 84 insertions(+), 27 deletions(-)
---
base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
change-id: 20261111-dtbs-marvell-3ae21c8ac47d

Best regards,
--  
Rob Herring (Arm) <robh@kernel.org>

[PATCH 1/9] dt-bindings: mfd: Add Marvell AP806/CP110 system controller schema

[Rob Herring (Arm)]

The Marvell AP806 and CP110 lack specific compatibles. Add a dedicated
schema for the Marvell AP806 and CP110 system controllers and their
child devices.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../mfd/marvell,ap806-cp110-system-controller.yaml | 59 ++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/marvell,ap806-cp110-system-controller.yaml b/Documentation/devicetree/bindings/mfd/marvell,ap806-cp110-system-controller.yaml
new file mode 100644
index 000000000000..4c43986c2c0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/marvell,ap806-cp110-system-controller.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/marvell,ap806-cp110-system-controller.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell AP806 and CP110 system controller
+
+maintainers:
+  - Andrew Lunn <andrew@lunn.ch>
+  - Gregory Clement <gregory.clement@bootlin.com>
+  - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - marvell,ap806-system-controller
+          - marvell,cp110-system-controller
+      - const: syscon
+      - const: simple-mfd
+
+  reg:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  clock:
+    oneOf:
+      - $ref: /schemas/clock/marvell,ap80x-clock.yaml#
+      - $ref: /schemas/clock/marvell,cp110-clock.yaml#
+
+  pinctrl:
+    oneOf:
+      - $ref: /schemas/pinctrl/marvell,ap806-pinctrl.yaml#
+      - $ref: /schemas/pinctrl/marvell,armada-7k-pinctrl.yaml#
+
+patternProperties:
+  "^gpio@[0-9a-f]+$":
+    $ref: /schemas/gpio/gpio-mvebu.yaml#
+
+  "^clock-cpu(@[0-9a-f]+)?$":
+    $ref: /schemas/clock/marvell,ap80x-clock.yaml#
+
+  "^thermal-sensor@[0-9a-f]+$":
+    $ref: /schemas/thermal/marvell,armada-ap806-thermal.yaml#
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: syscon-common.yaml#
+
+unevaluatedProperties: false

-- 
2.53.0

[PATCH 2/9] arm64: dts: marvell: Add AP806/CP110 syscon compatibles

[Rob Herring (Arm)]

Add specific compatibles for the AP806 and CP110 system-controller
syscon blocks that host pinctrl, GPIO, clock and thermal child nodes.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 6 ++++--
 arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
index 40e146982921..0da13b2cd1fc 100644
--- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
@@ -267,7 +267,8 @@ ap_sdhci0: mmc@6e0000 {
 			};
 
 			ap_syscon0: system-controller@6f4000 {
-				compatible = "syscon", "simple-mfd";
+				compatible = "marvell,ap806-system-controller",
+					     "syscon", "simple-mfd";
 				reg = <0x6f4000 0x2000>;
 
 				ap_pinctrl: pinctrl {
@@ -293,7 +294,8 @@ ap_gpio: gpio@1040 {
 			};
 
 			ap_syscon1: system-controller@6f8000 {
-				compatible = "syscon", "simple-mfd";
+				compatible = "marvell,ap806-system-controller",
+					     "syscon", "simple-mfd";
 				reg = <0x6f8000 0x1000>;
 				#address-cells = <1>;
 				#size-cells = <1>;
diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
index 39599171d51b..9e365af19a0c 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
@@ -225,7 +225,8 @@ CP11X_LABEL(rtc): rtc@284000 {
 		};
 
 		CP11X_LABEL(syscon0): system-controller@440000 {
-			compatible = "syscon", "simple-mfd";
+			compatible = "marvell,cp110-system-controller",
+				     "syscon", "simple-mfd";
 			reg = <0x440000 0x2000>;
 
 			CP11X_LABEL(clk): clock {
@@ -277,7 +278,8 @@ CP11X_LABEL(gpio2): gpio@140 {
 		};
 
 		CP11X_LABEL(syscon1): system-controller@400000 {
-			compatible = "syscon", "simple-mfd";
+			compatible = "marvell,cp110-system-controller",
+				     "syscon", "simple-mfd";
 			reg = <0x400000 0x1000>;
 			#address-cells = <1>;
 			#size-cells = <1>;

-- 
2.53.0

[PATCH 3/9] arm64: dts: marvell: Drop unused USB connector PHY supplies

[Rob Herring (Arm)]

'phy-supply' is not a documented USB connector property. The generic PHY
framework only retrieves phy-supply from a PHY provider node. These
connector-child properties have no consumer, so remove them.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts     | 1 -
 arch/arm64/boot/dts/marvell/armada-7040-db.dts             | 2 --
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 -
 arch/arm64/boot/dts/marvell/armada-8040-db.dts             | 1 -
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi         | 1 -
 arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts    | 1 -
 6 files changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index bd00e7df87c6..1ef4689d5f18 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -284,7 +284,6 @@ &usb2 {
 &comphy2 {
 	connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&exp_usb3_vbus>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
index 3add6506ff20..f5a53fad66e6 100644
--- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
+++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
@@ -224,7 +224,6 @@ &cp0_utmi {
 &cp0_comphy1 {
 	cp0_usbh0_con: connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&cp0_reg_usb3_0_vbus>;
 	};
 };
 
@@ -238,7 +237,6 @@ &cp0_usb3_0 {
 &cp0_comphy4 {
 	cp0_usbh1_con: connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&cp0_reg_usb3_1_vbus>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 90ae93274a16..4efa2a1dbda7 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -599,7 +599,6 @@ flash@0 {
 &cp1_comphy2 {
 	cp1_usbh0_con: connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&v_5v0_usb3_hst_vbus>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
index c7102f74d4d5..89e6f35f310d 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
@@ -170,7 +170,6 @@ &cp0_usb3_0 {
 &cp0_comphy4 {
 	cp0_usbh1_con: connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&cp0_reg_usb3_1_vbus>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index f2d278d171eb..006293931c78 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -370,7 +370,6 @@ flash@0 {
 &cp1_comphy2 {
 	cp1_usbh0_con: connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&v_5v0_usb3_hst_vbus>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
index def25d51c4bf..06a861f83ad8 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
@@ -491,7 +491,6 @@ &cp1_uart0 {
 &cp1_comphy2 {
 	cp1_usbh0_con: connector {
 		compatible = "usb-a-connector";
-		phy-supply = <&v_5v0_usb3_hst_vbus>;
 	};
 };
 

-- 
2.53.0

[PATCH 4/9] arm64: dts: marvell: Drop SPI max frequency

[Rob Herring (Arm)]

Remove spi-max-frequency from the CP0 SPI controller node on the
CN9130 SolidRun SOM. The property belongs on SPI devices, and the
flash child already has its own maximum frequency. Plus, pretty
sure 1.8GHz is not a possible SPI bus frequency.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi b/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi
index f95202decfce..7200f72b934f 100644
--- a/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi
+++ b/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi
@@ -106,8 +106,6 @@ &cp0_spi1 {
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&cp0_spi1_pins>;
-	/* max speed limited by a mux */
-	spi-max-frequency = <1800000000>;
 
 	flash@0 {
 		compatible = "jedec,spi-nor";

-- 
2.53.0

[PATCH 5/9] arm64: dts: marvell: Fix node names

[Rob Herring (Arm)]

Fix various node names to use standard names.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi              |  2 +-
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts |  2 +-
 arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts    | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
index 4878773883c9..814b8a2e8ea9 100644
--- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
@@ -231,7 +231,7 @@ sdhci: mmc@805c0000 {
 		 * Dedicated section for devices behind 32bit controllers so we
 		 * can configure specific DMA mapping for them
 		 */
-		behind-32bit-controller@7f000000 {
+		dma-bus@0 {
 			compatible = "simple-bus";
 			#address-cells = <0x2>;
 			#size-cells = <0x2>;
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 4efa2a1dbda7..101d1518e28f 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -324,7 +324,7 @@ cp0_led1_pins: led1-pins {
 		marvell,function = "gpio";
 	};
 
-	cp0_copper_eth_phy_reset: copper-eth-phy-reset {
+	cp0_copper_eth_phy_reset: copper-eth-phy-reset-pins {
 		marvell,pins = "mpp43";
 		marvell,function = "gpio";
 	};
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
index 06a861f83ad8..68c8489e0a6f 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
@@ -165,7 +165,7 @@ cpu_active: cpu-active {
 		};
 	};
 	cooling-maps {
-		fan-map {
+		map-fan {
 			trip = <&cpu_active>;
 			cooling-device = <&chassis_fan_group0 64 THERMAL_NO_LIMIT>,
 					<&chassis_fan_group1 64 THERMAL_NO_LIMIT>;
@@ -191,19 +191,19 @@ flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0x0>;
 		spi-max-frequency = <20000000>;
-		partition@u-boot {
+		partition@0 {
 			label = "u-boot";
 			reg = <0x00000000 0x001f0000>;
 		};
-		partition@u-boot-env {
+		partition@1f0000 {
 			label = "u-boot-env";
 			reg = <0x001f0000 0x00010000>;
 		};
-		partition@ubi1 {
+		partition@200000 {
 			label = "ubi1";
 			reg = <0x00200000 0x03f00000>;
 		};
-		partition@ubi2 {
+		partition@4100000 {
 			label = "ubi2";
 			reg = <0x04100000 0x03f00000>;
 		};

-- 
2.53.0

[PATCH 6/9] arm64: dts: marvell: Fix w25q32 compatible strings

[Rob Herring (Arm)]

The w25q32 SPI NOR Flash is a Winbond, not ST, part and is missing the
"jedec,spi-nor" fallback.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 2 +-
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 101d1518e28f..0de09d126104 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -590,7 +590,7 @@ &cp1_spi1 {
 	status = "okay";
 
 	flash@0 {
-		compatible = "st,w25q32";
+		compatible = "winbond,w25q32", "jedec,spi-nor";
 		spi-max-frequency = <50000000>;
 		reg = <0>;
 	};
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index 006293931c78..067951cd7449 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -361,7 +361,7 @@ &cp1_spi1 {
 	status = "okay";
 
 	flash@0 {
-		compatible = "st,w25q32";
+		compatible = "winbond,w25q32", "jedec,spi-nor";
 		spi-max-frequency = <50000000>;
 		reg = <0>;
 	};

-- 
2.53.0

[PATCH 7/9] arm64: dts: marvell: Drop unused USB 'phy-names'

[Rob Herring (Arm)]

'phy-names' is not valid without a corresponding 'phys' property, so
drop them when 'phys' is not present.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/cn9130-crb-A.dts          | 2 --
 arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts b/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts
index a7b6dfba8af5..5823b25e5faf 100644
--- a/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts
+++ b/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts
@@ -28,11 +28,9 @@ &cp0_comphy2 0
 &cp0_usb3_0 {
 	status = "okay";
 	usb-phy = <&cp0_usb3_0_phy0>;
-	phy-names = "usb";
 };
 
 &cp0_usb3_1 {
 	status = "okay";
 	usb-phy = <&cp0_usb3_0_phy1>;
-	phy-names = "usb";
 };
diff --git a/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi b/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
index 71c225221617..a68c958fbb30 100644
--- a/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
+++ b/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
@@ -89,15 +89,15 @@ &cp0_spi1 {
 &cp0_usb3_0 {
 	status = "okay";
 	usb-phy = <&cp0_usb3_0_phy0>;
-	phy-names = "usb";
 	/delete-property/ phys;
+	/delete-property/ phy-names;
 };
 
 &cp0_usb3_1 {
 	status = "okay";
 	usb-phy = <&cp0_usb3_0_phy1>;
-	phy-names = "usb";
 	/delete-property/ phys;
+	/delete-property/ phy-names;
 };
 
 &cp1_usb3_1 {

-- 
2.53.0

[PATCH 8/9] arm64: dts: marvell: cn9131-cf-solidwan: Drop st,m41t80 reset-gpios

[Rob Herring (Arm)]

The part has no reset line nor does the Linux driver handle the property,
so drop it.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts b/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts
index b6aeba7d0a61..0b079e1428bf 100644
--- a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts
+++ b/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts
@@ -252,7 +252,6 @@ carrier_rtc: rtc@68 {
 		pinctrl-names = "default";
 		interrupt-parent = <&cp1_gpio1>;
 		interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
-		reset-gpios = <&cp1_gpio1 13 GPIO_ACTIVE_LOW>;
 	};
 };
 

-- 
2.53.0

[PATCH 9/9] arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link

[Rob Herring (Arm)]

As the switch port 0 has an 'ethernet' phandle, 'phy-mode' and one of
'fixed-link', 'phy-handle' or 'managed' are required by the DSA schema.
The expressobin has appears to have a similar configuration, so copy it
and use 'fixed-link'.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
index a881a3326dba..93af902f4f6f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
@@ -161,6 +161,12 @@ ethernet-port@0 {
 				reg = <0>;
 				label = "cpu";
 				ethernet = <&eth0>;
+				phy-mode = "rgmii-id";
+
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
 			};
 
 			ethernet-port@1 {

-- 
2.53.0

Re: [PATCH 9/9] arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: marvell: missing Fixes trailer for gl-mv1000
  fixed-link fix
--

commit a68eb6dc3b861d90e5a107b8b38a297faa592448
Author: Rob Herring (Arm) <robh@kernel.org>

> arm64: dts: marvell: armada-3720-gl-mv1000: Add switch fixed-link
>
> As the switch port 0 has an 'ethernet' phandle, 'phy-mode' and one of
> 'fixed-link', 'phy-handle' or 'managed' are required by the DSA schema.
> The expressobin has appears to have a similar configuration, so copy it
> and use 'fixed-link'.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

[Severity: Low]
Without phy-mode and fixed-link on CPU port 0, dsa_shared_port_validate_of()
fails validation and skips phylink registration for the switch CPU port.
Should this include a Fixes tag for the commit that added the board DTS:

  Fixes: 6d5a6740f6df ("arm64: dts: marvell: add DTS for GL.iNet GL-MV1000")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=9

Re: [PATCH 3/9] arm64: dts: marvell: Drop unused USB connector PHY supplies

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: marvell: broken USB VBUS power after dropping
  phy-supply
--

commit 79bdb6a1206b7da32a160f289517e10fea0f4702
Author: Rob Herring (Arm) <robh@kernel.org>

arm64: dts: marvell: Drop unused USB connector PHY supplies

This commit removes the phy-supply properties from the usb-a-connector child
nodes of the Marvell COMPHY lane nodes across six Armada 3720, 7040, and 8040
device trees.

> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index bd00e7df87c67..1ef4689d5f18e 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -284,7 +284,6 @@ &usb2 {
>  &comphy2 {
>  	connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&exp_usb3_vbus>;
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> index 3add6506ff20e..f5a53fad66e67 100644
> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> @@ -224,7 +224,6 @@ &cp0_utmi {
>  &cp0_comphy1 {
>  	cp0_usbh0_con: connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&cp0_reg_usb3_0_vbus>;
>  	};
>  };
>  
> @@ -238,7 +237,6 @@ &cp0_usb3_0 {
>  &cp0_comphy4 {
>  	cp0_usbh1_con: connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&cp0_reg_usb3_1_vbus>;
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 90ae93274a160..4efa2a1dbda7c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -599,7 +599,6 @@ flash@0 {
>  &cp1_comphy2 {
>  	cp1_usbh0_con: connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&v_5v0_usb3_hst_vbus>;
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> index c7102f74d4d54..89e6f35f310dd 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> @@ -170,7 +170,6 @@ &cp0_usb3_0 {
>  &cp0_comphy4 {
>  	cp0_usbh1_con: connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&cp0_reg_usb3_1_vbus>;
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> index f2d278d171eb1..006293931c782 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> @@ -370,7 +370,6 @@ flash@0 {
>  &cp1_comphy2 {
>  	cp1_usbh0_con: connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&v_5v0_usb3_hst_vbus>;
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
> index def25d51c4bf9..06a861f83ad87 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
> @@ -491,7 +491,6 @@ &cp1_uart0 {
>  &cp1_comphy2 {
>  	cp1_usbh0_con: connector {
>  		compatible = "usb-a-connector";
> -		phy-supply = <&v_5v0_usb3_hst_vbus>;
>  	};
>  };

[Severity: High]
Does dropping phy-supply here without moving the supply to the parent COMPHY
lane node (or vbus-supply on the connector) leave the USB3 VBUS regulators
disabled on these boards?

When mvebu_comphy_probe() and mvebu_a3700_comphy_probe() create a PHY for
each lane node, phy_create() calls regulator_get_optional(&phy->dev, "phy").
In of_get_regulator(), if phy-supply is not present on the lane node itself,
it falls back to searching child nodes:

drivers/regulator/of_regulator.c:of_get_regulator() {
	...
	snprintf(prop_name, 64, "%s-supply", supply);
	regnode = of_parse_phandle(node, prop_name, 0);
	if (regnode)
		return regnode;

	regnode = of_get_child_regulator(dev->of_node, prop_name);
	if (regnode)
		return regnode;
	...
}

Because of_get_child_regulator() finds phy-supply in the connector child
node, phy_power_on() currently enables these VBUS regulators when the xHCI
roothub powers on its PHYs. Removing phy-supply without moving it to the
parent lane node leaves cp0_reg_usb3_0_vbus, cp0_reg_usb3_1_vbus, and
v_5v0_usb3_hst_vbus (which are GPIO-controlled regulators without
regulator-always-on) with no consumer, so 5V VBUS power to the USB3 host
ports is never turned on.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=3

Re: [PATCH 5/9] arm64: dts: marvell: Fix node names

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: marvell: ac5: dma-bus@0 unit-address mismatches
  ranges parent addr
--

commit d32f1cd6738013623bd9cd4b37c287a2b69edbf8
Author: Rob Herring (Arm) <robh@kernel.org>

arm64: dts: marvell: Fix node names

This commit updates node names across several Marvell device tree files to
use standard naming conventions.

> diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> index 4878773883c95..814b8a2e8ea93 100644
> --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> @@ -231,7 +231,7 @@ sdhci: mmc@805c0000 {
>  		 * Dedicated section for devices behind 32bit controllers so we
>  		 * can configure specific DMA mapping for them
>  		 */
> -		behind-32bit-controller@7f000000 {
> +		dma-bus@0 {
>  			compatible = "simple-bus";
>  			#address-cells = <0x2>;
>  			#size-cells = <0x2>;

[Severity: Low]
Should this node be named dma-bus@7f000000 instead of dma-bus@0?

This node has no reg property and defines:

  ranges = <0x0 0x0 0x0 0x7f000000 0x0 0x1000000>;

In check_simple_bus_reg(), dtc skips the 2-cell child address (0x0 0x0) and
matches the unit-address against the parent /soc bus address (0x0 0x7f000000),
so building DTBs with W=1 warns:

  Warning (simple_bus_reg): /soc/dma-bus@0: simple-bus unit address format error, expected "7f000000"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=5

Re: [PATCH 2/9] arm64: dts: marvell: Add AP806/CP110 syscon compatibles

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: marvell: ap806-system-controller triggers legacy
  clk probe failure
--

commit d5587b2920b1facc3deb1cff76751746477ff106
Author: Rob Herring (Arm) <robh@kernel.org>

arm64: dts: marvell: Add AP806/CP110 syscon compatibles

This commit adds "marvell,ap806-system-controller" and
"marvell,cp110-system-controller" compatibles to the AP806 and CP110
system-controller syscon nodes.

> diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> index 40e1469829212..0da13b2cd1fc0 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> @@ -267,7 +267,8 @@ ap_sdhci0: mmc@6e0000 {
>  			};
>  
>  			ap_syscon0: system-controller@6f4000 {
> -				compatible = "syscon", "simple-mfd";
> +				compatible = "marvell,ap806-system-controller",
> +					     "syscon", "simple-mfd";
>  				reg = <0x6f4000 0x2000>;
>  
>  				ap_pinctrl: pinctrl {
> @@ -293,7 +294,8 @@ ap_gpio: gpio@1040 {
>  			};
>  
>  			ap_syscon1: system-controller@6f8000 {
> -				compatible = "syscon", "simple-mfd";
> +				compatible = "marvell,ap806-system-controller",
> +					     "syscon", "simple-mfd";
>  				reg = <0x6f8000 0x1000>;
>  				#address-cells = <1>;
>  				#size-cells = <1>;

[Severity: Medium]
Does adding "marvell,ap806-system-controller" to ap_syscon0 and ap_syscon1
cause both nodes to bind to ap806_syscon_legacy_driver and fail probe?

drivers/clk/mvebu/ap806-system-controller.c matches
"marvell,ap806-system-controller" for the deprecated flat-node clock
binding:

drivers/clk/mvebu/ap806-system-controller.c:ap806_syscon_legacy_probe() {
	dev_warn(&pdev->dev, FW_WARN "Using legacy device tree binding\n");
	dev_warn(&pdev->dev, FW_WARN "Update your device tree:\n");
	dev_warn(&pdev->dev, FW_WARN
		 "This binding won't be supported in future kernel\n");

	return ap806_syscon_common_probe(pdev, pdev->dev.of_node);
}

ap806_syscon_common_probe() then reads AP806_SAR_REG (offset 0x400) from
each syscon regmap (including System Controller 1 on ap_syscon1) and
checks pdev->dev.of_node against "marvell,ap806-clock" and
"marvell,ap807-clock".  Because pdev->dev.of_node is the parent
system-controller node rather than the clock child node, both devices emit
false FW_WARN messages, log "compatible not supported", and fail probe
with -EINVAL on every boot.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=2

Re: [PATCH 1/9] dt-bindings: mfd: Add Marvell AP806/CP110 system controller schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: mfd: marvell,ap806-system-controller collides
  with legacy driver
--

commit 4cddea2359377a9e6ae88c719cab7c7efc9634bf
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: mfd: Add Marvell AP806/CP110 system controller schema

This commit adds a dedicated Device Tree binding schema for the Marvell
AP806 and CP110 system controllers and their child devices.

> diff --git a/Documentation/devicetree/bindings/mfd/marvell,ap806-cp110-system-controller.yaml b/Documentation/devicetree/bindings/mfd/marvell,ap806-cp110-system-controller.yaml
> new file mode 100644
> index 0000000000000..4c43986c2c0a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/marvell,ap806-cp110-system-controller.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/marvell,ap806-cp110-system-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell AP806 and CP110 system controller
> +
> +maintainers:
> +  - Andrew Lunn <andrew@lunn.ch>
> +  - Gregory Clement <gregory.clement@bootlin.com>
> +  - Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - marvell,ap806-system-controller
> +          - marvell,cp110-system-controller
> +      - const: syscon
> +      - const: simple-mfd

[Severity: Medium]
Does requiring marvell,ap806-system-controller on the parent simple-mfd
node cause a collision with the built-in legacy clock driver?

Unlike CP110, where cp110_syscon_legacy_of_match matches
marvell,cp110-system-controller0, ap806_syscon_legacy_of_match matches
marvell,ap806-system-controller:

drivers/clk/mvebu/ap806-system-controller.c:
static const struct of_device_id ap806_syscon_legacy_of_match[] = {
	{ .compatible = "marvell,ap806-system-controller", },
	{ }
};

When a device tree conforms to this schema, ap806_syscon_legacy_driver
binds to the parent MFD platform_device at boot.
ap806_syscon_legacy_probe() then logs three false FW_WARN messages about a
legacy binding, performs an unintended regmap_read() of AP806_SAR_REG
(0x400) in ap806_syscon_common_probe(), and fails probe with -EINVAL and
"compatible not supported" because the parent node is not compatible with
marvell,ap806-clock or marvell,ap807-clock.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=1