From: sashiko-bot@kernel.org
To: "Michal Simek" <michal.simek@amd.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: versal: dts: Add PCIe reset IDs
Date: Thu, 12 Nov 2026 08:56:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-210803@kernel.org> (raw)
In-Reply-To: <b06d55abdb0671d9dc987057f44c989317e19680.1794473022.git.michal.simek@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: versal: dts: macro name mismatch between commit log and
header
--
commit a1880b29ae774d1de118295c96e2eedcfea5ec9e
Author: Sandeep Reddy Ghanapuram <sandeep.reddy-ghanapuram@amd.com>
arm64: versal: dts: Add PCIe reset IDs
This commit adds the XAPE0 and XAPE1 reset ID definitions for CPM6 PCIe
controllers to the Versal reset header.
> diff --git a/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h b/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h
> index fe00f4a0ba65b..f8189d1cbc129 100644
> --- a/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h
> +++ b/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h
> @@ -102,5 +102,7 @@
> #define VERSAL_RST_XRAM (0xc30c05dU)
> #define VERSAL_RST_AIE_ARRAY (0xc10405eU)
> #define VERSAL_RST_AIE_SHIM (0xc10405fU)
> +#define VERSAL_RST_XAPE0 (0xc410115U)
> +#define VERSAL_RST_XAPE1 (0xc410116U)
[Severity: Low]
This isn't a bug, but the commit message says this adds VERSAL_RST_XAPE_0
and VERSAL_RST_XAPE_1, whereas the macros defined here omit the
underscore before the index (VERSAL_RST_XAPE0 and VERSAL_RST_XAPE1).
--
Sashiko AI review · https://sashiko.dev/#/patchset/b06d55abdb0671d9dc987057f44c989317e19680.1794473022.git.michal.simek@amd.com?part=1
prev parent reply other threads:[~2026-11-12 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:43 [PATCH] arm64: versal: dts: Add PCIe reset IDs Michal Simek
2026-11-12 8:56 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210803@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox