Re: [PATCH ath-next 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton for QCN9575

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] wifi: ath12k: missing sta_set_4addr callback in
  ath12k_ops_wifi8
--

commit 6de3568cf375a8ba9425721f1a8ad36656373d50
Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>

wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton for QCN9575

This commit adds a dedicated ath12k_ops_wifi8 ieee80211_ops table with a
placeholder TX callback and existing common ath12k_mac_op_* callbacks,
and hooks it in ath12k_wifi8_hw_init().

> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/hw.c b/drivers/net/wireless/ath/ath12k/wifi8/hw.c
> index 92c897de16f4f..30188f4fae022 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi8/hw.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/hw.c

[ ... ]

> @@ -152,6 +155,72 @@ static const struct ath12k_hw_params ath12k_wifi8_hw_params[] = {
>  	},
>  };
>  
> +static void ath12k_wifi8_mac_op_tx(struct ieee80211_hw *hw,
> +				   struct ieee80211_tx_control *control,
> +				   struct sk_buff *skb)
> +{
> +	struct ath12k_hw *ah = ath12k_hw_to_ah(hw);
> +
> +	__ath12k_warn(ah->dev, "wifi8: tx stub is a placeholder, dropping frame\n");
> +	ieee80211_free_txskb(hw, skb);
> +}
> +
> +static const struct ieee80211_ops ath12k_ops_wifi8 = {
> +	.tx				= ath12k_wifi8_mac_op_tx,
> +	.wake_tx_queue			= ieee80211_handle_wake_tx_queue,
> +	.start				= ath12k_mac_op_start,
> +	.stop				= ath12k_mac_op_stop,
> +	.reconfig_complete		= ath12k_mac_op_reconfig_complete,
> +	.add_interface			= ath12k_mac_op_add_interface,
> +	.remove_interface		= ath12k_mac_op_remove_interface,
> +	.update_vif_offload		= ath12k_mac_op_update_vif_offload,
> +	.link_info_changed		= ath12k_mac_op_link_info_changed,
> +	.vif_cfg_changed		= ath12k_mac_op_vif_cfg_changed,
> +	.change_vif_links		= ath12k_mac_op_change_vif_links,
> +	.configure_filter		= ath12k_mac_op_configure_filter,
> +	.hw_scan			= ath12k_mac_op_hw_scan,
> +	.cancel_hw_scan			= ath12k_mac_op_cancel_hw_scan,
> +	.set_key			= ath12k_mac_op_set_key,
> +	.set_rekey_data			= ath12k_mac_op_set_rekey_data,
> +	.sta_state			= ath12k_mac_op_sta_state,
> +	.sta_set_txpwr			= ath12k_mac_op_sta_set_txpwr,
> +	.link_sta_rc_update		= ath12k_mac_op_link_sta_rc_update,
> +	.conf_tx			= ath12k_mac_op_conf_tx,

[Severity: Medium]
Should ath12k_ops_wifi8 also wire .sta_set_4addr to
ath12k_mac_op_sta_set_4addr like ath12k_ops_wifi7 does?

The other shared callbacks here (ath12k_mac_op_update_vif_offload() and
ath12k_mac_op_add_interface()) enable IEEE80211_OFFLOAD_ENCAP_4ADDR and
WMI_VDEV_PARAM_WDS on 4-address interfaces, but without .sta_set_4addr,
drv_sta_set_4addr() is a no-op and never configures WMI_PEER_USE_4ADDR or
peer->dp_peer->use_4addr when a 4-address station associates.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-wifi8_qcn9575_bringup-v1-0-3f30fbc2bb69@oss.qualcomm.com?part=14