From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm8150: Fix missing wake-gpios in PCI
Date: Thu, 12 Nov 2026 12:08:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-211070@kernel.org> (raw)
In-Reply-To: <20261112120030.99510-4-krzysztof.kozlowski@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: sm8150: pcie1 wake-gpios uses
GPIO_ACTIVE_HIGH polarity
--
commit 809c46a66ec46c6ef99060dec4a500e026dc122f
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
arm64: dts: qcom: sm8150: Fix missing wake-gpios in PCI
This commit replaces the unused enable-gpio property on pcie1 with a
wake-gpios property in its pcie@0 root port node.
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index b9846b424a938..d667e38914519 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -2028,8 +2028,6 @@ pcie1: pcie@1c08000 {
>
> power-domains = <&gcc PCIE_1_GDSC>;
>
> - enable-gpio = <&tlmm 104 GPIO_ACTIVE_HIGH>;
> -
> pinctrl-names = "default";
> pinctrl-0 = <&pcie1_default_state>;
>
> @@ -2042,6 +2040,7 @@ pcie@0 {
>
> phys = <&pcie1_phy>;
> reset-gpios = <&tlmm 102 GPIO_ACTIVE_HIGH>;
> + wake-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>;
[Severity: Medium]
Should wake-gpios use GPIO_ACTIVE_LOW here, matching pcie0 after commit
463d931d6a66 ("arm64: dts: qcom: sm8150: Fix PCIe WAKE# GPIO polarity")?
PCIe WAKE# is active-low and pcie1_default_state configures gpio104 with
bias-pull-up. With GPIO_ACTIVE_HIGH, pci_configure_wake_irq() requests the
wake interrupt as IRQ_TYPE_LEVEL_HIGH, which triggers immediately while the
pulled-up WAKE# line is idle during suspend.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112120030.99510-3-krzysztof.kozlowski@oss.qualcomm.com?part=2
prev parent reply other threads:[~2026-11-12 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 12:00 [PATCH v2 1/2] arm64: dts: qcom: msm8937: Fix CPU4 thermal trip point type Krzysztof Kozlowski
2026-11-12 12:00 ` [PATCH v2 2/2] arm64: dts: qcom: sm8150: Fix missing wake-gpios in PCI Krzysztof Kozlowski
2026-11-12 12:08 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211070@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox