From: sashiko-bot@kernel.org
To: "Sushrut Shree Trivedi" <sushrut.trivedi@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Disable PCIe ASPM L1ss
Date: Thu, 12 Nov 2026 16:50:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-211537@kernel.org> (raw)
In-Reply-To: <20261112-rb3gen2_disable_l1ss-v1-1-aeefbf366595@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: qcs6490-rb3gen2: missing Fixes trailer for
TC9563 L1ss fix
--
commit 9d5417f567397369628afe2e5d17be0a24757085
Author: Sushrut Shree Trivedi <sushrut.trivedi@oss.qualcomm.com>
> arm64: dts: qcom: qcs6490-rb3gen2: Disable PCIe ASPM L1ss
>
> On the QCS6490 RB3gen2 platform, there is no mechanism for the
> PCIe endpoints connected to TC9563 switch to assert #CLKREQ and
> initiate a L1ss exit on the upstream link between the PCIe1 RC and
> TC9563 upstream port. Hence, once the upstream link enters L1ss
> and the Renesas uPD720201 endpoint connected to the switch downstream
> port tries to initiate an L1 exit, a link down is seen. This is
> expected because the upstream link is still in L1ss and PCIe refclk
> is cut-off.
>
> To avoid this issue, disable ASPM L1ss on the upstream link of TC9563
> switch to keep the PCIe refclk always on.
>
> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@oss.qualcomm.com>
[Severity: Low]
Since this fixes a PCIe link-down failure on the TC9563 switch upstream port,
should the commit message include a Fixes tag?
Fixes: aa7b4bbcb3a1 ("arm64: dts: qcom: qcs6490-rb3gen2: Add TC9563 PCIe switch node")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-rb3gen2_disable_l1ss-v1-1-aeefbf366595@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-11-12 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 16:40 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Disable PCIe ASPM L1ss Sushrut Shree Trivedi
2026-11-12 16:50 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211537@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sushrut.trivedi@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox