Re: [PATCH 1/5] dt-bindings: power: supply: add Qualcomm QGauge fuel gauge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: power: supply: qcom,qg: unconstrained nvmem and
  schema refs
--

commit 3e127648f3c0c46268041b3bde4ad7d6e88f27b3
Author: Marc Lainez <marc.lainez@gmail.com>

dt-bindings: power: supply: add Qualcomm QGauge fuel gauge

This commit adds the Device Tree binding schema for the Qualcomm QGauge fuel
gauge block on PMI632 and PM6150 PMICs and adds a corresponding MAINTAINERS
entry.

> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,qg.yaml b/Documentation/devicetree/bindings/power/supply/qcom,qg.yaml
> new file mode 100644
> index 0000000000000..79dd18d878793
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,qg.yaml
> @@ -0,0 +1,105 @@
[ ... ]
> +allOf:
> +  - $ref: /schemas/power/supply/power-supply.yaml#
> +  - $ref: /schemas/nvmem/nvmem-consumer.yaml#
[ ... ]
> +  monitored-battery: true
> +
> +  nvmem: true
> +
> +  power-supplies: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - monitored-battery
> +
> +additionalProperties: false

[Severity: Low]
Should nvmem specify maxItems: 1 instead of true, and should this binding
use unevaluatedProperties: false without referencing nvmem-consumer.yaml#
in allOf?

nvmem-consumer.yaml is a base consumer schema with select: true that
dtschema applies automatically, and it only constrains each nvmem entry to
a single phandle while leaving the outer array length to the device
binding.  Dropping nvmem-consumer.yaml# from allOf and switching
additionalProperties: false to unevaluatedProperties: false also avoids
having to redeclare monitored-battery and power-supplies from
power-supply.yaml#.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112170841.2189322-1-val@packett.cool?part=1