Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add Molokai TLMM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: pinctrl: qcom: inconsistent indentation in
  molokai-tlmm example
--

commit 422a3a1a2e538d8b4b4ceddc48ac192080f17ae8
Author: Venkat Yadlapati <venkat.yadlapati@yahoo.com>

dt-bindings: pinctrl: qcom: Add Molokai TLMM

This commit adds the Device Tree binding schema for the Top Level Mode
Multiplexer (TLMM) pin controller on the Qualcomm Molokai (SM8845) SoC.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,molokai-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,molokai-tlmm.yaml
> new file mode 100644
> index 0000000000000..9196902e37d6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,molokai-tlmm.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    tlmm: pinctrl@f100000 {
> +        compatible = "qcom,molokai-tlmm";
> +        reg = <0x0f100000 0x300000>;
> +        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +        gpio-ranges = <&tlmm 0 0 206>;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +
> +        qup-spi4-state {
> +          pins = "gpio48", "gpio49", "gpio50", "gpio51";
> +          function = "qup1_se4";
> +        };
> +    };

[Severity: Low]
Should the properties inside qup-spi4-state be indented by 4 spaces
relative to the child node instead of 2?  Mixing 4-space and 2-space
indentation in the example triggers an indent-consistent warning from
scripts/dtc/dt-check-style.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-molokai-tlmm-v1-0-3ba4840002cb@yahoo.com?part=1