Re: [PATCH 4/7] arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: amlogic: commit subject and message mismatch with
  modified nodes
--

commit d018b851d0b76ba5915a6bfa884a1b1c4be5d03e
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

> arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
>
> Building the amlogic DTBs with W=1 reports the following warnings
> for the periphs pinctrl node:
>
>   meson-g12-common.dtsi:271.33-1554.7: Warning (unit_address_vs_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: node has a unit name, but no
>   reg or ranges property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (unit_address_vs_reg):
>   /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
>   or ranges property
>   meson-g12-common.dtsi:271.33-1554.7: Warning (simple_bus_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: missing or empty reg/ranges
>   property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (simple_bus_reg):
>   /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
>   meson-g12-common.dtsi:2239.23-2279.6: Warning
>   (avoid_unnecessary_addr_size): /soc/bus@ffd00000/dsi@7000:
>   unnecessary #address-cells/#size-cells without "ranges", "dma-ranges"
>   or child "reg" or "ranges" property
>
> The pinctrl node has no reg property of its own, and its empty
> "ranges;" does not describe which address space is translated to the
> children
>
>   /soc/bus@ffd00000/dsi@7000: unnecessary #address-cells/#size-cells
>   without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> The DSI controller node has no child nodes with a reg property,
> so #address-cells and #size-cells serve no purpose. Remove them.
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

[Severity: Low]
This isn't a bug, but the commit subject and opening sentence only mention
the periphs_pinctrl node (pinctrl@40), whereas the patch also adds ranges to
ao_pinctrl (pinctrl@14) and removes #address-cells and #size-cells from the
unrelated mipi_dsi node (dsi@7000).

Should the mipi_dsi change be split into a separate commit (or reflected in
the subject alongside ao_pinctrl), and the duplicated dsi@7000 warning text
after the unpunctuated sentence ("...translated to the children") be cleaned
up?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-fix-amlogic-dt-warnings-v1-0-94cbd67a32ea@aliel.fr?part=4