From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH 3/7] arm64: dts: amlogic: axg: Add ranges to periphs pinctrl node
Date: Sun, 15 Nov 2026 22:38:57 +0000 [thread overview]
Message-ID: <sashiko-outbox-215883@kernel.org> (raw)
In-Reply-To: <20261115-fix-amlogic-dt-warnings-v1-3-94cbd67a32ea@aliel.fr>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: amlogic: axg: commit message omits aobus pinctrl and
explanation
--
commit df9ef90a65237fd0736035350fd16e31683b3d10
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>
> arm64: dts: amlogic: axg: Add ranges to periphs pinctrl node
>
> meson-axg.dtsi:360.33-1262.6: Warning (unit_address_vs_reg):
> /soc/bus@ff634000/pinctrl@480: node has a unit name, but no reg
> or ranges property
> meson-axg.dtsi:1609.30-1716.6: Warning (unit_address_vs_reg):
> /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
> or ranges property
> meson-axg.dtsi:360.33-1262.6: Warning (simple_bus_reg):
> /soc/bus@ff634000/pinctrl@480: missing or empty reg/ranges property
> meson-axg.dtsi:1609.30-1716.6: Warning (simple_bus_reg):
> /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
[Severity: Low]
This isn't a bug, but the commit subject only mentions the periphs pinctrl
node even though the patch also updates pinctrl_aobus (pinctrl@14). The
commit message body also consists only of the raw dtc warnings without
explaining why replacing the empty ranges properties with explicit address
ranges resolves them.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-fix-amlogic-dt-warnings-v1-0-94cbd67a32ea@aliel.fr?part=3
next prev parent reply other threads:[~2026-11-15 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 2/7] arm64: dts: amlogic: a1: " Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 3/7] arm64: dts: amlogic: axg: " Ronald Claveau via B4 Relay
2026-11-15 22:38 ` sashiko-bot [this message]
2026-11-15 22:29 ` [PATCH 4/7] arm64: dts: amlogic: g12: " Ronald Claveau via B4 Relay
2026-11-15 22:37 ` sashiko-bot
2026-11-15 22:29 ` [PATCH 5/7] arm64: dts: amlogic: gxbb: " Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 6/7] arm64: dts: amlogic: gxl: " Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 7/7] arm64: dts: amlogic: s4: " Ronald Claveau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215883@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel-dev@aliel.fr \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox