From: sashiko-bot@kernel.org
To: "Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: add Shikra PWM controller
Date: Mon, 16 Nov 2026 07:32:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-216434@kernel.org> (raw)
In-Reply-To: <20261116-pwm_qcom_shikra-v1-3-67ee4553adc5@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: shikra: pwm@4700000 left enabled by default in
SoC dtsi
--
commit eea458c9d44a72e60937665a306393bd7a4b77fd
Author: Taniya Das <taniya.das@oss.qualcomm.com>
arm64: dts: qcom: add Shikra PWM controller
This commit adds the PWM controller node and its ten frame child nodes
to the Shikra SoC DTSI.
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 0a95ad5a5582c..d8a3de38382bd 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -1303,6 +1303,69 @@ sram@4690000 {
> reg = <0x0 0x04690000 0x0 0x14000>;
> };
>
> + pwm: pwm@4700000 {
> + compatible = "qcom,shikra-pwm";
> + reg = <0x0 0x04700000 0x0 0x10>;
> + clocks = <&gcc GCC_PDM_AHB_CLK>, <&gcc GCC_PWM0_XO512_CLK>;
> + clock-names = "ahb", "core";
> + assigned-clocks = <&gcc GCC_PWM0_XO512_CLK>;
> + assigned-clock-rates = <9600000>;
> + #pwm-cells = <3>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + pwm@4701000 {
> + reg = <0x0 0x04701000 0x0 0x1c>;
> + qcom,frame-index = <0>;
> + };
[Severity: Low]
Should pwm@4700000 and its frame child nodes default to status = "disabled"
(with labels on the child nodes)?
Leaving them enabled in the SoC DTSI causes qcom_pwm_probe() to run on
every Shikra board, mapping all ten frames, enabling the PWM clocks, and
clearing all ten channel enable bits in PWM_TOPCTL0 even on boards that do
not wire up PWM. Without labels and status = "disabled" on the frame child
nodes, board files also cannot selectively enable only the frames they use,
which qcom_pwm_parse_dt() checks via for_each_available_child_of_node().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pwm_qcom_shikra-v1-0-67ee4553adc5@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-11-16 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 6:59 [PATCH 0/3] pwm: qcom: add Shikra PWM controller Taniya Das
2026-11-16 6:59 ` [PATCH 1/3] dt-bindings: " Taniya Das
2026-11-16 7:22 ` sashiko-bot
2026-11-16 6:59 ` [PATCH 2/3] pwm: qcom: add Shikra PWM controller support Taniya Das
2026-11-16 7:29 ` sashiko-bot
2026-11-16 6:59 ` [PATCH 3/3] arm64: dts: qcom: add Shikra PWM controller Taniya Das
2026-11-16 7:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216434@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox