Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yanli Yang" <yanli.yang@bedmex.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH wireless-next v5 1/4] dt-bindings: net: wireless: Add AIC8800D80 SDIO Wi-Fi
Date: Mon, 16 Nov 2026 07:35:07 +0000	[thread overview]
Message-ID: <sashiko-outbox-216440@kernel.org> (raw)
In-Reply-To: <179481380235.4.9476425206200425967@bedmex.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: wireless: duplicate GPIO pin in aic8800d80
  example
--

commit b667af697cde7fb1ec4d5589a84fc742a4bcc924
Author: Zhirun Liu <zhirunliu@aicsemi.com>

dt-bindings: net: wireless: Add AIC8800D80 SDIO Wi-Fi

This commit adds the Device Tree binding schema for the AICSemi AIC8800D80
and AIC8800D80N SDIO Wi-Fi function and registers the aicsemi vendor prefix.

> diff --git a/Documentation/devicetree/bindings/net/wireless/aicsemi,aic8800d80-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/aicsemi,aic8800d80-fmac.yaml
> new file mode 100644
> index 0000000000000..f9ad3cd6e07cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/aicsemi,aic8800d80-fmac.yaml
> @@ -0,0 +1,78 @@

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    mmc {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        wifi@1 {
> +            compatible = "aicsemi,aic8800d80-fmac";
> +            reg = <1>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <18 IRQ_TYPE_LEVEL_HIGH>;
> +            interrupt-names = "host-wakeup";
> +            device-wakeup-gpios = <&gpio1 18 GPIO_ACTIVE_HIGH>;
> +        };
> +    };

[Severity: Low]
Should interrupts and device-wakeup-gpios use two different pins on gpio1
in this example?  Here the WIFI_WAKE_HOST input interrupt and the
HOST_WAKE_WIFI output GPIO are both assigned to pin 18 on gpio1.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179481380235.4.7388336477392853157@bedmex.com?part=1

  reply	other threads:[~2026-11-16  7:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:23 [PATCH wireless-next v5 0/4] wifi: aic: Add AIC8800D80 and D80N SDIO FullMAC driver Yanli Yang
2026-11-16  7:23 ` [PATCH wireless-next v5 4/4] wifi: aic: Integrate the AIC8800 SDIO driver Yanli Yang
2026-11-16  7:48   ` sashiko-bot
2026-11-16  7:23 ` [PATCH wireless-next v5 1/4] dt-bindings: net: wireless: Add AIC8800D80 SDIO Wi-Fi Yanli Yang
2026-11-16  7:35   ` sashiko-bot [this message]
2026-11-16  7:23 ` [PATCH wireless-next v5 2/4] wifi: aic: Add firmware protocol and SDIO chip support Yanli Yang
2026-11-16  7:23 ` [PATCH wireless-next v5 3/4] wifi: aic: Add the AIC8800D80 and D80N FullMAC driver Yanli Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216440@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yanli.yang@bedmex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox