Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alain Volmat" <alain.volmat@foss.st.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk
Date: Mon, 16 Nov 2026 10:42:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-216753@kernel.org> (raw)
In-Reply-To: <20261116-stm32mp-imx335-fix-v1-1-01f538260f00@foss.st.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: st: missing Fixes trailer for commit 95ae2aa3caf0
--

commit ac59200a8a81d828de4ac31a7acb35a1002f80fb
Author: Alain Volmat <alain.volmat@foss.st.com>

> arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk
>
> The imx335 reset gpio is connected to the sensor reset via an RC hence
> a delay is needed in order to take into account the time needed to
> reach the level for which the sensor sees the correct level.
> This prevent having imx335 power-on issues due to the fact that the
> driver is trying to access to the sensor while the reset hasn't been
> yet properly handled.
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>

[Severity: Low]
This fixes imx335 power-on failures on stm32mp257f-dk.  Should the commit
message include a Fixes tag for the commit that added the imx335 node with a
direct reset-gpios connection:

  Fixes: 95ae2aa3caf0 ("arm64: dts: st: add imx335/csi/dcmipp nodes on stm32mp257f-dk")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-stm32mp-imx335-fix-v1-0-01f538260f00@foss.st.com?part=1

  reply	other threads:[~2026-11-16 10:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:31 [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x Alain Volmat
2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
2026-11-16 10:42   ` sashiko-bot [this message]
2026-11-16 10:31 ` [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1 Alain Volmat
2026-11-16 10:37   ` sashiko-bot
2026-11-16 10:31 ` [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk Alain Volmat
2026-11-16 10:38   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216753@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alain.volmat@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox