From: sashiko-bot@kernel.org
To: "Alain Volmat" <alain.volmat@foss.st.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1
Date: Mon, 16 Nov 2026 10:37:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-216747@kernel.org> (raw)
In-Reply-To: <20261116-stm32mp-imx335-fix-v1-2-01f538260f00@foss.st.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: st: missing Fixes trailer for imx335 reset delay fix
--
commit d05cafa7e3f2f1d1ef9b09227251c4bdc48b52a8
Author: Alain Volmat <alain.volmat@foss.st.com>
> arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1
>
> The imx335 reset gpio is connected to the sensor reset via an RC hence
> a delay is needed in order to take into account the time needed to
> reach the level for which the sensor sees the correct level.
> This prevent having imx335 power-on issues due to the fact that the
> driver is trying to access to the sensor while the reset hasn't been
> yet properly handled.
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
[Severity: Low]
This fixes imx335 power-on failures on stm32mp257f-ev1. Should it
include:
Fixes: 8df9bff27889 ("arm64: dts: st: enable imx335/csi/dcmipp pipeline on stm32mp257f-ev1")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-stm32mp-imx335-fix-v1-0-01f538260f00@foss.st.com?part=2
next prev parent reply other threads:[~2026-11-16 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:31 [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x Alain Volmat
2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
2026-11-16 10:42 ` sashiko-bot
2026-11-16 10:31 ` [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1 Alain Volmat
2026-11-16 10:37 ` sashiko-bot [this message]
2026-11-16 10:31 ` [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk Alain Volmat
2026-11-16 10:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216747@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox