Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x
@ 2026-11-16 10:31 Alain Volmat
  2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Alain Volmat @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel,
	Alain Volmat

The IMX335 sensor used on stm32mp2x boards has its reset line connected
to an RC, leading to the need for an additional delay when controlling
the sensor.
Add a gpio-delay node for this reset line in order to cop with that.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
Alain Volmat (3):
      arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk
      arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1
      arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk

 arch/arm64/boot/dts/st/stm32mp235f-dk.dts  | 9 ++++++++-
 arch/arm64/boot/dts/st/stm32mp257f-dk.dts  | 9 ++++++++-
 arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 9 ++++++++-
 3 files changed, 24 insertions(+), 3 deletions(-)
---
base-commit: 3cebbcae3ae383e63f62cd033a2b14a9140e0eb9
change-id: 20261112-stm32mp-imx335-fix-e3ec6c41486d

Best regards,
--  
Alain Volmat <alain.volmat@foss.st.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk
  2026-11-16 10:31 [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x Alain Volmat
@ 2026-11-16 10:31 ` Alain Volmat
  2026-11-16 10:42   ` sashiko-bot
  2026-11-16 10:31 ` [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1 Alain Volmat
  2026-11-16 10:31 ` [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk Alain Volmat
  2 siblings, 1 reply; 7+ messages in thread
From: Alain Volmat @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel,
	Alain Volmat

The imx335 reset gpio is connected to the sensor reset via an RC hence
a delay is needed in order to take into account the time needed to
reach the level for which the sensor sees the correct level.
This prevent having imx335 power-on issues due to the fact that the
driver is trying to access to the sensor while the reset hasn't been
yet properly handled.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp257f-dk.dts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts
index a8f18508db3e..ce7bb4a4d9a7 100644
--- a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts
+++ b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts
@@ -76,6 +76,13 @@ led-orange {
 		};
 	};
 
+	imx335_reset_delay: imx335-reset-delay {
+		compatible = "gpio-delay";
+		#gpio-cells = <3>;
+		gpio-controller;
+		gpios = <&gpiob 1 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+	};
+
 	lpddr_channel: sdram-channel-0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
@@ -236,7 +243,7 @@ imx335: camera@1a {
 		avdd-supply = <&scmi_v3v3>;
 		ovdd-supply = <&scmi_v3v3>;
 		dvdd-supply = <&scmi_v3v3>;
-		reset-gpios = <&gpiob 1 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+		reset-gpios = <&imx335_reset_delay 0 1000 1000>;
 
 		port {
 			imx335_ep: endpoint {

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1
  2026-11-16 10:31 [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x Alain Volmat
  2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
@ 2026-11-16 10:31 ` Alain Volmat
  2026-11-16 10:37   ` sashiko-bot
  2026-11-16 10:31 ` [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk Alain Volmat
  2 siblings, 1 reply; 7+ messages in thread
From: Alain Volmat @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel,
	Alain Volmat

The imx335 reset gpio is connected to the sensor reset via an RC hence
a delay is needed in order to take into account the time needed to
reach the level for which the sensor sees the correct level.
This prevent having imx335 power-on issues due to the fact that the
driver is trying to access to the sensor while the reset hasn't been
yet properly handled.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
index 782b4bb843ee..f40ae2293b3e 100644
--- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
+++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
@@ -73,6 +73,13 @@ ddr_channel: sdram-channel-0 {
 		io-width = <32>;
 	};
 
+	imx335_reset_delay: imx335-reset-delay {
+		compatible = "gpio-delay";
+		#gpio-cells = <3>;
+		gpio-controller;
+		gpios = <&gpioi 7 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+	};
+
 	memory@80000000 {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x1 0x0>;
@@ -259,7 +266,7 @@ imx335: camera@1a {
 		avdd-supply = <&scmi_v3v3>;
 		ovdd-supply = <&scmi_v3v3>;
 		dvdd-supply = <&scmi_v3v3>;
-		reset-gpios = <&gpioi 7 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+		reset-gpios = <&imx335_reset_delay 0 1000 1000>;
 
 		port {
 			imx335_ep: endpoint {

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk
  2026-11-16 10:31 [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x Alain Volmat
  2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
  2026-11-16 10:31 ` [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1 Alain Volmat
@ 2026-11-16 10:31 ` Alain Volmat
  2026-11-16 10:38   ` sashiko-bot
  2 siblings, 1 reply; 7+ messages in thread
From: Alain Volmat @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel,
	Alain Volmat

The imx335 reset gpio is connected to the sensor reset via an RC hence
a delay is needed in order to take into account the time needed to
reach the level for which the sensor sees the correct level.
This prevent having imx335 power-on issues due to the fact that the
driver is trying to access to the sensor while the reset hasn't been
yet properly handled.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp235f-dk.dts | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts
index f06b334dc9ce..137bed62b2ad 100644
--- a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts
+++ b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts
@@ -74,6 +74,13 @@ led-orange {
 		};
 	};
 
+	imx335_reset_delay: imx335-reset-delay {
+		compatible = "gpio-delay";
+		#gpio-cells = <3>;
+		gpio-controller;
+		gpios = <&gpiob 1 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+	};
+
 	memory@80000000 {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x0 0x80000000>;
@@ -227,7 +234,7 @@ imx335: camera@1a {
 		avdd-supply = <&scmi_v3v3>;
 		ovdd-supply = <&scmi_v3v3>;
 		dvdd-supply = <&scmi_v3v3>;
-		reset-gpios = <&gpiob 1 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
+		reset-gpios = <&imx335_reset_delay 0 1000 1000>;
 		status = "okay";
 
 		port {

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1
  2026-11-16 10:31 ` [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1 Alain Volmat
@ 2026-11-16 10:37   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-16 10:37 UTC (permalink / raw)
  To: Alain Volmat; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: st: missing Fixes trailer for imx335 reset delay fix
--

commit d05cafa7e3f2f1d1ef9b09227251c4bdc48b52a8
Author: Alain Volmat <alain.volmat@foss.st.com>

> arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1
>
> The imx335 reset gpio is connected to the sensor reset via an RC hence
> a delay is needed in order to take into account the time needed to
> reach the level for which the sensor sees the correct level.
> This prevent having imx335 power-on issues due to the fact that the
> driver is trying to access to the sensor while the reset hasn't been
> yet properly handled.
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>

[Severity: Low]
This fixes imx335 power-on failures on stm32mp257f-ev1.  Should it
include:

  Fixes: 8df9bff27889 ("arm64: dts: st: enable imx335/csi/dcmipp pipeline on stm32mp257f-ev1")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-stm32mp-imx335-fix-v1-0-01f538260f00@foss.st.com?part=2

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk
  2026-11-16 10:31 ` [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk Alain Volmat
@ 2026-11-16 10:38   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-16 10:38 UTC (permalink / raw)
  To: Alain Volmat; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: st: missing Fixes trailer for stm32mp235f-dk imx335
  reset fix
--

commit e39cf6eb1245597509df9656ea0556ed7e9c75ba
Author: Alain Volmat <alain.volmat@foss.st.com>

> arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk
>
> The imx335 reset gpio is connected to the sensor reset via an RC hence
> a delay is needed in order to take into account the time needed to
> reach the level for which the sensor sees the correct level.
> This prevent having imx335 power-on issues due to the fact that the
> driver is trying to access to the sensor while the reset hasn't been
> yet properly handled.
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>

[Severity: Low]
Since this fixes imx335 camera sensor power-on failures on stm32mp235f-dk,
should the commit message include:

  Fixes: ed9056f9a042 ("arm64: dts: st: add imx335/csi/dcmipp nodes on stm32mp235f-dk")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-stm32mp-imx335-fix-v1-0-01f538260f00@foss.st.com?part=3

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk
  2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
@ 2026-11-16 10:42   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-16 10:42 UTC (permalink / raw)
  To: Alain Volmat; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: st: missing Fixes trailer for commit 95ae2aa3caf0
--

commit ac59200a8a81d828de4ac31a7acb35a1002f80fb
Author: Alain Volmat <alain.volmat@foss.st.com>

> arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk
>
> The imx335 reset gpio is connected to the sensor reset via an RC hence
> a delay is needed in order to take into account the time needed to
> reach the level for which the sensor sees the correct level.
> This prevent having imx335 power-on issues due to the fact that the
> driver is trying to access to the sensor while the reset hasn't been
> yet properly handled.
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>

[Severity: Low]
This fixes imx335 power-on failures on stm32mp257f-dk.  Should the commit
message include a Fixes tag for the commit that added the imx335 node with a
direct reset-gpios connection:

  Fixes: 95ae2aa3caf0 ("arm64: dts: st: add imx335/csi/dcmipp nodes on stm32mp257f-dk")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-stm32mp-imx335-fix-v1-0-01f538260f00@foss.st.com?part=1

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-16 10:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 10:31 [PATCH 0/3] arm64: dts: st: add gpio-delay for imx335 sensor control on stm32mp2x Alain Volmat
2026-11-16 10:31 ` [PATCH 1/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-dk Alain Volmat
2026-11-16 10:42   ` sashiko-bot
2026-11-16 10:31 ` [PATCH 2/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp257f-ev1 Alain Volmat
2026-11-16 10:37   ` sashiko-bot
2026-11-16 10:31 ` [PATCH 3/3] arm64: dts: st: add delay on imx335 reset gpio on stm32mp235f-dk Alain Volmat
2026-11-16 10:38   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox