* [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 22:55 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator erebion
` (10 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion, Luca Weiss
Add a node for the camera flash LED found on the Xperia 10 III
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: erebion <erebion@erebion.eu>
---
.../boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 6e2bbf4f060ac..4d78c500d00d3 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -4,9 +4,11 @@
*/
/dts-v1/;
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sm6350.dtsi"
+#include "pm6150l.dtsi"
#include "pm6350.dtsi"
/ {
@@ -302,6 +304,19 @@ touchscreen@48 {
};
};
+&pm6150l_flash {
+ status = "okay";
+
+ led-0 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>;
+ led-max-microamp = <150000>;
+ flash-max-microamp = <1000000>;
+ flash-max-timeout-us = <1280000>;
+ };
+};
+
&pm6350_gpios {
vol_down_n: vol-down-n-state {
pins = "gpio2";
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED
2026-11-16 22:50 ` [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED erebion
@ 2026-11-16 22:55 ` sashiko-bot
2026-11-16 23:04 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 22:55 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: username handle used in Signed-off-by and
Author fields
--
commit 200bfc01220f58fe7a2271ce6cb6b0cc0d743227
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Add flash LED
>
> Add a node for the camera flash LED found on the Xperia 10 III
>
> Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
As reported by Bjorn Andersson on v2 [1], the Author and Signed-off-by
fields use the single-word handle "erebion" instead of a real human name,
which does not satisfy the Developer's Certificate of Origin requirements
in Documentation/process/submitting-patches.rst.
[1] https://lore.kernel.org/r/arnF0u2F9ipfnNP-@zenbook
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=1
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED
2026-11-16 22:55 ` sashiko-bot
@ 2026-11-16 23:04 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:04 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 626 bytes --]
> [Severity: High]
> As reported by Bjorn Andersson on v2 [1], the Author and Signed-off-by
> fields use the single-word handle "erebion" instead of a real human name,
> which does not satisfy the Developer's Certificate of Origin requirements
> in Documentation/process/submitting-patches.rst.
>
> [1] https://lore.kernel.org/r/arnF0u2F9ipfnNP-@zenbook
>
And as Luca Weiss pointed out, there is no issue.
Please, can someone finally stop the bot from saying the same for every
single commit..?
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
2026-11-16 22:50 ` [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 22:55 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node erebion
` (9 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion, Luca Weiss
rename touch-en-regulator -> regulator-touch-en, to
keep any future fixed-regulator sorted together
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: erebion <erebion@erebion.eu>
---
arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 4d78c500d00d3..ca44219e1a67d 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -46,7 +46,7 @@ key-volume-down {
};
};
- touch_en_vreg: touch-en-regulator {
+ touch_en_vreg: regulator-touch-en {
compatible = "regulator-fixed";
regulator-name = "touch_en_vreg";
gpio = <&tlmm 10 GPIO_ACTIVE_HIGH>;
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator
2026-11-16 22:50 ` [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator erebion
@ 2026-11-16 22:55 ` sashiko-bot
2026-11-16 23:06 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 22:55 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: single-word handle used in Signed-off-by
trailer
--
commit 32e61d61a3221dfc85f81717ef77d401f268134b
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: rename touch-en-regulator
>
> rename touch-en-regulator -> regulator-touch-en, to
> keep any future fixed-regulator sorted together
>
> Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
Could the Author header and Signed-off-by trailer be updated to use a full
real human name instead of the single-word handle "erebion"? Per
Documentation/process/submitting-patches.rst, the Developer's Certificate
of Origin requires a known real name and does not permit pseudonyms or
handles.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=2
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator
2026-11-16 22:55 ` sashiko-bot
@ 2026-11-16 23:06 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:06 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 398 bytes --]
On 11/16/26 23:55, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: single-word handle used in Signed-off-by
> trailer
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
2026-11-16 22:50 ` [PATCH v5 01/12] arm64: dts: qcom: sm6350-lena: Add flash LED erebion
2026-11-16 22:50 ` [PATCH v5 02/12] arm64: dts: qcom: sm6350-lena: rename touch-en-regulator erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 22:55 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS erebion
` (8 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion, Luca Weiss, Konrad Dybcio
Adds the qcom,rmtfs-mem node required for the modem
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: erebion <erebion@erebion.eu>
---
arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index ca44219e1a67d..a393b7533ccbf 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -4,6 +4,7 @@
*/
/dts-v1/;
+#include <dt-bindings/firmware/qcom,scm.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -54,6 +55,17 @@ touch_en_vreg: regulator-touch-en {
vin-supply = <&pm6350_l6>;
};
+
+ reserved-memory {
+ memory@fe901000 {
+ compatible = "qcom,rmtfs-mem";
+ reg = <0x0 0xfe901000 0x0 0x280000>;
+ no-map;
+
+ qcom,client-id = <1>;
+ qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
+ };
+ };
};
&apps_rsc {
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node
2026-11-16 22:50 ` [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node erebion
@ 2026-11-16 22:55 ` sashiko-bot
2026-11-16 23:06 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 22:55 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: sm6350-lena: Signed-off-by uses handle
instead of real name
--
commit 22ff41be0c77265e49ea053288034f41745039c3
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node
>
> Adds the qcom,rmtfs-mem node required for the modem
>
> Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
The Author header and Signed-off-by trailer use a single-word handle
("erebion") instead of a real human name. Under the Developer's
Certificate of Origin in Documentation/process/submitting-patches.rst,
patches must be authored and signed off using a known real name rather
than a pseudonym or handle.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=3
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node
2026-11-16 22:55 ` sashiko-bot
@ 2026-11-16 23:06 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:06 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 411 bytes --]
On 11/16/26 23:55, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: sm6350-lena: Signed-off-by uses handle
> instead of real name
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (2 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 03/12] arm64: dts: qcom: sm6350-lena: Add qcom,rmtfs-mem node erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 22:56 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth erebion
` (7 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion
Enable the ADSP, CDSP, IPA and MPSS (Modem) nodes for the Xperia 10 III.
Signed-off-by: erebion <erebion@erebion.eu>
---
.../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index a393b7533ccbf..e8808865bf6fa 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -68,6 +68,12 @@ memory@fe901000 {
};
};
+&adsp {
+ firmware-name = "qcom/sm6350/Sony/lena/adsp.mbn";
+
+ status = "okay";
+};
+
&apps_rsc {
regulators-0 {
compatible = "qcom,pm6350-rpmh-regulators";
@@ -291,6 +297,12 @@ pm6150l_bob: bob {
};
};
+&cdsp {
+ firmware-name = "qcom/sm6350/Sony/lena/cdsp.mbn";
+
+ status = "okay";
+};
+
&gpi_dma0 {
status = "okay";
};
@@ -316,6 +328,18 @@ touchscreen@48 {
};
};
+&ipa {
+ firmware-name = "qcom/sm6350/Sony/lena/ipa_fws.mbn";
+
+ status = "okay";
+};
+
+&mpss {
+ firmware-name = "qcom/sm6350/Sony/lena/modem.mbn";
+
+ status = "okay";
+};
+
&pm6150l_flash {
status = "okay";
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS
2026-11-16 22:50 ` [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS erebion
@ 2026-11-16 22:56 ` sashiko-bot
2026-11-16 23:06 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 22:56 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Signed-off-by uses handle erebion instead of
real name
--
commit 1d93b9305fce0e29369cefb160a67dae64e8d0d8
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS
>
> Enable the ADSP, CDSP, IPA and MPSS (Modem) nodes for the Xperia 10 III.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
The Author and Signed-off-by lines use the handle "erebion" rather than a
real name, which does not meet the Developer's Certificate of Origin
requirements in Documentation/process/submitting-patches.rst. Could this
be updated to use a full legal name?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=4
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS
2026-11-16 22:56 ` sashiko-bot
@ 2026-11-16 23:06 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:06 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]
On 11/16/26 23:56, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: Signed-off-by uses handle erebion instead of
> real name
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (3 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 23:11 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi erebion
` (6 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion
Configure the required regulators for Bluetooth and enable it on the
Xperia 10 III.
Signed-off-by: erebion <erebion@erebion.eu>
---
.../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 96 ++++++++++++++++++++++
1 file changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index e8808865bf6fa..12bf5420530d3 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -19,6 +19,10 @@ / {
qcom,msm-id = <434 0x10000>, <459 0x10000>;
qcom,board-id = <0x1000b 0>;
+ aliases {
+ serial1 = &uart1;
+ };
+
chosen {
#address-cells = <2>;
#size-cells = <2>;
@@ -376,6 +380,32 @@ &qupv3_id_1 {
status = "okay";
};
+/* UART1: HS UART for Bluetooth */
+&qup_uart1_rts {
+ /* We'll drive RTS, so no pull */
+ drive-strength = <2>;
+ /delete-property/ bias-pull-down;
+ bias-disable;
+};
+
+&qup_uart1_rx {
+ /*
+ * Configure a pull-up on RX. This is needed to avoid
+ * garbage data when the TX pin of the Bluetooth module is
+ * in tri-state (module powered off or not driving the
+ * signal yet).
+ */
+ /delete-property/ bias-disable;
+ bias-pull-up;
+};
+
+&qup_uart1_tx {
+ /* We'll drive TX, so no pull */
+ drive-strength = <2>;
+ /delete-property/ bias-pull-up;
+ bias-disable;
+};
+
&sdc2_off_state {
sd-cd-pins {
pins = "gpio94";
@@ -419,6 +449,72 @@ ts_int_default: ts-int-default-state {
drive-strength = <2>;
bias-disable;
};
+
+ qup_uart1_sleep_cts: qup-uart1-sleep-cts-state {
+ pins = "gpio61";
+ function = "gpio";
+ /*
+ * Configure a bias-bus-hold on CTS to lower power
+ * usage when Bluetooth is turned off. Bus hold will
+ * maintain a low power state regardless of whether
+ * the Bluetooth module drives the pin in either
+ * direction or leaves the pin fully unpowered.
+ */
+ bias-bus-hold;
+ };
+
+ qup_uart1_sleep_rts: qup-uart1-sleep-rts-state {
+ pins = "gpio62";
+ function = "gpio";
+ /*
+ * Configure pull-down on RTS. As RTS is active low
+ * signal, pull it low to indicate the BT SoC that it
+ * can wakeup the system anytime from suspend state by
+ * pulling RX low (by sending wakeup bytes).
+ */
+ bias-pull-down;
+ };
+
+ qup_uart1_sleep_rx: qup-uart1-sleep-rx-state {
+ pins = "gpio64";
+ function = "gpio";
+ /*
+ * Configure a pull-up on RX. This is needed to avoid
+ * garbage data when the TX pin of the Bluetooth module
+ * is floating which may cause spurious wakeups.
+ */
+ bias-pull-up;
+ };
+
+ qup_uart1_sleep_tx: qup-uart1-sleep-tx-state {
+ pins = "gpio63";
+ function = "gpio";
+ /*
+ * Configure pull-up on TX when it isn't actively driven
+ * to prevent BT SoC from receiving garbage during sleep.
+ */
+ bias-pull-up;
+ };
+};
+
+&uart1 {
+ /delete-property/ interrupts;
+ interrupts-extended = <&intc GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>,
+ <&tlmm 64 IRQ_TYPE_EDGE_FALLING>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-1 = <&qup_uart1_sleep_cts>, <&qup_uart1_sleep_rts>, <&qup_uart1_sleep_tx>, <&qup_uart1_sleep_rx>;
+
+ status = "okay";
+
+ bluetooth {
+ compatible = "qcom,wcn3991-bt";
+ vddio-supply = <&pm6350_l11>;
+ vddxo-supply = <&pm6350_l7>;
+ vddrf-supply = <&pm6150l_l2>;
+ vddch0-supply = <&pm6150l_l10>;
+ firmware-name = "crnv32u.bin";
+ };
};
&usb_1 {
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth
2026-11-16 22:50 ` [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth erebion
@ 2026-11-16 23:11 ` sashiko-bot
2026-11-16 23:17 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 23:11 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
of real name
--
commit 6f602bc892584af0dccb910664565f3b596a7794
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Enable Bluetooth
>
> Configure the required regulators for Bluetooth and enable it on the
> Xperia 10 III.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
The Author header and Signed-off-by trailer use a single-word handle
("erebion") rather than a full human name, which does not meet the
Developer's Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.
Also, the commit message says it configures the required regulators,
whereas the regulator nodes (pm6350_l11, pm6350_l7, pm6150l_l2, and
pm6150l_l10) are already defined in this file and the patch instead
configures UART1 with its pinctrl states and wires up the bluetooth child
node.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=5
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth
2026-11-16 23:11 ` sashiko-bot
@ 2026-11-16 23:17 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:17 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 408 bytes --]
On 11/17/26 00:11, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
> of real name
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (4 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 05/12] arm64: dts: qcom: sm6350-lena: Enable Bluetooth erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 22:56 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B erebion
` (5 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion, Luca Weiss, Konrad Dybcio
Configure regulators and enable it for the Xperia 10 III
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: erebion <erebion@erebion.eu>
---
arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 12bf5420530d3..9d880f6baa531 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -541,3 +541,13 @@ &usb_1_qmpphy {
status = "okay";
};
+
+&wifi {
+ vdd-0.8-cx-mx-supply = <&pm6350_l4>;
+ vdd-1.8-xo-supply = <&pm6350_l7>;
+ vdd-1.3-rfa-supply = <&pm6150l_l2>;
+ vdd-3.3-ch0-supply = <&pm6150l_l10>;
+ vdd-3.3-ch1-supply = <&pm6150l_l11>;
+
+ status = "okay";
+};
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi
2026-11-16 22:50 ` [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi erebion
@ 2026-11-16 22:56 ` sashiko-bot
2026-11-16 23:06 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 22:56 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
of real name
--
commit 69b3f383982805a38e5e9161e90e92403fe51a58
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Enable wifi
>
> Configure regulators and enable it for the Xperia 10 III
>
> Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
Could the Author header and Signed-off-by trailer be updated to use a
real human name instead of the handle "erebion"?
Documentation/process/submitting-patches.rst requires a real name for the
Developer's Certificate of Origin and does not allow pseudonyms or
handles.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=6
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi
2026-11-16 22:56 ` sashiko-bot
@ 2026-11-16 23:06 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:06 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 408 bytes --]
On 11/16/26 23:56, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
> of real name
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (5 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 06/12] arm64: dts: qcom: sm6350-lena: Enable wifi erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 23:06 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350 erebion
` (4 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion, Konrad Dybcio
Enable PM7250B and some components on it for the Xperia 10 III.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: erebion <erebion@erebion.eu>
---
.../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 48 ++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 9d880f6baa531..697e1cfae72e0 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -4,6 +4,10 @@
*/
/dts-v1/;
+/* PM7250B is configured to use SID2/3 */
+#define PM7250B_SID 2
+#define PM7250B_SID1 3
+
#include <dt-bindings/firmware/qcom,scm.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
@@ -11,6 +15,7 @@
#include "sm6350.dtsi"
#include "pm6150l.dtsi"
#include "pm6350.dtsi"
+#include "pm7250b.dtsi"
/ {
model = "Sony Xperia 10 III";
@@ -372,6 +377,49 @@ &pm6350_resin {
status = "okay";
};
+&pm7250b_adc {
+ channel@4d {
+ reg = <ADC5_AMUX_THM1_100K_PU>;
+ label = "charger_skin_therm";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+
+ channel@4f {
+ reg = <ADC5_AMUX_THM3_100K_PU>;
+ label = "conn_therm";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+};
+
+&pm7250b_adc_tm {
+ status = "okay";
+
+ charger-skin-therm@0 {
+ reg = <0>;
+ io-channels = <&pm7250b_adc ADC5_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ conn-therm@1 {
+ reg = <1>;
+ io-channels = <&pm7250b_adc ADC5_AMUX_THM3_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+};
+
+&pm7250b_vbus {
+ regulator-min-microamp = <500000>;
+ regulator-max-microamp = <1000000>;
+
+ status = "okay";
+};
+
&qupv3_id_0 {
status = "okay";
};
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B
2026-11-16 22:50 ` [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B erebion
@ 2026-11-16 23:06 ` sashiko-bot
2026-11-16 23:06 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 23:06 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Signed-off-by trailer uses handle instead of
real name
--
commit bce0793330bff87c0fe7378b4881d3cb7b3eea46
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Enable PM7250B
>
> Enable PM7250B and some components on it for the Xperia 10 III.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
Documentation/process/submitting-patches.rst requires a real human name in
the Author header and Signed-off-by trailer rather than a handle or
pseudonym ("erebion").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=7
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B
2026-11-16 23:06 ` sashiko-bot
@ 2026-11-16 23:06 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:06 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]
On 11/17/26 00:06, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: Signed-off-by trailer uses handle instead of
> real name
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (6 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 07/12] arm64: dts: qcom: sm6350-lena: Enable PM7250B erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 23:01 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals erebion
` (3 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion
Configure and enable nodes for PMK8350 on the Xperia 10 III.
The phone has two PMICs which have a PON block, disable the PMK8350
PON and keep the PM6350 PON, as only one should be enabled.
Signed-off-by: erebion <erebion@erebion.eu>
---
.../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 34 ++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 697e1cfae72e0..50a235d6fb6df 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -8,7 +8,11 @@
#define PM7250B_SID 2
#define PM7250B_SID1 3
+/* PMK8350 (in reality a PMK8003) is configured to use SID6 instead of 0 */
+#define PMK8350_SID 6
+
#include <dt-bindings/firmware/qcom,scm.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -16,6 +20,7 @@
#include "pm6150l.dtsi"
#include "pm6350.dtsi"
#include "pm7250b.dtsi"
+#include "pmk8350.dtsi"
/ {
model = "Sony Xperia 10 III";
@@ -420,6 +425,35 @@ &pm7250b_vbus {
status = "okay";
};
+&pmk8350_adc_tm {
+ status = "okay";
+
+ xo-therm@0 {
+ reg = <0>;
+ io-channels = <&pmk8350_vadc PMK8350_ADC7_AMUX_THM1_100K_PU>;
+ qcom,hw-settle-time-us = <200>;
+ qcom,ratiometric;
+ };
+};
+
+&pmk8350_pon {
+ status = "disabled";
+};
+
+&pmk8350_rtc {
+ status = "okay";
+};
+
+&pmk8350_vadc {
+ channel@644 {
+ reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;
+ label = "xo_therm";
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350
2026-11-16 22:50 ` [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350 erebion
@ 2026-11-16 23:01 ` sashiko-bot
2026-11-16 23:07 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 23:01 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: invalid handle in Signed-off-by trailer
--
commit 653bcdb19432d3b2792a7f5615a893fd67bfe22e
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Enable PMK8350
>
> Configure and enable nodes for PMK8350 on the Xperia 10 III.
>
> The phone has two PMICs which have a PON block, disable the PMK8350
> PON and keep the PM6350 PON, as only one should be enabled.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
Per Documentation/process/submitting-patches.rst, the Developer's
Certificate of Origin requires a real human name in the Author header
and Signed-off-by trailer rather than a single-word handle or username.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=8
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350
2026-11-16 23:01 ` sashiko-bot
@ 2026-11-16 23:07 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:07 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 383 bytes --]
On 11/17/26 00:01, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: invalid handle in Signed-off-by trailer
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (7 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 08/12] arm64: dts: qcom: sm6350-lena: Enable PMK8350 erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 23:03 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals erebion
` (2 subsequent siblings)
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion
Configure the thermals for the chg-skin-thermal and conn-therm thermistors connected to
PM7250B.
The trip points can really only be considered as placeholders, more
configuration with cooling etc. can be added later.
Signed-off-by: erebion <erebion@erebion.eu>
---
.../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 50a235d6fb6df..0bb714eed13f4 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -80,6 +80,32 @@ memory@fe901000 {
qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
};
};
+
+ thermal-zones {
+ chg-skin-thermal {
+ thermal-sensors = <&pm7250b_adc_tm 0>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ conn-thermal {
+ thermal-sensors = <&pm7250b_adc_tm 1>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+ };
};
&adsp {
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals
2026-11-16 22:50 ` [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals erebion
@ 2026-11-16 23:03 ` sashiko-bot
2026-11-16 23:07 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 23:03 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: handle used instead of real name in
Signed-off-by trailer
--
commit cb7d77f20d3e8fe16d92844a1db347a543c4c968
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Add PM7250B thermals
>
> Configure the thermals for the chg-skin-thermal and conn-therm thermistors connected to
> PM7250B.
>
> The trip points can really only be considered as placeholders, more
> configuration with cooling etc. can be added later.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
The Author header and Signed-off-by trailer use a handle ("erebion")
instead of a full real name. Under the Developer's Certificate of Origin
in Documentation/process/submitting-patches.rst, patches must be signed
off using a known identity (a real name, not a pseudonym or handle).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=9
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals
2026-11-16 23:03 ` sashiko-bot
@ 2026-11-16 23:07 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:07 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 407 bytes --]
On 11/17/26 00:03, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: handle used instead of real name in
> Signed-off-by trailer
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (8 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 09/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 23:00 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals erebion
2026-11-16 22:50 ` [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses erebion
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion
Configure the thermals for the xo-thermal thermistor connected to
PMK8350.
The trip points can really only be considered as placeholders, more
configuration with cooling etc. can be added later.
Signed-off-by: erebion <erebion@erebion.eu>
---
arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 0bb714eed13f4..b86fe11fd5296 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -105,6 +105,18 @@ active-config0 {
};
};
};
+
+ xo-thermal {
+ thermal-sensors = <&pmk8350_adc_tm 0>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals
2026-11-16 22:50 ` [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals erebion
@ 2026-11-16 23:00 ` sashiko-bot
2026-11-16 23:07 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 23:00 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Signed-off-by trailer uses handle instead of
real name
--
commit 740c0daeec4b7b67f69c91c933b4ac4150f59402
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals
>
> Configure the thermals for the xo-thermal thermistor connected to
> PMK8350.
>
> The trip points can really only be considered as placeholders, more
> configuration with cooling etc. can be added later.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
The Signed-off-by trailer and commit Author field use the single-word
handle "erebion" instead of a real name. Under the Developer's
Certificate of Origin in Documentation/process/submitting-patches.rst,
patches must be signed off using a known real-name identity rather than a
pseudonym or handle.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=10
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals
2026-11-16 23:00 ` sashiko-bot
@ 2026-11-16 23:07 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:07 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]
On 11/17/26 00:00, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: Signed-off-by trailer uses handle instead of
> real name
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (9 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 10/12] arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 23:02 ` sashiko-bot
2026-11-16 22:50 ` [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses erebion
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion
Configure the thermals for the PA_THERM1, MSM_THERM, PA_THERM0,
CAM_FLASH_THERM and QUIET_THERM thermistors connected to
PM6150L.
Due to hardware constraints we can only register 4 zones with
pm6150l_adc_tm, the other 2 we can register via generic-adc-thermal.
RFC_CAM_THERM is intentionally omitted for now and will have to be
added once it is clear how it should be added.
The trip points can really only be considered as placeholders, more
configuration with cooling etc. can be added later.
Signed-off-by: erebion <erebion@erebion.eu>
---
.../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 160 +++++++++++++++++++++
1 file changed, 160 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index b86fe11fd5296..b19e76b3c1a75 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -81,6 +81,13 @@ memory@fe901000 {
};
};
+ msm_therm_sensor: thermal-sensor-msm {
+ compatible = "generic-adc-thermal";
+ #thermal-sensor-cells = <0>;
+ io-channels = <&pm6150l_adc ADC5_AMUX_THM2_100K_PU>;
+ io-channel-names = "sensor-channel";
+ };
+
thermal-zones {
chg-skin-thermal {
thermal-sensors = <&pm7250b_adc_tm 0>;
@@ -106,6 +113,74 @@ active-config0 {
};
};
+ pa0-thermal {
+ thermal-sensors = <&pm6150l_adc_tm 1>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ pa1-thermal {
+ thermal-sensors = <&pm6150l_adc_tm 0>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ quiet-thermal {
+ thermal-sensors = <&pm6150l_adc_tm 3>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ rfc-flash-thermal {
+ thermal-sensors = <&pm6150l_adc_tm 2>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ sdm-skin-thermal {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&msm_therm_sensor>;
+
+ trips {
+ trip0 {
+ temperature = <45000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ trip1 {
+ temperature = <55000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+
xo-thermal {
thermal-sensors = <&pmk8350_adc_tm 0>;
@@ -392,6 +467,83 @@ &mpss {
status = "okay";
};
+&pm6150l_adc {
+ pinctrl-0 = <&pm6150l_adc_default>;
+ pinctrl-names = "default";
+
+ channel@4d {
+ reg = <ADC5_AMUX_THM1_100K_PU>;
+ label = "pa_therm1";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+
+ channel@4e {
+ reg = <ADC5_AMUX_THM2_100K_PU>;
+ label = "msm_therm";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+
+ channel@4f {
+ reg = <ADC5_AMUX_THM3_100K_PU>;
+ label = "pa_therm0";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+
+ channel@54 {
+ reg = <ADC5_GPIO3_100K_PU>;
+ label = "rear_cam_flash_therm";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+
+ channel@55 {
+ reg = <ADC5_GPIO4_100K_PU>;
+ label = "quiet_therm";
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ qcom,ratiometric;
+ };
+};
+
+&pm6150l_adc_tm {
+ status = "okay";
+
+ pa-therm1@0 {
+ reg = <0>;
+ io-channels = <&pm6150l_adc ADC5_AMUX_THM1_100K_PU>;
+ qcom,hw-settle-time-us = <200>;
+ qcom,ratiometric;
+ };
+
+ pa-therm0@1 {
+ reg = <1>;
+ io-channels = <&pm6150l_adc ADC5_AMUX_THM3_100K_PU>;
+ qcom,hw-settle-time-us = <200>;
+ qcom,ratiometric;
+ };
+
+ rear-cam-flash-therm@2 {
+ reg = <2>;
+ io-channels = <&pm6150l_adc ADC5_GPIO3_100K_PU>;
+ qcom,hw-settle-time-us = <200>;
+ qcom,ratiometric;
+ };
+
+ quiet-therm@3 {
+ reg = <3>;
+ io-channels = <&pm6150l_adc ADC5_GPIO4_100K_PU>;
+ qcom,hw-settle-time-us = <200>;
+ qcom,ratiometric;
+ };
+};
+
&pm6150l_flash {
status = "okay";
@@ -405,6 +557,14 @@ led-0 {
};
};
+&pm6150l_gpios {
+ pm6150l_adc_default: adc-default-state {
+ pins = "gpio7", "gpio10";
+ function = PMIC_GPIO_FUNC_NORMAL;
+ bias-high-impedance;
+ };
+};
+
&pm6350_gpios {
vol_down_n: vol-down-n-state {
pins = "gpio2";
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals
2026-11-16 22:50 ` [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals erebion
@ 2026-11-16 23:02 ` sashiko-bot
2026-11-16 23:07 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 23:02 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: sm6350-lena: handle used in Author and
Signed-off-by
--
commit d20fc6eadec7147c231c438c85d32c1e09b43db8
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: Add PM6150L thermals
>
> Configure the thermals for the PA_THERM1, MSM_THERM, PA_THERM0,
> CAM_FLASH_THERM and QUIET_THERM thermistors connected to
> PM6150L.
>
> Due to hardware constraints we can only register 4 zones with
> pm6150l_adc_tm, the other 2 we can register via generic-adc-thermal.
>
> RFC_CAM_THERM is intentionally omitted for now and will have to be
> added once it is clear how it should be added.
>
> The trip points can really only be considered as placeholders, more
> configuration with cooling etc. can be added later.
>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
Both the commit Author and the Signed-off-by trailer use the handle
"erebion" instead of a real human name, which does not meet the
Developer's Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=11
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals
2026-11-16 23:02 ` sashiko-bot
@ 2026-11-16 23:07 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:07 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]
On 11/17/26 00:02, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: sm6350-lena: handle used in Author and
> Signed-off-by
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses
2026-11-16 22:50 [PATCH v5 00/12] Enable more nodes for the Xperia 10 III erebion
` (10 preceding siblings ...)
2026-11-16 22:50 ` [PATCH v5 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals erebion
@ 2026-11-16 22:50 ` erebion
2026-11-16 22:59 ` sashiko-bot
11 siblings, 1 reply; 37+ messages in thread
From: erebion @ 2026-11-16 22:50 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, dri-devel, linux-arm-msm, devicetree, phone-devel,
erebion, Konrad Dybcio
Enable all i2c busses where something is connected on this phone. Add
comments as placeholders for which components are still missing.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: erebion <erebion@erebion.eu>
---
.../boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index b19e76b3c1a75..08647584af0ce 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -438,6 +438,13 @@ &gpi_dma1 {
status = "okay";
};
+&i2c0 {
+ clock-frequency = <400000>;
+ status = "okay";
+
+ /* PN553 NFC @ 28 */
+};
+
&i2c8 {
clock-frequency = <400000>;
status = "okay";
@@ -455,6 +462,17 @@ touchscreen@48 {
};
};
+&i2c10 {
+ clock-frequency = <400000>;
+ status = "okay";
+
+ /* PM8008 PMIC @ 8 and 9 */
+ /* SMB1395 PMIC @ 34 and 35 */
+ /* AW882xx amplifier @ 34 */
+ /* Foursemi FS16xx amplifier @ 35 */
+ /* FSA4480 Analog Audio Switch @ 42 */
+};
+
&ipa {
firmware-name = "qcom/sm6350/Sony/lena/ipa_fws.mbn";
--
2.53.0
^ permalink raw reply related [flat|nested] 37+ messages in thread* Re: [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses
2026-11-16 22:50 ` [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses erebion
@ 2026-11-16 22:59 ` sashiko-bot
2026-11-16 23:08 ` erebion
0 siblings, 1 reply; 37+ messages in thread
From: sashiko-bot @ 2026-11-16 22:59 UTC (permalink / raw)
To: erebion; +Cc: dri-devel, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: handle used instead of real name in
Signed-off-by
--
commit aa50f38e977106112fddebf20e119b54f3aca941
Author: erebion <erebion@erebion.eu>
> arm64: dts: qcom: sm6350-lena: enable remaining i2c busses
>
> Enable all i2c busses where something is connected on this phone. Add
> comments as placeholders for which components are still missing.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: erebion <erebion@erebion.eu>
[Severity: High]
The Author header and Signed-off-by trailer use the handle "erebion"
instead of a full real name, which is required by the Developer's
Certificate of Origin in Documentation/process/submitting-patches.rst.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-pdx213-upstream-3-v5-0-7318a19806eb@erebion.eu?part=12
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCH v5 12/12] arm64: dts: qcom: sm6350-lena: enable remaining i2c busses
2026-11-16 22:59 ` sashiko-bot
@ 2026-11-16 23:08 ` erebion
0 siblings, 0 replies; 37+ messages in thread
From: erebion @ 2026-11-16 23:08 UTC (permalink / raw)
To: sashiko-reviews; +Cc: dri-devel, devicetree, robh, conor+dt
[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]
On 11/16/26 23:59, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: qcom: handle used instead of real name in
> Signed-off-by
That was already discussed in v2 of this patch series.
--
erebion
XMPP: erebion@erebion.eu
Accepted languages: German, English, Swedish, Norwegian, Danish
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 37+ messages in thread