Devicetree
 help / color / mirror / Atom feed
* [PATCH RFC] leds: DT: migrating existing labels to function/color
@ 2026-11-17  5:10 Cristian Filipescu via B4 Relay
  2026-11-17  5:20 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Cristian Filipescu via B4 Relay @ 2026-11-17  5:10 UTC (permalink / raw)
  To: linux-leds, devicetree
  Cc: Lee Jones, Pavel Machek, Griffin Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec,
	Samuel Holland, linux-sunxi

From: Cristian Filipescu <filipescu.cristian@gmail.com>

Hi,

The common LED binding deprecates label in favour of function and color.
Is removing existing labels desirable when it changes established LED class
names, or should existing board descriptions retain them for compatibility?

For example, the Orange Pi H6 descriptions could replace their labels with
LED_FUNCTION_POWER/STATUS and LED_COLOR_ID_RED/GREEN. With gpio-leds, this
would change the names under /sys/class/leds:

  orangepi:red:power    -> red:power
  orangepi:green:status -> green:status

The example below changes two files and affects Orange Pi 3, 3 LTS, Lite2
and One Plus. GPIOs, polarity, pinctrl, defaults and triggers are unchanged.
All four DTBs compile before and after; comparison found only the intended
label/function/color changes. The renamed LEDs have not been tested on
hardware.

I was thinking of converting all the deprecated LED labels, but I wanted
to see if this was something maintainers wanted, since it would touch a lot
of files. Would you prefer retaining existing labels (potentially adding
function and color alongside them), or reviewing migrations with the name
changes explicitly documented?

This is a discussion example, not a patch for inclusion. Preparation and
static checks were assisted by OpenAI Codex.

Thanks,
Cristian

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
index ce82aa265..8e4117057 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
@@ -8,6 +8,7 @@
 #include "sun50i-h6-gpu-opp.dtsi"
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
 
 / {
 	model = "OrangePi 3";
@@ -45,13 +46,15 @@ leds {
 		compatible = "gpio-leds";
 
 		led-0 {
-			label = "orangepi:red:power";
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
 			gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
 			default-state = "on";
 		};
 
 		led-1 {
-			label = "orangepi:green:status";
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_GREEN>;
 			gpios = <&r_pio 0 7 GPIO_ACTIVE_HIGH>; /* PL7 */
 		};
 	};
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
index 57b137755..49f3d2fc8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
@@ -9,6 +9,7 @@
 #include "sun50i-h6-gpu-opp.dtsi"
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
 
 / {
 	model = "OrangePi One Plus";
@@ -45,13 +46,15 @@ leds {
 		compatible = "gpio-leds";
 
 		led-0 {
-			label = "orangepi:red:power";
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
 			gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
 			default-state = "on";
 		};
 
 		led-1 {
-			label = "orangepi:green:status";
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_GREEN>;
 			gpios = <&r_pio 0 7 GPIO_ACTIVE_HIGH>; /* PL7 */
 		};
 	};



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-17  5:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  5:10 [PATCH RFC] leds: DT: migrating existing labels to function/color Cristian Filipescu via B4 Relay
2026-11-17  5:20 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox