* [PATCH v7] arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet
@ 2026-11-17 5:20 Qianhui Xu
2026-11-17 5:34 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Qianhui Xu @ 2026-11-17 5:20 UTC (permalink / raw)
To: linux-arm-msm, devicetree
Cc: linux-kernel, Abel Vesa, Bjorn Andersson, Conor Dooley,
Konrad Dybcio, Krzysztof Kozlowski, Rob Herring
The Lenovo Legion Y700 Gen4 (TB322FC) is an SM8750 tablet. Add its
devicetree with the board compatible, the chassis type, the GPIOs the boot
firmware reserves and the board clocks, which the SM8750 dtsi consumes: the
XO and sleep clocks and the two divided CXO derivatives, as on the other
SM8750 boards.
The camera devices are powered by a WL2868C camera PMIC on i2c10: LDO1
feeds the rear sensor DVDD, LDO2 the front sensor DVDD, LDO3 the front
sensor AVDD, LDO4 the rear sensor AVDD, LDO5 the VCM VDD, LDO7 the DOVDD of
both sensors and the VCM VDDIO, all at fixed voltages including the offsets
programmed by the stock firmware. LDO6 is not wired out on this board.
This is one logical action - "add this new hardware" - so the board and the
regulators it carries are described in a single commit.
Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
---
Changes in v7:
- Fold the two devicetree patches of v6 (4/5 "add the Lenovo Legion Y700
Gen4" and 5/5 "describe the WL2868C regulators") into a single commit, as
asked in <20261104-elfish-booby-of-awe-27d2b6@quoll>: this is one logical
action, adding this new hardware, so it is one commit. The resulting tree
is identical to applying both v6 patches in order; nothing was dropped.
- No other change. The compatible, the reserved GPIO ranges, the board
clocks and the WL2868C regulator voltages are exactly as in v6.
Still open from the v6 thread (unchanged here, no way to validate them):
SPMI PMIC, RPMh regulators and console are not described, so this is still
the boot-infrastructure-less skeleton the v6 review commented on.
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 88230c4e00..e0b65a36c5 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -453,6 +453,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8650-valve-deckard.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sm8750-lenovo-elden.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts b/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
new file mode 100644
index 0000000000..73f4452f46
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
@@ -0,0 +1,129 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2026, Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include "sm8750.dtsi"
+
+/ {
+ model = "Lenovo Legion Y700 Gen4";
+ compatible = "lenovo,elden", "qcom,sm8750";
+ chassis-type = "tablet";
+
+ clocks {
+ xo_board: xo-board {
+ compatible = "fixed-clock";
+ clock-frequency = <76800000>;
+ #clock-cells = <0>;
+ };
+
+ sleep_clk: sleep-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <32000>;
+ #clock-cells = <0>;
+ };
+
+ bi_tcxo_div2: bi-tcxo-div2-clk {
+ compatible = "fixed-factor-clock";
+ #clock-cells = <0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+
+ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
+ compatible = "fixed-factor-clock";
+ #clock-cells = <0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK_A>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ };
+ };
+
+ /*
+ * VSYS of the camera PMIC is the always-on system rail of the tablet.
+ * The SPMI PMICs that generate it are not described yet, so it is
+ * modelled as a fixed regulator without a voltage constraint.
+ */
+ wl2868c_vsys: regulator-vsys {
+ compatible = "regulator-fixed";
+ regulator-name = "wl2868c_vsys";
+ regulator-always-on;
+ };
+};
+
+&gpi_dma2 {
+ status = "okay";
+};
+
+&qupv3_2 {
+ status = "okay";
+};
+
+&i2c10 {
+ status = "okay";
+
+ pmic@2f {
+ compatible = "willsemi,wl2868c";
+ reg = <0x2f>;
+ reset-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&camera_pmic_default>;
+ vsys-supply = <&wl2868c_vsys>;
+
+ regulators {
+ /* Voltages include the offsets programmed by stock firmware. */
+ camera_ldo1: ldo1 {
+ regulator-name = "camera_ldo1";
+ regulator-min-microvolt = <1128000>;
+ regulator-max-microvolt = <1128000>;
+ };
+
+ camera_ldo2: ldo2 {
+ regulator-name = "camera_ldo2";
+ regulator-min-microvolt = <1288000>;
+ regulator-max-microvolt = <1288000>;
+ };
+
+ camera_ldo3: ldo3 {
+ regulator-name = "camera_ldo3";
+ regulator-min-microvolt = <2816000>;
+ regulator-max-microvolt = <2816000>;
+ };
+
+ camera_ldo4: ldo4 {
+ regulator-name = "camera_ldo4";
+ regulator-min-microvolt = <2824000>;
+ regulator-max-microvolt = <2824000>;
+ };
+
+ camera_ldo5: ldo5 {
+ regulator-name = "camera_ldo5";
+ regulator-min-microvolt = <2808000>;
+ regulator-max-microvolt = <2808000>;
+ };
+
+ /* LDO6 is not wired out on this board. */
+ camera_ldo7: ldo7 {
+ regulator-name = "camera_ldo7";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ };
+ };
+};
+
+&tlmm {
+ gpio-reserved-ranges = <39 1>, <74 1>;
+
+ camera_pmic_default: camera-pmic-default-state {
+ pins = "gpio126";
+ function = "gpio";
+ bias-disable;
+ };
+};
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v7] arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet
2026-11-17 5:20 [PATCH v7] arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet Qianhui Xu
@ 2026-11-17 5:34 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-17 5:34 UTC (permalink / raw)
To: Qianhui Xu, devicetree; +Cc: robh, conor+dt
Thank you for your contribution! Sashiko AI review found 4 potential
issues to consider:
- [Medium] arm64: dts: qcom: undocumented lenovo,elden board compatible
in sm8750-lenovo-elden.dts
- [Medium] arm64: dts: qcom: undocumented willsemi,wl2868c compatible
and missing driver for pmic@2f
- [Medium] arm64: dts: qcom: sm8750-lenovo-elden.dts lacks core boot
infrastructure and regulator consumers
- [Low] arm64: dts: qcom: non-alphabetical phandle node ordering in
sm8750-lenovo-elden.dts
--
commit a64b24438a9a6e099bff47eb441ee5126bd53503
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet
This commit adds a devicetree for the Qualcomm SM8750-based Lenovo Legion
Y700 Gen4 tablet with board clocks, reserved GPIOs, and a Willsemi WL2868C
camera PMIC on i2c10.
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts b/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
> new file mode 100644
> index 0000000000000..73f4452f46120
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
> @@ -0,0 +1,129 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2026, Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "sm8750.dtsi"
> +
> +/ {
> + model = "Lenovo Legion Y700 Gen4";
> + compatible = "lenovo,elden", "qcom,sm8750";
[Severity: Medium]
Is the "lenovo,elden" board compatible documented in
Documentation/devicetree/bindings/arm/qcom.yaml? The qcom,sm8750 board
entry currently lists only qcom,sm8750-mtp and qcom,sm8750-qrd, so make
dtbs_check fails schema validation on sm8750-lenovo-elden.dtb.
[ ... ]
> + /*
> + * VSYS of the camera PMIC is the always-on system rail of the tablet.
> + * The SPMI PMICs that generate it are not described yet, so it is
> + * modelled as a fixed regulator without a voltage constraint.
> + */
> + wl2868c_vsys: regulator-vsys {
> + compatible = "regulator-fixed";
> + regulator-name = "wl2868c_vsys";
> + regulator-always-on;
> + };
> +};
> +
> +&gpi_dma2 {
> + status = "okay";
> +};
> +
> +&qupv3_2 {
> + status = "okay";
> +};
> +
> +&i2c10 {
> + status = "okay";
[Severity: Low]
This isn't a bug, but phandle node overrides in Qualcomm board devicetrees
are kept in alphabetical order, so &i2c10 should come before &qupv3_2.
> +
> + pmic@2f {
> + compatible = "willsemi,wl2868c";
> + reg = <0x2f>;
> + reset-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&camera_pmic_default>;
> + vsys-supply = <&wl2868c_vsys>;
[Severity: Medium]
Is there a devicetree binding schema or in-tree driver for
"willsemi,wl2868c"? Without a binding under
Documentation/devicetree/bindings/, make dtbs_check fails on pmic@2f, and
without a matching driver in the tree, the PMIC and its child regulators
never bind at runtime.
> +
> + regulators {
> + /* Voltages include the offsets programmed by stock firmware. */
> + camera_ldo1: ldo1 {
> + regulator-name = "camera_ldo1";
> + regulator-min-microvolt = <1128000>;
> + regulator-max-microvolt = <1128000>;
> + };
> +
> + camera_ldo2: ldo2 {
> + regulator-name = "camera_ldo2";
> + regulator-min-microvolt = <1288000>;
> + regulator-max-microvolt = <1288000>;
> + };
> +
> + camera_ldo3: ldo3 {
> + regulator-name = "camera_ldo3";
> + regulator-min-microvolt = <2816000>;
> + regulator-max-microvolt = <2816000>;
> + };
> +
> + camera_ldo4: ldo4 {
> + regulator-name = "camera_ldo4";
> + regulator-min-microvolt = <2824000>;
> + regulator-max-microvolt = <2824000>;
> + };
> +
> + camera_ldo5: ldo5 {
> + regulator-name = "camera_ldo5";
> + regulator-min-microvolt = <2808000>;
> + regulator-max-microvolt = <2808000>;
> + };
> +
> + /* LDO6 is not wired out on this board. */
> + camera_ldo7: ldo7 {
> + regulator-name = "camera_ldo7";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> + };
> + };
> +};
[Severity: Medium]
Can sm8750-lenovo-elden.dts boot to a usable system without core platform
infrastructure such as the SPMI PMICs, apps_rsc RPMh regulators, console, or
storage? As added, the board devicetree omits the base platform nodes needed
to boot and instead only describes the camera PMIC, feeding its vsys-supply
from a voltage-less placeholder fixed regulator (wl2868c_vsys) while leaving
camera_ldo1 through camera_ldo7 without any consumers.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117052029.31900-1-xiaqinghuan@mail.ustc.edu.cn?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 5:20 [PATCH v7] arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet Qianhui Xu
2026-11-17 5:34 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox