Devicetree
 help / color / mirror / Atom feed
* [PATCH v2 0/6] Input: aw86927 - add AW86937 support and fix the AW8693X layout
@ 2026-11-17  5:21 Qianhui Xu
  2026-11-17  5:21 ` [PATCH v2 1/6] Input: aw86927 - fix the 7 V boost reference for AW86938 Qianhui Xu
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Qianhui Xu @ 2026-11-17  5:21 UTC (permalink / raw)
  To: Dmitry Torokhov, linux-input
  Cc: devicetree, linux-kernel, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley

*** AI-assistance disclosure ***
This cover letter and the six patches below were prepared with the help
of an LLM coding assistant.  The author reviewed every line, ran every
gate quoted in this letter himself, and takes full responsibility for
the content.

This series adds support for the Awinic AW86937 LRA haptic IC on top of
the existing AW86927/AW86938 driver, fixes two register definitions that
are wrong on the AW8693x parts, and stops playback over suspend/shutdown.

Patch 1 fixes the 7 V boost reference value that the AW86938 support
introduced (0x11 programs 9 V, not 7 V).  Patch 2 widens the AW86938
boost mode mask: the field is two bits wide at 6:5, so the existing
one-bit mask leaves bit 6 untouched when the driver selects bypass.
Patch 3 documents the awinic,aw86937 compatible as another member of the
AW86927 fallback group; detection stays on the chip ID, so no new
of_device_id entry is added.  Patch 4 adds the chip ID and init path.
Patch 5 handles the AW8693x register layout differences (auto-boost bit,
two-bit boost mode, VBAT mode and the two-step stop handshake).  Patch 6
stops playback, drains the work item and parks the part in reset over
suspend and shutdown, and registers the reset action with the device so
that unbind and probe failure unwind leave the chip asserted.

What changed in v2
==================

Only the two review points from the previous posting (2026-10-27) are
taken; patch 1, 4 and 5 are unchanged, 2, 3 and 6 differ exactly as
follows:

  - patch 2 (new in v2): the boost mode mask is now GENMASK(6, 5)
    instead of GENMASK(5, 5), so the two-bit boost mode field is
    programmed as a whole.
  - patch 6: aw86927_reset() is registered with
    devm_add_action_or_reset() right after the reset GPIO has been
    acquired, so unbind and a probe failure after that point leave the
    part asserted.
  - patch 3: carries Krzysztof's Acked-by from the previous posting; the
    binding change itself is unchanged.

The AW86937 has no hardware in hand: the register data comes from the
vendor driver and the part datasheet, and the commit message does not
claim otherwise.

Qianhui Xu (6):
  Input: aw86927 - fix the 7 V boost reference for AW86938
  Input: aw86927 - widen the AW86938 boost mode mask
  dt-bindings: input: awinic,aw86927: document the AW86937 variant
  Input: aw86927 - add support for Awinic AW86937
  Input: aw86927 - handle the AW8693X play and boost register layout
  Input: aw86927 - stop playback over suspend and on shutdown

 .../bindings/input/awinic,aw86927.yaml        |   1 +
 drivers/input/misc/aw86927.c                  | 154 +++++++++++++++---
 2 files changed, 131 insertions(+), 24 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-11-17  5:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  5:21 [PATCH v2 0/6] Input: aw86927 - add AW86937 support and fix the AW8693X layout Qianhui Xu
2026-11-17  5:21 ` [PATCH v2 1/6] Input: aw86927 - fix the 7 V boost reference for AW86938 Qianhui Xu
2026-11-17  5:21 ` [PATCH v2 2/6] Input: aw86927 - widen the AW86938 boost mode mask Qianhui Xu
2026-11-17  5:21 ` [PATCH v2 3/6] dt-bindings: input: awinic,aw86927: document the AW86937 variant Qianhui Xu
2026-11-17  5:21 ` [PATCH v2 4/6] Input: aw86927 - add support for Awinic AW86937 Qianhui Xu
2026-11-17  5:21 ` [PATCH v2 5/6] Input: aw86927 - handle the AW8693X play and boost register layout Qianhui Xu
2026-11-17  5:21 ` [PATCH v2 6/6] Input: aw86927 - stop playback over suspend and on shutdown Qianhui Xu
2026-11-17  5:46   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox