Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arpit Saini" <arpit.saini@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
Date: Tue, 17 Nov 2026 06:11:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-218240@kernel.org> (raw)
In-Reply-To: <20261117-resend-upstream-attention-v4-1-3f11ab312d2f@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: sm8750-mtp: Fixes tag cites panel driver
  instead of DTS
--

commit 58b7afa3ece802e52179ca7a4b00405394a5f6c2
Author: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>

> arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
>
> The NT37801 Spec V1.0 chapter "5.7.1 Power On Sequence" states
> VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.
>
> While 1.65V is within the range accepted by the panel, the power grid
> documentation specifies L12B as a 1.8V rail, so set the minimum to 1.8V
> to match what the hardware is expected to use.
>
> Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
> Signed-off-by: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
> Co-developed-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>

[Severity: Low]
The Fixes tag points to 4fca6849864d ("drm/panel: Add Novatek NT37801
panel driver"), which only added the panel driver under
drivers/gpu/drm/panel/.

In arch/arm64/boot/dts/qcom/sm8750-mtp.dts, the vreg_l12b_1p8 node with
regulator-min-microvolt = <1200000> was added by 6a02becf4b42 ("arm64:
dts: qcom: sm8750: Add MTP and QRD boards"), and the panel@0 node using it
was added by 20a761211630 ("arm64: dts: qcom: sm8750-mtp: Enable display").
Should the Fixes tag reference one of those commits instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-resend-upstream-attention-v4-1-3f11ab312d2f@oss.qualcomm.com?part=1

      reply	other threads:[~2026-11-17  6:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:54 [PATCH v4] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801 Arpit Saini
2026-11-17  6:11 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218240@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=arpit.saini@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox