Devicetree
 help / color / mirror / Atom feed
* [PATCH v4] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
@ 2026-11-17  5:54 Arpit Saini
  2026-11-17  6:11 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Arpit Saini @ 2026-11-17  5:54 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Linus Walleij
  Cc: Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
	mahadevan.p, rajeevny, Dmitry Baryshkov, Ayushi Makhija,
	Arpit Saini

From: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>

The NT37801 Spec V1.0 chapter "5.7.1 Power On Sequence" states
VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.

While 1.65V is within the range accepted by the panel, the power grid
documentation specifies L12B as a 1.8V rail, so set the minimum to 1.8V
to match what the hardware is expected to use.

Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
Signed-off-by: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
Co-developed-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
---
Changes in v4:
- Addressed Bjorn's comments: make it 1.8V, i.e. set
  regulator-min-microvolt to 1800000 instead of 1650000, as the power grid
  specifies L12B as a 1.8V rail.
- Fixed "Sepc" typo in the commit message.
- Dropped Dmitry's and Konrad's Reviewed-by tags, as the value changed.
- Link to v3: https://lore.kernel.org/r/20261007-resend-upstream-attention-v3-1-c2af21b3def4@oss.qualcomm.com

Changes in v3:
- Added my signed-off by.
- Link to v2: https://lore.kernel.org/r/4f8a2731-4ea4-49d9-924c-ebde9fc58170@oss.qualcomm.com
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 64bc1cec612e..b0097715aee4 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -462,7 +462,7 @@ vreg_l11b_1p0: ldo11 {
 
 		vreg_l12b_1p8: ldo12 {
 			regulator-name = "vreg_l12b_1p8";
-			regulator-min-microvolt = <1200000>;
+			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;

---
base-commit: 84abb955b1015477aa11a96e2f3ac1b938b77f48
change-id: 20261007-resend-upstream-attention-f964719a0733

Best regards,
-- 
Arpit Saini <arpit.saini@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
  2026-11-17  5:54 [PATCH v4] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801 Arpit Saini
@ 2026-11-17  6:11 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-17  6:11 UTC (permalink / raw)
  To: Arpit Saini; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: sm8750-mtp: Fixes tag cites panel driver
  instead of DTS
--

commit 58b7afa3ece802e52179ca7a4b00405394a5f6c2
Author: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>

> arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
>
> The NT37801 Spec V1.0 chapter "5.7.1 Power On Sequence" states
> VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.
>
> While 1.65V is within the range accepted by the panel, the power grid
> documentation specifies L12B as a 1.8V rail, so set the minimum to 1.8V
> to match what the hardware is expected to use.
>
> Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
> Signed-off-by: Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>
> Co-developed-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>

[Severity: Low]
The Fixes tag points to 4fca6849864d ("drm/panel: Add Novatek NT37801
panel driver"), which only added the panel driver under
drivers/gpu/drm/panel/.

In arch/arm64/boot/dts/qcom/sm8750-mtp.dts, the vreg_l12b_1p8 node with
regulator-min-microvolt = <1200000> was added by 6a02becf4b42 ("arm64:
dts: qcom: sm8750: Add MTP and QRD boards"), and the panel@0 node using it
was added by 20a761211630 ("arm64: dts: qcom: sm8750-mtp: Enable display").
Should the Fixes tag reference one of those commits instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-resend-upstream-attention-v4-1-3f11ab312d2f@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-17  6:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  5:54 [PATCH v4] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801 Arpit Saini
2026-11-17  6:11 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox