From: sashiko-bot@kernel.org
To: "Wangao Wang" <wangao.wang@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
media-ci@linuxtv.org
Subject: Re: [PATCH v3 2/5] media: iris: Add support for Eliza
Date: Tue, 17 Nov 2026 06:47:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-218278@kernel.org> (raw)
In-Reply-To: <20261117-add_iris_for_eliza-v3-2-02a55a9272ef@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] media: iris: NULL dereference in iris_set_slice_count() on
Eliza
- [High] media: iris: broken watchdog handling in eliza_data due to
missing wd_intr_mask
- [Medium] media: iris: zero peak bandwidth in iris_set_icc_bw() on
Eliza
--
commit ce18526ddc6f609e07e690d6181970e4db456f5c
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>
media: iris: Add support for Eliza
This commit adds platform data, firmware description, and device tree match
entries to support the VPU3.3 Iris video codec on Qualcomm Eliza.
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
> index e963cb116313f..f16f94a2dacc6 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
[ ... ]
> @@ -87,6 +93,45 @@ static const struct tz_cp_config tz_cp_config_vpu3[] = {
> },
> };
>
> +/*
> + * Shares most of SM8550 data except:
> + * - firmware_desc_gen2 to iris_vpu33_p2_s7_gen2_desc
> + * - vpu_ops to iris_vpu33_ops
> + * - clk_rst_tbl to sm8650_clk_reset_table
> + * - controller_rst_tbl to sm8650_controller_reset_table
> + * - inst_caps to platform_inst_cap_qcs8300 (4K capable, 2 VPP pipes)
> + */
> +const struct iris_platform_data eliza_data = {
> + .firmware_desc_gen2 = &iris_vpu33_p2_s7_gen2_desc,
> + .vpu_ops = &iris_vpu33_ops,
> + .icc_tbl = iris_icc_info_vpu3x,
> + .icc_tbl_size = ARRAY_SIZE(iris_icc_info_vpu3x),
> + .clk_rst_tbl = sm8650_clk_reset_table,
> + .clk_rst_tbl_size = ARRAY_SIZE(sm8650_clk_reset_table),
> + .controller_rst_tbl = sm8650_controller_reset_table,
> + .controller_rst_tbl_size = ARRAY_SIZE(sm8650_controller_reset_table),
> + .bw_tbl_dec = iris_bw_table_dec_vpu3x,
> + .bw_tbl_dec_size = ARRAY_SIZE(iris_bw_table_dec_vpu3x),
> + .pmdomain_tbl = iris_pmdomain_table_vpu3x,
> + .pmdomain_tbl_size = ARRAY_SIZE(iris_pmdomain_table_vpu3x),
> + .opp_pd_tbl = iris_opp_pd_table_vpu3x,
> + .opp_pd_tbl_size = ARRAY_SIZE(iris_opp_pd_table_vpu3x),
> + .clk_tbl = sm8550_clk_table,
> + .clk_tbl_size = ARRAY_SIZE(sm8550_clk_table),
> + .opp_clk_tbl = iris_opp_clk_table_vpu3x,
> + /* Upper bound of DMA address range */
> + .dma_mask = 0xe0000000 - 1,
> + .inst_iris_fmts = iris_fmts_vpu3x_dec,
> + .inst_iris_fmts_size = ARRAY_SIZE(iris_fmts_vpu3x_dec),
> + .inst_caps = &platform_inst_cap_qcs8300,
> + .tz_cp_config_data = tz_cp_config_vpu3,
[Severity: High]
Should eliza_data set .slice_caps = &iris_vpu2_vpu3x_slice_caps like the
other VPU3x platforms?
iris_vpu33_p2_s7_gen2_desc uses iris_hfi_gen2_data, which exposes the
V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control with .set =
iris_set_slice_count. With .slice_caps left NULL, selecting a multi-slice
mode (V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB or
V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES) causes a NULL pointer
dereference in iris_set_slice_count() when it reads
slice_caps->max_slice_frame_rate.
> + .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3),
> + .num_vpp_pipe = 2,
> + .max_session_count = 16,
[Severity: High]
Is eliza_data missing .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK?
iris_vpu33_ops unmasks WRAPPER_INTR_MASK_A2HWD_BMSK in hardware via
iris_vpu_interrupt_init(), while iris_vpu_clear_interrupt() and
iris_vpu_watchdog() check core->iris_platform_data->wd_intr_mask. Leaving
wd_intr_mask as 0 prevents iris_vpu_watchdog() from detecting a VPU
watchdog timeout, skipping error recovery and causing
iris_hfi_isr_handler() to re-enable the level-triggered IRQ while the
hardware watchdog interrupt remains asserted.
> + .max_core_mbpf = NUM_MBS_4K * 2,
> + .max_core_mbps = NUM_MBS_4K * 60,
> +};
[Severity: Medium]
Should eliza_data also initialize .icc_ib_multiplier = 1? Without it,
iris_set_icc_bw() computes core->icc_tbl[i].peak_bw = bw_kbps *
icc_ib_multiplier as 0 and always votes zero peak bandwidth on the
video-mem interconnect path.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-add_iris_for_eliza-v3-0-02a55a9272ef@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-17 6:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 6:34 [PATCH v3 0/5] media: iris: Enable Iris video codec on Eliza Wangao Wang
2026-11-17 6:34 ` [PATCH v3 1/5] dt-bindings: media: qcom,sm8550-iris: Document Eliza IRIS accelerator Wangao Wang
2026-11-17 6:34 ` [PATCH v3 2/5] media: iris: Add support for Eliza Wangao Wang
2026-11-17 6:47 ` sashiko-bot [this message]
2026-11-17 6:34 ` [PATCH v3 3/5] arm64: dts: qcom: eliza: Add iris video codec node Wangao Wang
2026-11-17 6:56 ` sashiko-bot
2026-11-17 6:34 ` [PATCH v3 4/5] arm64: dts: qcom: eliza-mtp: Enable iris video codec Wangao Wang
2026-11-17 6:52 ` sashiko-bot
2026-11-17 6:34 ` [PATCH v3 5/5] arm64: dts: qcom: eliza-evk: " Wangao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218278@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wangao.wang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox