* [PATCH v3 1/5] dt-bindings: media: qcom,sm8550-iris: Document Eliza IRIS accelerator
2026-11-17 6:34 [PATCH v3 0/5] media: iris: Enable Iris video codec on Eliza Wangao Wang
@ 2026-11-17 6:34 ` Wangao Wang
2026-11-17 6:34 ` [PATCH v3 2/5] media: iris: Add support for Eliza Wangao Wang
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Wangao Wang @ 2026-11-17 6:34 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, Wangao Wang,
Krzysztof Kozlowski
Add the qcom,eliza-iris compatible for the IRIS video decoder/encoder
accelerator found on the Eliza platform.
Eliza belongs to the same IRIS v3 family as SM8550 and SM8650, and uses
VPU3.3 with an SM8650-compatible clock and reset configuration. Like
SM8650, it requires the bus, xo, and core resets, so include it in the
existing allOf constraint that enforces resets minItems: 3.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
index 0400ca1bff05dcef6b742c3fbf77e38adca9f280..e06f2d844bd2614f6bc5237e3a246056daf28821 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
@@ -23,6 +23,7 @@ properties:
- qcom,x1e80100-iris
- const: qcom,sm8550-iris
- enum:
+ - qcom,eliza-iris
- qcom,qcs8300-iris
- qcom,sm8550-iris
- qcom,sm8650-iris
@@ -106,6 +107,7 @@ allOf:
properties:
compatible:
enum:
+ - qcom,eliza-iris
- qcom,sm8650-iris
then:
properties:
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 2/5] media: iris: Add support for Eliza
2026-11-17 6:34 [PATCH v3 0/5] media: iris: Enable Iris video codec on Eliza Wangao Wang
2026-11-17 6:34 ` [PATCH v3 1/5] dt-bindings: media: qcom,sm8550-iris: Document Eliza IRIS accelerator Wangao Wang
@ 2026-11-17 6:34 ` Wangao Wang
2026-11-17 6:47 ` sashiko-bot
2026-11-17 6:34 ` [PATCH v3 3/5] arm64: dts: qcom: eliza: Add iris video codec node Wangao Wang
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Wangao Wang @ 2026-11-17 6:34 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, Wangao Wang
Add support for the Eliza Iris video codec. Eliza uses the VPU3.3 hardware
with a dedicated vpu33_p2_s7 firmware variant and SM8650-compatible
clock/reset tables. Key differences from SM8550:
- firmware_desc_gen2: vpu33_p2_s7 (SM8550 uses vpu30_p4)
- vpu_ops: iris_vpu33_ops
- clk_rst_tbl: sm8650_clk_reset_table
- controller_rst_tbl: sm8650_controller_reset_table
- inst_caps: platform_inst_cap_qcs8300 (4K capable, 2 VPP pipes)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
.../platform/qcom/iris/iris_platform_common.h | 1 +
.../media/platform/qcom/iris/iris_platform_vpu3x.c | 45 ++++++++++++++++++++++
drivers/media/platform/qcom/iris/iris_probe.c | 4 ++
3 files changed, 50 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
index cddab9a9c375abc6f803f98272619ecde8ea7873..dbfb4d2cb7c38a0fd12804b519ba579692916e19 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_common.h
+++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
@@ -62,6 +62,7 @@ extern const struct iris_firmware_data iris_hfi_gen2_ar50lt_data;
extern const struct platform_inst_slice_caps iris_vpu2_vpu3x_slice_caps;
extern const struct platform_inst_slice_caps iris_ar50lt_slice_caps;
+extern const struct iris_platform_data eliza_data;
extern const struct iris_platform_data milos_data;
extern const struct iris_platform_data qcm2290_data;
extern const struct iris_platform_data qcs8300_data;
diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
index e963cb116313f8e7619dc0686257801c09c7925d..f16f94a2dacc6f63d5ec40a8f2cba909a0d04e0a 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
+++ b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
@@ -44,6 +44,12 @@ static const struct iris_firmware_desc iris_vpu33_p4_gen2_desc = {
.fwname = "qcom/vpu/vpu33_p4.mbn",
};
+static const struct iris_firmware_desc iris_vpu33_p2_s7_gen2_desc = {
+ .firmware_data = &iris_hfi_gen2_data,
+ .get_vpu_buffer_size = iris_vpu33_buf_size,
+ .fwname = "qcom/vpu/vpu33_p2_s7.mbn",
+};
+
static const struct iris_firmware_desc iris_vpu35_p4_gen2_desc = {
.firmware_data = &iris_hfi_gen2_data,
.get_vpu_buffer_size = iris_vpu33_buf_size,
@@ -87,6 +93,45 @@ static const struct tz_cp_config tz_cp_config_vpu3[] = {
},
};
+/*
+ * Shares most of SM8550 data except:
+ * - firmware_desc_gen2 to iris_vpu33_p2_s7_gen2_desc
+ * - vpu_ops to iris_vpu33_ops
+ * - clk_rst_tbl to sm8650_clk_reset_table
+ * - controller_rst_tbl to sm8650_controller_reset_table
+ * - inst_caps to platform_inst_cap_qcs8300 (4K capable, 2 VPP pipes)
+ */
+const struct iris_platform_data eliza_data = {
+ .firmware_desc_gen2 = &iris_vpu33_p2_s7_gen2_desc,
+ .vpu_ops = &iris_vpu33_ops,
+ .icc_tbl = iris_icc_info_vpu3x,
+ .icc_tbl_size = ARRAY_SIZE(iris_icc_info_vpu3x),
+ .clk_rst_tbl = sm8650_clk_reset_table,
+ .clk_rst_tbl_size = ARRAY_SIZE(sm8650_clk_reset_table),
+ .controller_rst_tbl = sm8650_controller_reset_table,
+ .controller_rst_tbl_size = ARRAY_SIZE(sm8650_controller_reset_table),
+ .bw_tbl_dec = iris_bw_table_dec_vpu3x,
+ .bw_tbl_dec_size = ARRAY_SIZE(iris_bw_table_dec_vpu3x),
+ .pmdomain_tbl = iris_pmdomain_table_vpu3x,
+ .pmdomain_tbl_size = ARRAY_SIZE(iris_pmdomain_table_vpu3x),
+ .opp_pd_tbl = iris_opp_pd_table_vpu3x,
+ .opp_pd_tbl_size = ARRAY_SIZE(iris_opp_pd_table_vpu3x),
+ .clk_tbl = sm8550_clk_table,
+ .clk_tbl_size = ARRAY_SIZE(sm8550_clk_table),
+ .opp_clk_tbl = iris_opp_clk_table_vpu3x,
+ /* Upper bound of DMA address range */
+ .dma_mask = 0xe0000000 - 1,
+ .inst_iris_fmts = iris_fmts_vpu3x_dec,
+ .inst_iris_fmts_size = ARRAY_SIZE(iris_fmts_vpu3x_dec),
+ .inst_caps = &platform_inst_cap_qcs8300,
+ .tz_cp_config_data = tz_cp_config_vpu3,
+ .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3),
+ .num_vpp_pipe = 2,
+ .max_session_count = 16,
+ .max_core_mbpf = NUM_MBS_4K * 2,
+ .max_core_mbps = NUM_MBS_4K * 60,
+};
+
/*
* Shares most of SM8550 data except:
* - inst_caps to platform_inst_cap_qcs8300
diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
index 343e44c6b9c46190a4fb3a0055ba012b16011235..6bf6b2886f151036c34645aa2c6daf3f85f53908 100644
--- a/drivers/media/platform/qcom/iris/iris_probe.c
+++ b/drivers/media/platform/qcom/iris/iris_probe.c
@@ -418,6 +418,10 @@ static const struct dev_pm_ops iris_pm_ops = {
};
static const struct of_device_id iris_dt_match[] = {
+ {
+ .compatible = "qcom,eliza-iris",
+ .data = &eliza_data,
+ },
{
.compatible = "qcom,milos-iris",
.data = &milos_data,
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 2/5] media: iris: Add support for Eliza
2026-11-17 6:34 ` [PATCH v3 2/5] media: iris: Add support for Eliza Wangao Wang
@ 2026-11-17 6:47 ` sashiko-bot
0 siblings, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-11-17 6:47 UTC (permalink / raw)
To: Wangao Wang; +Cc: devicetree, robh, conor+dt, media-ci
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] media: iris: NULL dereference in iris_set_slice_count() on
Eliza
- [High] media: iris: broken watchdog handling in eliza_data due to
missing wd_intr_mask
- [Medium] media: iris: zero peak bandwidth in iris_set_icc_bw() on
Eliza
--
commit ce18526ddc6f609e07e690d6181970e4db456f5c
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>
media: iris: Add support for Eliza
This commit adds platform data, firmware description, and device tree match
entries to support the VPU3.3 Iris video codec on Qualcomm Eliza.
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
> index e963cb116313f..f16f94a2dacc6 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu3x.c
[ ... ]
> @@ -87,6 +93,45 @@ static const struct tz_cp_config tz_cp_config_vpu3[] = {
> },
> };
>
> +/*
> + * Shares most of SM8550 data except:
> + * - firmware_desc_gen2 to iris_vpu33_p2_s7_gen2_desc
> + * - vpu_ops to iris_vpu33_ops
> + * - clk_rst_tbl to sm8650_clk_reset_table
> + * - controller_rst_tbl to sm8650_controller_reset_table
> + * - inst_caps to platform_inst_cap_qcs8300 (4K capable, 2 VPP pipes)
> + */
> +const struct iris_platform_data eliza_data = {
> + .firmware_desc_gen2 = &iris_vpu33_p2_s7_gen2_desc,
> + .vpu_ops = &iris_vpu33_ops,
> + .icc_tbl = iris_icc_info_vpu3x,
> + .icc_tbl_size = ARRAY_SIZE(iris_icc_info_vpu3x),
> + .clk_rst_tbl = sm8650_clk_reset_table,
> + .clk_rst_tbl_size = ARRAY_SIZE(sm8650_clk_reset_table),
> + .controller_rst_tbl = sm8650_controller_reset_table,
> + .controller_rst_tbl_size = ARRAY_SIZE(sm8650_controller_reset_table),
> + .bw_tbl_dec = iris_bw_table_dec_vpu3x,
> + .bw_tbl_dec_size = ARRAY_SIZE(iris_bw_table_dec_vpu3x),
> + .pmdomain_tbl = iris_pmdomain_table_vpu3x,
> + .pmdomain_tbl_size = ARRAY_SIZE(iris_pmdomain_table_vpu3x),
> + .opp_pd_tbl = iris_opp_pd_table_vpu3x,
> + .opp_pd_tbl_size = ARRAY_SIZE(iris_opp_pd_table_vpu3x),
> + .clk_tbl = sm8550_clk_table,
> + .clk_tbl_size = ARRAY_SIZE(sm8550_clk_table),
> + .opp_clk_tbl = iris_opp_clk_table_vpu3x,
> + /* Upper bound of DMA address range */
> + .dma_mask = 0xe0000000 - 1,
> + .inst_iris_fmts = iris_fmts_vpu3x_dec,
> + .inst_iris_fmts_size = ARRAY_SIZE(iris_fmts_vpu3x_dec),
> + .inst_caps = &platform_inst_cap_qcs8300,
> + .tz_cp_config_data = tz_cp_config_vpu3,
[Severity: High]
Should eliza_data set .slice_caps = &iris_vpu2_vpu3x_slice_caps like the
other VPU3x platforms?
iris_vpu33_p2_s7_gen2_desc uses iris_hfi_gen2_data, which exposes the
V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control with .set =
iris_set_slice_count. With .slice_caps left NULL, selecting a multi-slice
mode (V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB or
V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES) causes a NULL pointer
dereference in iris_set_slice_count() when it reads
slice_caps->max_slice_frame_rate.
> + .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu3),
> + .num_vpp_pipe = 2,
> + .max_session_count = 16,
[Severity: High]
Is eliza_data missing .wd_intr_mask = WRAPPER_INTR_STATUS_A2HWD_BMSK?
iris_vpu33_ops unmasks WRAPPER_INTR_MASK_A2HWD_BMSK in hardware via
iris_vpu_interrupt_init(), while iris_vpu_clear_interrupt() and
iris_vpu_watchdog() check core->iris_platform_data->wd_intr_mask. Leaving
wd_intr_mask as 0 prevents iris_vpu_watchdog() from detecting a VPU
watchdog timeout, skipping error recovery and causing
iris_hfi_isr_handler() to re-enable the level-triggered IRQ while the
hardware watchdog interrupt remains asserted.
> + .max_core_mbpf = NUM_MBS_4K * 2,
> + .max_core_mbps = NUM_MBS_4K * 60,
> +};
[Severity: Medium]
Should eliza_data also initialize .icc_ib_multiplier = 1? Without it,
iris_set_icc_bw() computes core->icc_tbl[i].peak_bw = bw_kbps *
icc_ib_multiplier as 0 and always votes zero peak bandwidth on the
video-mem interconnect path.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-add_iris_for_eliza-v3-0-02a55a9272ef@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 3/5] arm64: dts: qcom: eliza: Add iris video codec node
2026-11-17 6:34 [PATCH v3 0/5] media: iris: Enable Iris video codec on Eliza Wangao Wang
2026-11-17 6:34 ` [PATCH v3 1/5] dt-bindings: media: qcom,sm8550-iris: Document Eliza IRIS accelerator Wangao Wang
2026-11-17 6:34 ` [PATCH v3 2/5] media: iris: Add support for Eliza Wangao Wang
@ 2026-11-17 6:34 ` Wangao Wang
2026-11-17 6:56 ` sashiko-bot
2026-11-17 6:34 ` [PATCH v3 4/5] arm64: dts: qcom: eliza-mtp: Enable iris video codec Wangao Wang
2026-11-17 6:34 ` [PATCH v3 5/5] arm64: dts: qcom: eliza-evk: " Wangao Wang
4 siblings, 1 reply; 9+ messages in thread
From: Wangao Wang @ 2026-11-17 6:34 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, Wangao Wang,
Konrad Dybcio
Describe the Iris video codec hardware found in the Eliza SoC. The iris
node is placed at 0xaa00000 with VPU3.3 hardware capabilities. It uses
GCC_VIDEO_AXI0 for bus interface, and VIDEO_CC_MVS0C/MVS0 for core and
codec clocks respectively, along with SM8650-like AXI bus/XO/core reset
support.
Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza.dtsi | 98 +++++++++++++++++++++++++++++++++++++
1 file changed, 98 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 4a125ef386c025fe6ecdbf4d17a785d1532ba09e..0c13d3f9b6c178687911947c890d4c4d5318e2ad 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -3429,6 +3429,104 @@ gpucc: clock-controller@3d90000 {
#power-domain-cells = <1>;
};
+ iris: video-codec@aa00000 {
+ compatible = "qcom,eliza-iris";
+ reg = <0 0xaa00000 0 0xf0000>;
+
+ interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+
+ power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
+ <&videocc VIDEO_CC_MVS0_GDSC>,
+ <&rpmhpd RPMHPD_MX>,
+ <&rpmhpd RPMHPD_CX>;
+ power-domain-names = "venus",
+ "vcodec0",
+ "mxc",
+ "mmcx";
+
+ operating-points-v2 = <&iris_opp_table>;
+
+ clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+ <&videocc VIDEO_CC_MVS0C_CLK>,
+ <&videocc VIDEO_CC_MVS0_CLK>;
+ clock-names = "iface",
+ "core",
+ "vcodec0_core";
+
+ interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_VIDEO_MVP QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "cpu-cfg",
+ "video-mem";
+
+ memory-region = <&video_mem>;
+
+ resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>,
+ <&videocc VIDEO_CC_XO_CLK_ARES>,
+ <&videocc VIDEO_CC_MVS0C_CLK_ARES>;
+ reset-names = "bus",
+ "xo",
+ "core";
+
+ dma-coherent;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ dma-ranges = <0x0 0x0 0x0 0xe0000000>;
+
+ status = "disabled";
+
+ non-pixel {
+ iommus = <&apps_smmu 0x1940 0x0>;
+ iommu-ranges = <0x25800000 0xba800000>;
+ };
+
+ pixel {
+ iommus = <&apps_smmu 0x1947 0x0>;
+ };
+
+ iris_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-192000000 {
+ opp-hz = /bits/ 64 <192000000>;
+ required-opps = <&rpmhpd_opp_low_svs_d1>,
+ <&rpmhpd_opp_low_svs_d1>;
+ };
+
+ opp-240000000 {
+ opp-hz = /bits/ 64 <240000000>;
+ required-opps = <&rpmhpd_opp_low_svs>,
+ <&rpmhpd_opp_svs>;
+ };
+
+ opp-338000000 {
+ opp-hz = /bits/ 64 <338000000>;
+ required-opps = <&rpmhpd_opp_svs>,
+ <&rpmhpd_opp_svs>;
+ };
+
+ opp-366000000 {
+ opp-hz = /bits/ 64 <366000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>,
+ <&rpmhpd_opp_svs>;
+ };
+
+ opp-444000000 {
+ opp-hz = /bits/ 64 <444000000>;
+ required-opps = <&rpmhpd_opp_nom>,
+ <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-533333333 {
+ opp-hz = /bits/ 64 <533333333>;
+ required-opps = <&rpmhpd_opp_turbo>,
+ <&rpmhpd_opp_svs_l1>;
+ };
+ };
+ };
+
videocc: clock-controller@aaf0000 {
compatible = "qcom,eliza-videocc";
reg = <0x0 0xaaf0000 0x0 0x10000>;
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 3/5] arm64: dts: qcom: eliza: Add iris video codec node
2026-11-17 6:34 ` [PATCH v3 3/5] arm64: dts: qcom: eliza: Add iris video codec node Wangao Wang
@ 2026-11-17 6:56 ` sashiko-bot
0 siblings, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-11-17 6:56 UTC (permalink / raw)
To: Wangao Wang; +Cc: devicetree, robh, conor+dt, media-ci
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] arm64: dts: qcom: eliza: missing iommus on iris node breaks
iris_probe()
- [High] arm64: dts: qcom: eliza: reversed MX and CX required-opps in
iris_opp_table
- [High] media: iris: missing slice_caps, wd_intr_mask,
icc_ib_multiplier in eliza_data
--
commit a19bdea4d1c4719e401fe9a32254505afdb19a2d
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>
arm64: dts: qcom: eliza: Add iris video codec node
This commit adds the Iris video codec device tree node and its operating
performance points table for the Qualcomm Eliza SoC.
> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index 4a125ef386c02..0c13d3f9b6c17 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
> @@ -3429,6 +3429,104 @@ gpucc: clock-controller@3d90000 {
> #power-domain-cells = <1>;
> };
>
> + iris: video-codec@aa00000 {
> + compatible = "qcom,eliza-iris";
[Severity: High]
Does binding to eliza_data (introduced in commit "media: iris: Add support
for Eliza") leave .slice_caps, .wd_intr_mask, and .icc_ib_multiplier
unset?
Unlike the other VPU3x entries in
drivers/media/platform/qcom/iris/iris_platform_vpu3x.c, eliza_data omits
all three fields. When multi-slice encoding is configured,
iris_set_slice_count() dereferences a NULL slice_caps pointer:
drivers/media/platform/qcom/iris/iris_ctrls.c:iris_set_slice_count() {
...
slice_caps = inst->core->iris_platform_data->slice_caps;
...
if (fps > slice_caps->max_slice_frame_rate ||
...
}
Leaving .icc_ib_multiplier at 0 also causes iris_set_icc_bw() to vote 0 peak
bandwidth on video-mem, and leaving .wd_intr_mask at 0 causes
iris_vpu_watchdog() to ignore hardware watchdog interrupts.
> + reg = <0 0xaa00000 0 0xf0000>;
> +
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> +
> + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
> + <&videocc VIDEO_CC_MVS0_GDSC>,
> + <&rpmhpd RPMHPD_MX>,
> + <&rpmhpd RPMHPD_CX>;
> + power-domain-names = "venus",
> + "vcodec0",
> + "mxc",
> + "mmcx";
[ ... ]
> + #address-cells = <1>;
> + #size-cells = <1>;
> + dma-ranges = <0x0 0x0 0x0 0xe0000000>;
> +
> + status = "disabled";
> +
> + non-pixel {
> + iommus = <&apps_smmu 0x1940 0x0>;
> + iommu-ranges = <0x25800000 0xba800000>;
> + };
> +
> + pixel {
> + iommus = <&apps_smmu 0x1947 0x0>;
> + };
[Severity: High]
Will placing iommus inside the non-pixel and pixel child nodes instead of
on video-codec@aa00000 cause iris_probe() to fail with -ENOMEM?
The qcom,sm8550-iris binding requires iommus directly on the video-codec
node and does not define #address-cells, #size-cells, dma-ranges, or the
non-pixel and pixel child nodes. At runtime, iris_probe() does not parse
those child nodes and instead calls iris_reserve_iova_region() ->
dma_iova_try_alloc() directly on the top-level platform device, which fails
with -ENOMEM because the device has no IOMMU attached.
> +
> + iris_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-192000000 {
> + opp-hz = /bits/ 64 <192000000>;
> + required-opps = <&rpmhpd_opp_low_svs_d1>,
> + <&rpmhpd_opp_low_svs_d1>;
> + };
> +
> + opp-240000000 {
> + opp-hz = /bits/ 64 <240000000>;
> + required-opps = <&rpmhpd_opp_low_svs>,
> + <&rpmhpd_opp_svs>;
> + };
> +
> + opp-338000000 {
> + opp-hz = /bits/ 64 <338000000>;
> + required-opps = <&rpmhpd_opp_svs>,
> + <&rpmhpd_opp_svs>;
> + };
> +
> + opp-366000000 {
> + opp-hz = /bits/ 64 <366000000>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_svs>;
> + };
> +
> + opp-444000000 {
> + opp-hz = /bits/ 64 <444000000>;
> + required-opps = <&rpmhpd_opp_nom>,
> + <&rpmhpd_opp_svs_l1>;
> + };
> +
> + opp-533333333 {
> + opp-hz = /bits/ 64 <533333333>;
> + required-opps = <&rpmhpd_opp_turbo>,
> + <&rpmhpd_opp_svs_l1>;
> + };
> + };
[Severity: High]
Are the MX and CX entries in required-opps swapped relative to
power-domains?
Above, power-domains maps mxc to RPMHPD_MX and mmcx to RPMHPD_CX, and
iris_opp_pd_table_vpu3x attaches them in that order ("mxc" at index 0,
"mmcx" at index 1). In iris_opp_table, however, the first required-opps
entry tracks the CX corner (scaling up to rpmhpd_opp_turbo) while the
second tracks MX (capping at rpmhpd_opp_svs_l1). This under-volts MX to
low_svs at 240 MHz and under-volts CX to svs at 366 MHz and svs_l1 at
444 MHz and 533.33 MHz.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-add_iris_for_eliza-v3-0-02a55a9272ef@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 4/5] arm64: dts: qcom: eliza-mtp: Enable iris video codec
2026-11-17 6:34 [PATCH v3 0/5] media: iris: Enable Iris video codec on Eliza Wangao Wang
` (2 preceding siblings ...)
2026-11-17 6:34 ` [PATCH v3 3/5] arm64: dts: qcom: eliza: Add iris video codec node Wangao Wang
@ 2026-11-17 6:34 ` Wangao Wang
2026-11-17 6:52 ` sashiko-bot
2026-11-17 6:34 ` [PATCH v3 5/5] arm64: dts: qcom: eliza-evk: " Wangao Wang
4 siblings, 1 reply; 9+ messages in thread
From: Wangao Wang @ 2026-11-17 6:34 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, Wangao Wang,
Abel Vesa
The Eliza MTP includes the Iris video codec, but the device tree leaves
the node disabled. Mark it as okay so the video codec driver can probe
on this board.
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-mtp.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
index ee05192adcfb9f79cba59f11001b640a8572cc91..e5a698602dfc7a2d3ad00eade40d4f91a0cee57d 100644
--- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
@@ -430,6 +430,10 @@ &gpu_zap_shader {
firmware-name = "qcom/eliza/gen71700_zap.mbn";
};
+&iris {
+ status = "okay";
+};
+
&mdss {
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 4/5] arm64: dts: qcom: eliza-mtp: Enable iris video codec
2026-11-17 6:34 ` [PATCH v3 4/5] arm64: dts: qcom: eliza-mtp: Enable iris video codec Wangao Wang
@ 2026-11-17 6:52 ` sashiko-bot
0 siblings, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-11-17 6:52 UTC (permalink / raw)
To: Wangao Wang; +Cc: devicetree, robh, conor+dt, media-ci
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] arm64: dts: qcom: eliza-mtp: iris_probe() fails due to
child-node iommus
- [High] media: iris: NULL deref in iris_set_slice_count() from
incomplete eliza_data
--
commit 0429ecb16555afb36c6bba89f407a14fa28f8a19
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>
arm64: dts: qcom: eliza-mtp: Enable iris video codec
This commit enables the iris video codec device tree node on the Eliza MTP
board.
> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index ee05192adcfb9..e5a698602dfc7 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> @@ -430,6 +430,10 @@ &gpu_zap_shader {
> firmware-name = "qcom/eliza/gen71700_zap.mbn";
> };
>
> +&iris {
> + status = "okay";
> +};
[Severity: High]
Does enabling &iris cause iris_probe() to fail with -ENOMEM?
In commit "arm64: dts: qcom: eliza: Add iris video codec node", the
video-codec@aa00000 node places its iommus phandles inside non-pixel and
pixel child nodes rather than on the video-codec node itself:
arch/arm64/boot/dts/qcom/eliza.dtsi {
...
iris: video-codec@aa00000 {
...
non-pixel {
iommus = <&apps_smmu 0x1940 0x0>;
iommu-ranges = <0x25800000 0xba800000>;
};
pixel {
iommus = <&apps_smmu 0x1947 0x0>;
};
};
}
The upstream iris driver does not parse those child nodes and instead
operates directly on the top-level platform device. Because the parent
node has no iommus property, pdev->dev is not attached to apps_smmu and
use_dma_iommu(dev) is false, so iris_probe() -> iris_reserve_iova_region()
-> dma_iova_try_alloc() fails immediately. This layout also fails
dtbs_check against Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml,
which requires iommus on the video-codec node and sets
unevaluatedProperties: false.
[Severity: High]
Can enabling &iris lead to a NULL pointer dereference in
iris_set_slice_count() when encoding with multiple slices?
Enabling this node binds the device to eliza_data (added in commit "media:
iris: Add support for Eliza" in
drivers/media/platform/qcom/iris/iris_platform_vpu3x.c), which omits
.slice_caps, .wd_intr_mask, and .icc_ib_multiplier unlike the other VPU3x
platform descriptors. When a user configures multi-slice mode
(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB or
V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES), iris_set_slice_count()
dereferences inst->core->iris_platform_data->slice_caps unconditionally:
drivers/media/platform/qcom/iris/iris_ctrls.c:iris_set_slice_count() {
...
slice_caps = inst->core->iris_platform_data->slice_caps;
...
if (fps > slice_caps->max_slice_frame_rate ||
(rc_type != HFI_RC_OFF && rc_type != HFI_RC_CBR_CFR &&
...
}
Leaving .wd_intr_mask and .icc_ib_multiplier zero-initialized in
eliza_data also causes iris_vpu_clear_interrupt() and iris_vpu_watchdog()
to ignore hardware watchdog interrupts, and causes iris_set_icc_bw() to
vote 0 peak bandwidth on the video-mem interconnect path.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-add_iris_for_eliza-v3-0-02a55a9272ef@oss.qualcomm.com?part=4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 5/5] arm64: dts: qcom: eliza-evk: Enable iris video codec
2026-11-17 6:34 [PATCH v3 0/5] media: iris: Enable Iris video codec on Eliza Wangao Wang
` (3 preceding siblings ...)
2026-11-17 6:34 ` [PATCH v3 4/5] arm64: dts: qcom: eliza-mtp: Enable iris video codec Wangao Wang
@ 2026-11-17 6:34 ` Wangao Wang
4 siblings, 0 replies; 9+ messages in thread
From: Wangao Wang @ 2026-11-17 6:34 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, Wangao Wang
The Eliza EVK includes the Iris video codec, but the device tree leaves
the node disabled. Mark it as okay so the video codec driver can probe
on this board.
Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-evk.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
index 02e58a4bc91d455278f2ae9a3da60b02448e4fdf..b8e8c67c70b0318a7d24da8ec4031267605c0200 100644
--- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
@@ -209,6 +209,10 @@ gpio_expander1: gpio@3c {
};
};
+&iris {
+ status = "okay";
+};
+
&lpass_vamacro {
pinctrl-0 = <&dmic01_default>, <&dmic23_default>,
<&dmic45_default>, <&dmic67_default>;
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread