From: sashiko-bot@kernel.org
To: "Luo Liu" <Luo.Liu@cixtech.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: add CIX Sky1 DisplayPort transmitter
Date: Tue, 17 Nov 2026 06:58:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-218284@kernel.org> (raw)
In-Reply-To: <20261117064552.85256-2-Luo.Liu@cixtech.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: display: cix,sky1-dp: missing output port in OF
graph schema
- [Low] dt-bindings: display: cix,sky1-dp: unused labels in DTS example
--
commit d98f4d4238cf91c13498054d6c8b154975a5d02b
Author: Luo Liu <Luo.Liu@cixtech.com>
dt-bindings: display: add CIX Sky1 DisplayPort transmitter
This commit adds the Devicetree binding schema and MAINTAINERS entry for
the CIX Sky1 DisplayPort and USB-C DisplayPort transmitters.
> diff --git a/Documentation/devicetree/bindings/display/cix,sky1-dp.yaml b/Documentation/devicetree/bindings/display/cix,sky1-dp.yaml
> new file mode 100644
> index 0000000000000..ec6d02989b580
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/cix,sky1-dp.yaml
[ ... ]
> + phys:
> + maxItems: 1
> + description: DisplayPort PHY the controller transmits through.
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Video input from the Mali D71 display pipeline (Komeda) that drives
> + this controller. The link to the sink is through phys (USB-C combo PHY
> + or the native DP PHY), not a second OF graph port on the DPTX.
[Severity: Medium]
Should this binding use ports with port@0 for the video input and port@1
for the DisplayPort or eDP output instead of a single port property?
The phys property only references the local SoC PHY block, whereas
downstream display sinks such as dp-connector, eDP panels, and USB-C
connectors or muxes link to the transmitter output endpoint via the OF
graph (and eDP panels may also sit under an aux-bus child node). With
only a single port defined and additionalProperties set to false, board
devicetrees cannot describe the connection to the downstream sink without
failing dtbs_check.
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + dp0: dp@14064000 {
> + compatible = "cix,sky1-usbdp";
> + reg = <0x14064000 0x4000>,
> + <0x14050000 0x400>;
> + reg-names = "dp", "rcsu";
> + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&dpc0_apb>, <&dpc0_vid0>, <&dpc0_vid1>;
> + clock-names = "apb", "vid0", "vid1";
> + resets = <&dpc0_rst>;
> + phys = <&usbc0_dp_phy>;
> +
> + port {
> + dp0_0_in: endpoint {
> + remote-endpoint = <&dpu0_pipe0_out>;
> + };
> + };
> + };
[Severity: Low]
Can the unused labels dp0 and dp0_0_in be dropped from the example?
Unreferenced labels in binding examples trigger warnings from
scripts/dtc/dt-check-style in strict mode.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117064552.85256-1-Luo.Liu@cixtech.com?part=1
next prev parent reply other threads:[~2026-11-17 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 6:45 [PATCH v2 0/2] drm/cix: add Sky1 DisplayPort transmitter Luo Liu
2026-11-17 6:45 ` [PATCH v2 1/2] dt-bindings: display: add CIX " Luo Liu
2026-11-17 6:58 ` sashiko-bot [this message]
2026-11-17 6:45 ` [PATCH v2 2/2] drm/cix: add Sky1 DisplayPort transmitter driver Luo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218284@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Luo.Liu@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox