Devicetree
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases
@ 2026-11-17 13:38 Krzysztof Kozlowski
  2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
  2026-11-17 13:50 ` [PATCH 1/2] arm64: dts: freescale: fsl: " sashiko-bot
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 13:38 UTC (permalink / raw)
  To: Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, imx,
	linux-arm-kernel, devicetree, linux-kernel, linux
  Cc: Krzysztof Kozlowski

The dpmac, rtic-, qsgmii-, rgmii-s and other aliases were never approved
by Devicetree maintainers, because they were never documented as actual
ABI.  There is no in-kernel user of these, although there might be
U-Boot.  External DTS users cannot rely on undocumented ABI, thus these
are pretty safe to drop.

No new custom aliases are allowed for years now.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 .../arm64/boot/dts/freescale/fsl-ls1012a.dtsi |  4 ----
 .../boot/dts/freescale/fsl-ls1043a-qds.dts    | 16 ---------------
 .../fsl-ls1043a-tqmls1043a-mbls10xxa.dts      |  8 --------
 .../boot/dts/freescale/fsl-ls1046a-qds.dts    |  4 ----
 .../fsl-ls1046a-tqmls1046a-mbls10xxa.dts      |  8 --------
 .../fsl-ls1088a-tqmls1088a-mbls10xxa.dts      | 20 -------------------
 6 files changed, 60 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index b07022e3b6d5..7e455600f8d5 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -20,10 +20,6 @@ / {
 	aliases {
 		crypto = &crypto;
 		rtc1 = &ftm_alarm0;
-		rtic-a = &rtic_a;
-		rtic-b = &rtic_b;
-		rtic-c = &rtic_c;
-		rtic-d = &rtic_d;
 		sec-mon = &sec_mon;
 	};
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index e850551b16ac..ea4863c9686c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -24,22 +24,6 @@ aliases {
 		serial1 = &duart1;
 		serial2 = &duart2;
 		serial3 = &duart3;
-		sgmii-riser-s1-p1 = &sgmii_phy_s1_p1;
-		sgmii-riser-s2-p1 = &sgmii_phy_s2_p1;
-		sgmii-riser-s3-p1 = &sgmii_phy_s3_p1;
-		sgmii-riser-s4-p1 = &sgmii_phy_s4_p1;
-		qsgmii-s1-p1 = &qsgmii_phy_s1_p1;
-		qsgmii-s1-p2 = &qsgmii_phy_s1_p2;
-		qsgmii-s1-p3 = &qsgmii_phy_s1_p3;
-		qsgmii-s1-p4 = &qsgmii_phy_s1_p4;
-		qsgmii-s2-p1 = &qsgmii_phy_s2_p1;
-		qsgmii-s2-p2 = &qsgmii_phy_s2_p2;
-		qsgmii-s2-p3 = &qsgmii_phy_s2_p3;
-		qsgmii-s2-p4 = &qsgmii_phy_s2_p4;
-		emi1-slot1 = &ls1043mdio_s1;
-		emi1-slot2 = &ls1043mdio_s2;
-		emi1-slot3 = &ls1043mdio_s3;
-		emi1-slot4 = &ls1043mdio_s4;
 	};
 
 	chosen {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-tqmls1043a-mbls10xxa.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-tqmls1043a-mbls10xxa.dts
index e04483fdb908..76a07a0030ae 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-tqmls1043a-mbls10xxa.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-tqmls1043a-mbls10xxa.dts
@@ -19,14 +19,6 @@ / {
 		     "fsl,ls1043a";
 
 	aliases {
-		qsgmii-s1-p1 = &qsgmii1_phy1;
-		qsgmii-s1-p2 = &qsgmii1_phy2;
-		qsgmii-s1-p3 = &qsgmii1_phy3;
-		qsgmii-s1-p4 = &qsgmii1_phy4;
-		qsgmii-s2-p1 = &qsgmii2_phy1;
-		qsgmii-s2-p2 = &qsgmii2_phy2;
-		qsgmii-s2-p3 = &qsgmii2_phy3;
-		qsgmii-s2-p4 = &qsgmii2_phy4;
 		serial0 = &duart0;
 		serial1 = &duart1;
 	};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index 48a6c08fcea8..8c095aafd596 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -24,10 +24,6 @@ aliases {
 		gpio1 = &gpio1;
 		gpio2 = &gpio2;
 		gpio3 = &gpio3;
-		qsgmii-s2-p1 = &qsgmii_phy_s2_p1;
-		qsgmii-s2-p2 = &qsgmii_phy_s2_p2;
-		qsgmii-s2-p3 = &qsgmii_phy_s2_p3;
-		qsgmii-s2-p4 = &qsgmii_phy_s2_p4;
 		serial0 = &duart0;
 		serial1 = &duart1;
 		serial2 = &duart2;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dts
index 43261cda3fcf..e50469c61482 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dts
@@ -18,14 +18,6 @@ / {
 		     "fsl,ls1046a";
 
 	aliases {
-		qsgmii-s1-p1 = &qsgmii1_phy1;
-		qsgmii-s1-p2 = &qsgmii1_phy2;
-		qsgmii-s1-p3 = &qsgmii1_phy3;
-		qsgmii-s1-p4 = &qsgmii1_phy4;
-		qsgmii-s2-p1 = &qsgmii2_phy1;
-		qsgmii-s2-p2 = &qsgmii2_phy2;
-		qsgmii-s2-p3 = &qsgmii2_phy3;
-		qsgmii-s2-p4 = &qsgmii2_phy4;
 		serial0 = &duart0;
 		serial1 = &duart1;
 	};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-tqmls1088a-mbls10xxa.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-tqmls1088a-mbls10xxa.dts
index 181eeab55aa0..d704aac8d9b9 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-tqmls1088a-mbls10xxa.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-tqmls1088a-mbls10xxa.dts
@@ -19,26 +19,6 @@ / {
 		     "fsl,ls1088a";
 
 	aliases {
-		dpmac1 = &dpmac1;
-		dpmac2 = &dpmac2;
-		dpmac3 = &dpmac3;
-		dpmac4 = &dpmac4;
-		dpmac5 = &dpmac5;
-		dpmac6 = &dpmac6;
-		dpmac7 = &dpmac7;
-		dpmac8 = &dpmac8;
-		dpmac9 = &dpmac9;
-		dpmac10 = &dpmac10;
-		qsgmii-s1-p1 = &qsgmii1_phy1;
-		qsgmii-s1-p2 = &qsgmii1_phy2;
-		qsgmii-s1-p3 = &qsgmii1_phy3;
-		qsgmii-s1-p4 = &qsgmii1_phy4;
-		qsgmii-s2-p1 = &qsgmii2_phy1;
-		qsgmii-s2-p2 = &qsgmii2_phy2;
-		qsgmii-s2-p3 = &qsgmii2_phy3;
-		qsgmii-s2-p4 = &qsgmii2_phy4;
-		rgmii-s1 = &rgmii_phy1;
-		rgmii-s2 = &rgmii_phy2;
 		serial0 = &duart0;
 		serial1 = &duart1;
 	};
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: freescale: imx8q: Remove undocumented, unapproved aliases
  2026-11-17 13:38 [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases Krzysztof Kozlowski
@ 2026-11-17 13:38 ` Krzysztof Kozlowski
  2026-11-17 13:47   ` sashiko-bot
  2026-11-17 13:50 ` [PATCH 1/2] arm64: dts: freescale: fsl: " sashiko-bot
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 13:38 UTC (permalink / raw)
  To: Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, imx,
	linux-arm-kernel, devicetree, linux-kernel, linux
  Cc: Krzysztof Kozlowski

The vpu-core aliases were never approved by Devicetree maintainers,
because they were never documented as actual ABI.  Drop them, because no
new custom aliases are allowed for years now.

Important: this will break users of this undocumented ABI, so these
should be updated to use only documented and approved ABI.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 arch/arm64/boot/dts/freescale/imx8qm.dtsi  | 3 ---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 --
 2 files changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index 9f9b34153ad5..f9d1c166bfcc 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -29,9 +29,6 @@ aliases {
 		spi1 = &lpspi1;
 		spi2 = &lpspi2;
 		spi3 = &lpspi3;
-		vpu-core0 = &vpu_core0;
-		vpu-core1 = &vpu_core1;
-		vpu-core2 = &vpu_core2;
 	};
 
 	cpus {
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 7c4a50e0ec9e..82f640efc74e 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -50,8 +50,6 @@ aliases {
 		spi1 = &lpspi1;
 		spi2 = &lpspi2;
 		spi3 = &lpspi3;
-		vpu-core0 = &vpu_core0;
-		vpu-core1 = &vpu_core1;
 	};
 
 	cpus {
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: freescale: imx8q: Remove undocumented, unapproved aliases
  2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
@ 2026-11-17 13:47   ` sashiko-bot
  0 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-17 13:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski, imx, devicetree; +Cc: robh, conor+dt, Frank.Li

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: imx8q: removing vpu-core aliases breaks
  vpu_core_probe()
--

commit 385fa226f80390e2f0c1af946f31494af8162727
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

arm64: dts: freescale: imx8q: Remove undocumented, unapproved aliases

This commit removes the undocumented vpu-core aliases from the i.MX8QM and
i.MX8QXP devicetree files.

> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> index 9f9b34153ad54..f9d1c166bfccd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> @@ -29,9 +29,6 @@ aliases {
>  		spi1 = &lpspi1;
>  		spi2 = &lpspi2;
>  		spi3 = &lpspi3;
> -		vpu-core0 = &vpu_core0;
> -		vpu-core1 = &vpu_core1;
> -		vpu-core2 = &vpu_core2;
>  	};
>  
>  	cpus {
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 7c4a50e0ec9e9..82f640efc74e5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -50,8 +50,6 @@ aliases {
>  		spi1 = &lpspi1;
>  		spi2 = &lpspi2;
>  		spi3 = &lpspi3;
> -		vpu-core0 = &vpu_core0;
> -		vpu-core1 = &vpu_core1;
>  	};
>  
>  	cpus {

[Severity: High]
Does removing the vpu-core aliases before updating the in-tree Amphion VPU
driver break VPU probing on all i.MX8QM and i.MX8QXP boards?

drivers/media/platform/amphion/vpu_core.c:vpu_core_probe() {
	...
	core->id = of_alias_get_id(dev->of_node, "vpu-core");
	if (core->id < 0) {
		dev_err(dev, "can't get vpu core id\n");
		return core->id;
	}
	...
}

Without these aliases, of_alias_get_id() returns -ENODEV and vpu_core_probe()
fails unconditionally, whereas vpu_imx8q_set_system_cfg_common() and
vpu_imx8q_on_firmware_loaded() also rely on core->id to select the per-core
register base and populate the firmware boot header.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117133842.245262-3-krzysztof.kozlowski@oss.qualcomm.com?part=2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases
  2026-11-17 13:38 [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases Krzysztof Kozlowski
  2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
@ 2026-11-17 13:50 ` sashiko-bot
  1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-17 13:50 UTC (permalink / raw)
  To: Krzysztof Kozlowski, imx, devicetree; +Cc: robh, conor+dt, Frank.Li

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: freescale: incomplete alias cleanup in
  fsl-ls1046a-qds.dts
--

commit 54e57023b3aee0e459e326a808c4fb4cbc55b171
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases

This commit removes undocumented custom aliases such as dpmac, rtic-,
qsgmii-, sgmii-riser-, rgmii-, and emi1-slot* from several Freescale
Layerscape devicetree files.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index e850551b16acb..ea4863c9686c7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -24,22 +24,6 @@ aliases {
>  		serial1 = &duart1;
>  		serial2 = &duart2;
>  		serial3 = &duart3;
> -		sgmii-riser-s1-p1 = &sgmii_phy_s1_p1;
> -		sgmii-riser-s2-p1 = &sgmii_phy_s2_p1;
> -		sgmii-riser-s3-p1 = &sgmii_phy_s3_p1;
> -		sgmii-riser-s4-p1 = &sgmii_phy_s4_p1;
> -		qsgmii-s1-p1 = &qsgmii_phy_s1_p1;
> -		qsgmii-s1-p2 = &qsgmii_phy_s1_p2;
> -		qsgmii-s1-p3 = &qsgmii_phy_s1_p3;
> -		qsgmii-s1-p4 = &qsgmii_phy_s1_p4;
> -		qsgmii-s2-p1 = &qsgmii_phy_s2_p1;
> -		qsgmii-s2-p2 = &qsgmii_phy_s2_p2;
> -		qsgmii-s2-p3 = &qsgmii_phy_s2_p3;
> -		qsgmii-s2-p4 = &qsgmii_phy_s2_p4;
> -		emi1-slot1 = &ls1043mdio_s1;
> -		emi1-slot2 = &ls1043mdio_s2;
> -		emi1-slot3 = &ls1043mdio_s3;
> -		emi1-slot4 = &ls1043mdio_s4;
>  	};

[ ... ]

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index 48a6c08fcea82..8c095aafd5968 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -24,10 +24,6 @@ aliases {
>  		gpio1 = &gpio1;
>  		gpio2 = &gpio2;
>  		gpio3 = &gpio3;
> -		qsgmii-s2-p1 = &qsgmii_phy_s2_p1;
> -		qsgmii-s2-p2 = &qsgmii_phy_s2_p2;
> -		qsgmii-s2-p3 = &qsgmii_phy_s2_p3;
> -		qsgmii-s2-p4 = &qsgmii_phy_s2_p4;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &duart2;

[Severity: Low]
Should the emi1-slot* and sgmii-s* aliases in this node also be removed, as
was done for fsl-ls1043a-qds.dts above?

Because the aliases in fsl-ls1046a-qds.dts are sorted alphabetically around
gpio0..3 and serial0..3, only the middle qsgmii-s2-p* group was dropped,
leaving the other undocumented MDIO mux and PHY aliases introduced by
63c396414bfc ("arm64: dts: ls1046a-qds: add mmio based mdio-mux nodes for
FPGA"):

arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts:
	aliases {
		emi1-slot1 = &ls1046mdio_s1;
		emi1-slot2 = &ls1046mdio_s2;
		emi1-slot4 = &ls1046mdio_s4;
		...
		serial3 = &duart3;
		sgmii-s1-p1 = &sgmii_phy_s1_p1;
		sgmii-s1-p2 = &sgmii_phy_s1_p2;
		sgmii-s1-p3 = &sgmii_phy_s1_p3;
		sgmii-s1-p4 = &sgmii_phy_s1_p4;
		sgmii-s4-p1 = &sgmii_phy_s4_p1;
	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117133842.245262-3-krzysztof.kozlowski@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-17 13:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 13:38 [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
2026-11-17 13:47   ` sashiko-bot
2026-11-17 13:50 ` [PATCH 1/2] arm64: dts: freescale: fsl: " sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox