* [PATCH 1/2] arm64: dts: qcom: Remove undocumented, unapproved aliases
@ 2026-11-17 13:38 Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 13:38 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The usid, sdhc, display and ufshc aliases were never approved by
Devicetree maintainers, because they were never documented as actual
ABI. There is no in-kernel user of these, although there might be
U-Boot. External DTS users cannot rely on undocumented ABI, thus these
are pretty safe to drop.
No new custom aliases are allowed for years now.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 1 -
arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts | 1 -
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi | 1 -
arch/arm64/boot/dts/qcom/msm8916-mtp.dts | 1 -
arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 1 -
arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 2 --
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 1 -
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 1 -
8 files changed, 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index ba6ccf0db16a..9641e286bc2e 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -22,7 +22,6 @@ aliases {
mmc1 = &sdhc_2; /* SD card */
serial0 = &blsp_uart2;
serial1 = &blsp_uart1;
- usid0 = &pm8916_0;
i2c0 = &blsp_i2c2;
i2c1 = &blsp_i2c6;
i2c3 = &blsp_i2c4;
diff --git a/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts b/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
index ce75046ffdac..3f014c74979d 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
@@ -27,7 +27,6 @@ aliases {
serial0 = &blsp_uart1;
serial1 = &blsp_uart2;
spi0 = &blsp_spi5;
- usid0 = &pm8916_0;
};
chosen {
diff --git a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
index 22f764b8d721..277666a54470 100644
--- a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
@@ -14,7 +14,6 @@ aliases {
serial1 = &uart12;
serial2 = &uart17;
spi16 = &spi16;
- ufshc1 = &ufs_mem_hc;
};
chosen {
diff --git a/arch/arm64/boot/dts/qcom/msm8916-mtp.dts b/arch/arm64/boot/dts/qcom/msm8916-mtp.dts
index 63d476523544..36e79b3888e0 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-mtp.dts
@@ -14,7 +14,6 @@ / {
aliases {
serial0 = &blsp_uart2;
- usid0 = &pm8916_0;
};
chosen {
diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
index e99d2a56dc28..ffebbc7b60a4 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
@@ -21,7 +21,6 @@ aliases {
serial0 = &uart4;
serial1 = &uart2;
serial2 = &uart3;
- sdhc1 = &sdhc_1;
};
chosen {
diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
index bf6fb12ad990..6fb2570f5984 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
@@ -17,8 +17,6 @@ / {
aliases {
serial0 = &uart4;
serial1 = &uart3;
- sdhc1 = &sdhc_1;
- sdhc2 = &sdhc_2;
};
chosen {
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index d6af679abe1a..e737998cae4b 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -24,7 +24,6 @@ / {
aliases {
serial0 = &uart12;
serial1 = &uart6;
- sdhc2 = &sdhc_2;
};
chosen {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 1b0eaeafbd51..9ceea625238f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -23,7 +23,6 @@ / {
qcom,board-id = <11 0>;
aliases {
- display0 = &framebuffer;
serial0 = &uart9;
serial1 = &uart6;
};
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases
2026-11-17 13:38 [PATCH 1/2] arm64: dts: qcom: Remove undocumented, unapproved aliases Krzysztof Kozlowski
@ 2026-11-17 13:38 ` Krzysztof Kozlowski
2026-11-17 13:54 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 13:38 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
hsuart aliases are deprecated and not needed since 2021
commit 08b0adb1ae54 ("serial: qcom_geni_serial: use DT aliases according
to DT bindings"), because users should use standard and approved
"serial" alias.
Remove these deprecated aliases. This might affect other projects if
they did not update themselves from 2021 to use approved ABI.
No new custom aliases are allowed for years now.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 1 -
arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts | 2 +-
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 -
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 -
4 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
index d9c70897b6f1..fccd0931a969 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
@@ -21,7 +21,6 @@ / {
aliases {
bluetooth0 = &bluetooth;
- hsuart0 = &uart3;
serial0 = &uart8;
wifi0 = &wifi;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
index 3100fab18787..58b93c49ccf1 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
@@ -21,7 +21,7 @@ / {
aliases {
bluetooth0 = &bluetooth;
- hsuart0 = &uart3;
+ serial0 = &uart3;
wifi0 = &wifi;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index acfb9937651d..7d830b25d8c6 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -21,7 +21,6 @@ / {
aliases {
bluetooth0 = &bluetooth;
- hsuart0 = &uart3;
serial0 = &uart8;
wifi0 = &wifi;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 0e0bc8543f71..560a650b0966 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -90,7 +90,6 @@ mdata_mem: mpss-metadata {
aliases {
bluetooth0 = &bluetooth;
- hsuart0 = &uart3;
serial0 = &uart8;
wifi0 = &wifi;
};
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases Krzysztof Kozlowski
@ 2026-11-17 13:54 ` sashiko-bot
0 siblings, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-17 13:54 UTC (permalink / raw)
To: Krzysztof Kozlowski, devicetree; +Cc: robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: missing serial1 alias for uart3 when
removing hsuart0
--
commit 89fde105212b474add4ece5c8204ee69246c787d
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
arm64: dts: qcom: Remove deprecated hsuart aliases
This commit removes the deprecated hsuart0 aliases from four SC7180 device
tree files, replacing hsuart0 with serial0 in sc7180-ecs-liva-qc710.dts.
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index d9c70897b6f1c..fccd0931a9693 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -21,7 +21,6 @@ / {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> serial0 = &uart8;
> wifi0 = &wifi;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
> index 3100fab18787a..58b93c49ccf18 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
> @@ -21,7 +21,7 @@ / {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> + serial0 = &uart3;
> wifi0 = &wifi;
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index acfb9937651d6..7d830b25d8c66 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -21,7 +21,6 @@ / {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> serial0 = &uart8;
> wifi0 = &wifi;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 0e0bc8543f714..560a650b09662 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -90,7 +90,6 @@ mdata_mem: mpss-metadata {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> serial0 = &uart8;
> wifi0 = &wifi;
> };
[Severity: Medium]
Should sc7180-acer-aspire1.dts, sc7180-idp.dts and sc7180-trogdor.dtsi
replace hsuart0 = &uart3 with serial1 = &uart3 instead of dropping the
alias for &uart3?
In all three files &uart3 is enabled for the Bluetooth serdev, while
serial0 points to &uart8. Commit 08b0adb1ae54 ("serial: qcom_geni_serial:
use DT aliases according to DT bindings") switched to looking up "serial"
aliases, but qcom_geni_serial_probe() still required an alias and failed
with -ENXIO for unaliased non-console UARTs until commit a53be6945f51
("serial: qcom-geni: Remove alias dependency from qcom serial driver").
Leaving &uart3 without a serial1 alias breaks Bluetooth on kernels and
projects implementing the 2021 serial alias ABI, and shifts &uart3 from
ttyHS0 to ttyHS1 via dynamic IDA allocation on newer kernels.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117133825.245191-3-krzysztof.kozlowski@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-17 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 13:38 [PATCH 1/2] arm64: dts: qcom: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases Krzysztof Kozlowski
2026-11-17 13:54 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox