From: sashiko-bot@kernel.org
To: "Faruque Ansari" <faruque.ansari@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM
Date: Wed, 18 Nov 2026 02:48:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-219983@kernel.org> (raw)
In-Reply-To: <20261117-monaco-draco-v1-2-e42d1673148d@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: monaco-draco-ac-som: invalid PCIe PHY
supply properties
--
commit c00686d30929a8eca1aceca9e9e89e0a90a7e47e
Author: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
arm64: dts: qcom: add Monaco Draco AC SoM
This commit adds the initial device tree include for the QCS8300-based
Monaco Draco AC SoM, configuring PMM8654AU RPMH regulators, remoteprocs,
storage, USB, GPU, and PCIe/DisplayPort PHYs.
> diff --git a/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi b/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi
> new file mode 100644
> index 0000000000000..294ed0b6f8987
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi
[ ... ]
> +&pcie0_phy {
> + vdda-phy-supply = <&vreg_l6a>;
> + vdda-pll-supply = <&vreg_l5a>;
> + vdda-qref-supply = <&vreg_l4a>;
> + vdda-refgen-supply = <&vreg_l7a>;
> +
> + status = "okay";
> +};
> +
> +&pcie1_phy {
> + vdda-phy-supply = <&vreg_l6a>;
> + vdda-pll-supply = <&vreg_l5a>;
> + vdda-qref-supply = <&vreg_l4a>;
> + vdda-refgen-supply = <&vreg_l7a>;
> +
> + status = "okay";
> +};
[Severity: Medium]
Should vdda-refgen-supply and vdda-qref-supply be dropped from pcie0_phy
and pcie1_phy?
In monaco.dtsi, pcie0_phy uses compatible qcom,qcs8300-qmp-gen4x2-pcie-phy
and pcie1_phy uses qcom,sa8775p-qmp-gen4x4-pcie-phy. The binding
Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml sets
additionalProperties: false and does not define vdda-refgen-supply, which
causes dtbs_check validation to fail for boards including this SoM dtsi.
In addition, qcs8300_qmp_gen4x2_pciephy_cfg and
sa8775p_qmp_gen4x4_pciephy_cfg in drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
both use qmp_phy_vreg_l, which only requests vdda-phy and vdda-pll, so
neither vdda-qref-supply nor vdda-refgen-supply is enabled by the driver.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-monaco-draco-v1-0-e42d1673148d@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-18 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 2:42 [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support Faruque Ansari
2026-11-17 2:42 ` [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board Faruque Ansari
2026-11-17 2:42 ` [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM Faruque Ansari
2026-11-18 2:48 ` sashiko-bot [this message]
2026-11-17 2:42 ` [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board Faruque Ansari
2026-11-18 2:48 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219983@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=faruque.ansari@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox