Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support
@ 2026-11-17  2:42 Faruque Ansari
  2026-11-17  2:42 ` [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board Faruque Ansari
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Faruque Ansari @ 2026-11-17  2:42 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Richard Cochran
  Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Vishnu Saini,
	Khalid Faisal Ansari, Dipa Mantre, Sravani Tella, Monish Chunara,
	Ajinkya Inchure, Faruque Ansari, Kishor Buchi

This series adds device tree support for the Monaco Draco EVK, an
evaluation kit based on the QCS8300 SoC targeting automotive and
industrial use cases. The platform consists of a System on Module
(SoM) paired with the Draco carrier board.

The Monaco Draco AC SoM integrates the QCS8300 SoC, two PMM8654AU
PMICs, eMMC and UFS storage, USB0/USB1, the Adreno 623 GPU, USB
and UART interfaces.

The Draco carrier board builds on the SoM and adds:
 - DWMAC gigabit Ethernet (2500base-x to HSGMII PHY), MAC from EEPROM
 - AMC6821 fan controller on i2c13
 - I2C GPIO expanders (4x kts1622 on i2c14, 2x tca9538 on i2c15)
 - Native DisplayPort output (DP0) to an on-board DP connector
 - Dual PCIe (pcie0/pcie1) via an on-board TC9563 PCIe switch
 - ST33HTPM TPM over SPI10
 - M.2 E-key slot connectivity

Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
---
Faruque Ansari (3):
      dt-bindings: arm: qcom: add Monaco Draco EVK board
      arm64: dts: qcom: add Monaco Draco AC SoM
      arm64: dts: qcom: add Monaco Draco EVK board

 Documentation/devicetree/bindings/arm/qcom.yaml   |   5 +
 arch/arm64/boot/dts/qcom/Makefile                 |   5 +
 arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi | 319 +++++++++++++
 arch/arm64/boot/dts/qcom/monaco-draco-evk.dts     | 546 ++++++++++++++++++++++
 4 files changed, 875 insertions(+)
---
base-commit: 6d0933ae9d46674a6ea63a87e9e9ab4e662670c9
change-id: 20261105-monaco-draco-2d725f0d891d

Best regards,
-- 
Faruque Ansari <faruque.ansari@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board
  2026-11-17  2:42 [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support Faruque Ansari
@ 2026-11-17  2:42 ` Faruque Ansari
  2026-11-17  2:42 ` [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM Faruque Ansari
  2026-11-17  2:42 ` [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board Faruque Ansari
  2 siblings, 0 replies; 6+ messages in thread
From: Faruque Ansari @ 2026-11-17  2:42 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Richard Cochran
  Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Vishnu Saini,
	Khalid Faisal Ansari, Dipa Mantre, Sravani Tella, Monish Chunara,
	Ajinkya Inchure, Faruque Ansari

Document the compatible strings for the Qualcomm Monaco Draco AC
System-on-Module (SoM) and its Monaco Draco EVK board.

The SoM is populated with a QCS8300 SoC, two PMM8654AU PMICs, eMMC and
UFS storage. The SoM is then connected to the EVK carrier board, which
provides a multitude of connectors for peripherals.

Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 121ca557ce1e..d78bd8a9e373 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -472,6 +472,11 @@ properties:
               - qcom,qcs8300-ride
           - const: qcom,qcs8300
 
+      - items:
+          - const: qcom,monaco-draco-evk
+          - const: qcom,monaco-draco-ac-som
+          - const: qcom,qcs8300
+
       - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
         items:
           - enum:

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM
  2026-11-17  2:42 [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support Faruque Ansari
  2026-11-17  2:42 ` [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board Faruque Ansari
@ 2026-11-17  2:42 ` Faruque Ansari
  2026-11-18  2:48   ` sashiko-bot
  2026-11-17  2:42 ` [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board Faruque Ansari
  2 siblings, 1 reply; 6+ messages in thread
From: Faruque Ansari @ 2026-11-17  2:42 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Richard Cochran
  Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Vishnu Saini,
	Khalid Faisal Ansari, Dipa Mantre, Sravani Tella, Monish Chunara,
	Ajinkya Inchure, Faruque Ansari, Kishor Buchi

Introduce the device tree for the QCS8300-based Monaco Draco AC
SoM. The Monaco Draco AC SoM is a compact compute module integrating
the QCS8300 SoC, two PMM8654AU PMICs, eMMC, UFS storage, an Adreno
623 GPU, USB and UART interfaces, designed to mount on carrier
boards.

The initial SoM device tree includes basic support for:

 - RPMH regulators for two PMM8654AU PMICs
 - QUP firmware paths (qupv3_id_0/1)
 - Remoteproc instances (ADSP, CDSP, GPDSP) with firmware paths
 - Console UART (uart7, serial0) and secondary UART (uart6, serial2)
 - eMMC storage
 - UFS storage
 - USB1 in peripheral mode with HS PHY and QMP SuperSpeed PHY, and USB2
   with HS PHY
 - GPU (Adreno 623) with ZAP shader firmware

Co-developed-by: Kishor Buchi <kbuchi@qti.qualcomm.com>
Signed-off-by: Kishor Buchi <kbuchi@qti.qualcomm.com>
Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi | 319 ++++++++++++++++++++++
 1 file changed, 319 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi b/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi
new file mode 100644
index 000000000000..294ed0b6f898
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi
@@ -0,0 +1,319 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+#include "monaco.dtsi"
+#include "monaco-pmics.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart7;
+		serial2 = &uart6;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	/* This comes from a PMIC handled within the SAIL domain */
+	vreg_s2s: vreg-s2s {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_s2s";
+
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+};
+
+&apps_rsc {
+	regulators-0 {
+		compatible = "qcom,pmm8654au-rpmh-regulators";
+		qcom,pmic-id = "a";
+
+		vreg_l3a: ldo3 {
+			regulator-name = "vreg_l3a";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l4a: ldo4 {
+			regulator-name = "vreg_l4a";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l5a: ldo5 {
+			regulator-name = "vreg_l5a";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l6a: ldo6 {
+			regulator-name = "vreg_l6a";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l7a: ldo7 {
+			regulator-name = "vreg_l7a";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l8a: ldo8 {
+			regulator-name = "vreg_l8a";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l9a: ldo9 {
+			regulator-name = "vreg_l9a";
+			regulator-min-microvolt = <2970000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s4a: smps4 {
+			regulator-name = "vreg_s4a";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s9a: smps9 {
+			regulator-name = "vreg_s9a";
+			regulator-min-microvolt = <1352000>;
+			regulator-max-microvolt = <1352000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-1 {
+		compatible = "qcom,pmm8654au-rpmh-regulators";
+		qcom,pmic-id = "c";
+
+		vreg_l1c: ldo1 {
+			regulator-name = "vreg_l1c";
+			regulator-min-microvolt = <300000>;
+			regulator-max-microvolt = <512000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2c: ldo2 {
+			regulator-name = "vreg_l2c";
+			regulator-min-microvolt = <900000>;
+			regulator-max-microvolt = <904000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l4c: ldo4 {
+			regulator-name = "vreg_l4c";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l7c: ldo7 {
+			regulator-name = "vreg_l7c";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l8c: ldo8 {
+			regulator-name = "vreg_l8c";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l9c: ldo9 {
+			regulator-name = "vreg_l9c";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-allow-set-load;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s5c: smps5 {
+			regulator-name = "vreg_s5c";
+			regulator-min-microvolt = <1104000>;
+			regulator-max-microvolt = <1104000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+};
+
+&gpu {
+	status = "okay";
+};
+
+&gpu_zap_shader {
+	firmware-name = "qcom/qcs8300/a623_zap.mbn";
+};
+
+&mdss_dp0_phy {
+	vdda-phy-supply = <&vreg_l5a>;
+	vdda-pll-supply = <&vreg_l4a>;
+
+	status = "okay";
+};
+
+&pcie0_phy {
+	vdda-phy-supply = <&vreg_l6a>;
+	vdda-pll-supply = <&vreg_l5a>;
+	vdda-qref-supply = <&vreg_l4a>;
+	vdda-refgen-supply = <&vreg_l7a>;
+
+	status = "okay";
+};
+
+&pcie1_phy {
+	vdda-phy-supply = <&vreg_l6a>;
+	vdda-pll-supply = <&vreg_l5a>;
+	vdda-qref-supply = <&vreg_l4a>;
+	vdda-refgen-supply = <&vreg_l7a>;
+
+	status = "okay";
+};
+
+&qupv3_id_0 {
+	firmware-name = "qcom/qcs8300/qupv3fw.elf";
+
+	status = "okay";
+};
+
+&qupv3_id_1 {
+	firmware-name = "qcom/qcs8300/qupv3fw.elf";
+
+	status = "okay";
+};
+
+&remoteproc_adsp {
+	firmware-name = "qcom/qcs8300/adsp.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_cdsp {
+	firmware-name = "qcom/qcs8300/cdsp0.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_gpdsp {
+	firmware-name = "qcom/qcs8300/gpdsp0.mbn";
+
+	status = "okay";
+};
+
+&sdhc_1 {
+	vmmc-supply = <&vreg_l8a>;
+	vqmmc-supply = <&vreg_s2s>;
+
+	no-sd;
+	no-sdio;
+	non-removable;
+
+	status = "okay";
+};
+
+&serdes0 {
+	vdda-0p9-supply = <&vreg_l4a>;
+	vdda-1p2-supply = <&vreg_l5a>;
+
+	status = "okay";
+};
+
+&uart6 {
+	status = "okay";
+};
+
+&uart7 {
+	status = "okay";
+};
+
+&ufs_mem_hc {
+	reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+	vcc-supply = <&vreg_l8a>;
+	vcc-max-microamp = <1100000>;
+	vccq-supply = <&vreg_l4c>;
+	vccq-max-microamp = <1200000>;
+
+	status = "okay";
+};
+
+&ufs_mem_phy {
+	vdda-phy-supply = <&vreg_l4a>;
+	vdda-pll-supply = <&vreg_l5a>;
+
+	status = "okay";
+};
+
+&usb_1 {
+	dr_mode = "peripheral";
+
+	status = "okay";
+};
+
+&usb_1_hsphy {
+	vdda-pll-supply = <&vreg_l7a>;
+	vdda18-supply = <&vreg_l7c>;
+	vdda33-supply = <&vreg_l9a>;
+
+	status = "okay";
+};
+
+&usb_qmpphy {
+	vdda-phy-supply = <&vreg_l7a>;
+	vdda-pll-supply = <&vreg_l5a>;
+
+	status = "okay";
+};
+
+&usb_2 {
+	status = "okay";
+};
+
+&usb_2_hsphy {
+	vdda-pll-supply = <&vreg_l7a>;
+	vdda18-supply = <&vreg_l7c>;
+	vdda33-supply = <&vreg_l9a>;
+
+	status = "okay";
+};

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board
  2026-11-17  2:42 [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support Faruque Ansari
  2026-11-17  2:42 ` [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board Faruque Ansari
  2026-11-17  2:42 ` [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM Faruque Ansari
@ 2026-11-17  2:42 ` Faruque Ansari
  2026-11-18  2:48   ` sashiko-bot
  2 siblings, 1 reply; 6+ messages in thread
From: Faruque Ansari @ 2026-11-17  2:42 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Richard Cochran
  Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Vishnu Saini,
	Khalid Faisal Ansari, Dipa Mantre, Sravani Tella, Monish Chunara,
	Ajinkya Inchure, Faruque Ansari

The Monaco Draco EVK pairs the Monaco Draco AC SoM with the Draco
carrier board. Add its device tree, describing the board-specific
peripherals layered on top of the SoM:

 - I2C GPIO expanders: 4x KTS1622 on i2c14 and 2x TCA9538 on i2c15
 - EEPROM with a MAC-address nvmem layout on i2c15
 - Native DisplayPort output (DP0)
 - Gigabit Ethernet (ethernet0, 2500base-x) over an HSGMII PHY, with
   the MAC address sourced from the EEPROM
 - Dual PCIe (pcie0/pcie1) behind an on-board TC9563 PCIe switch
 - ST33HTPM TPM over spi10
 - AMC6821 fan controller on i2c13
 - M.2 E-key slot connector and carrier debug UART (uart2)

Also hook the board dtb into the Makefile, together with an EL2
overlay variant that boots the kernel at EL2 for KVM.

Co-developed-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Co-developed-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Co-developed-by: Dipa Mantre <dipa.mantre@oss.qualcomm.com>
Signed-off-by: Dipa Mantre <dipa.mantre@oss.qualcomm.com>
Co-developed-by: Sravani Tella <tella@hu-tella-hyd.qualcomm.com>
Signed-off-by: Sravani Tella <tella@hu-tella-hyd.qualcomm.com>
Co-developed-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Co-developed-by: Ajinkya Inchure <ainchure@qti.qualcomm.com>
Signed-off-by: Ajinkya Inchure <ainchure@qti.qualcomm.com>
Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/Makefile             |   5 +
 arch/arm64/boot/dts/qcom/monaco-draco-evk.dts | 546 ++++++++++++++++++++++++++
 2 files changed, 551 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 88230c4e00ea..7212bd1d2358 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -69,6 +69,11 @@ dtb-$(CONFIG_ARCH_QCOM)	+= milos-fairphone-fp6.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= milos-nothing-asteroids.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= monaco-arduino-monza.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= monaco-ac-evk.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= monaco-draco-evk.dtb
+
+monaco-draco-evk-el2-dtbs := monaco-draco-evk.dtb monaco-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM)	+= monaco-draco-evk-el2.dtb
+
 dtb-$(CONFIG_ARCH_QCOM)	+= monaco-evk.dtb
 
 monaco-evk-camera-imx577-dtbs	:= monaco-evk.dtb monaco-evk-camera-imx577.dtbo
diff --git a/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts
new file mode 100644
index 000000000000..ad416f586514
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts
@@ -0,0 +1,546 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/pwm/pwm.h>
+
+#include "monaco-draco-ac-som.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. Monaco Draco EVK";
+	compatible = "qcom,monaco-draco-evk", "qcom,monaco-draco-ac-som",
+		     "qcom,qcs8300";
+	chassis-type = "embedded";
+
+	aliases {
+		ethernet0 = &ethernet0;
+		serial1 = &uart2;
+	};
+
+	vreg_0p9: regulator-0v9 {
+		compatible = "regulator-fixed";
+		regulator-name = "VREG_0P9";
+		regulator-min-microvolt = <900000>;
+		regulator-max-microvolt = <900000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vreg_1p8: regulator-1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "VREG_1P8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vreg_keye_3p3: regulator-keye-3p3 {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_keye_3p3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	vreg_dp0_pwr: regulator-dp0-pwr {
+		compatible = "regulator-fixed";
+		regulator-name = "VREG_DP0_PWR_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&expander1 7 GPIO_ACTIVE_HIGH>;
+	};
+
+	dp0-connector {
+		compatible = "dp-connector";
+		label = "DP0";
+		type = "full-size";
+		dp-pwr-supply = <&vreg_dp0_pwr>;
+
+		port {
+			dp0_connector_in: endpoint {
+				remote-endpoint = <&mdss_dp0_out>;
+			};
+		};
+	};
+
+	wifi-bt-connector {
+		compatible = "pcie-m2-e-connector";
+		vpcie3v3-supply = <&vreg_keye_3p3>;
+
+		w-disable2-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
+
+		pinctrl-0 = <&bt_en>;
+		pinctrl-names = "default";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				m2_e_pcie_ep: endpoint@0 {
+					reg = <0>;
+					remote-endpoint = <&tc9563_pcie1_ep>;
+				};
+			};
+
+			port@3 {
+				reg = <3>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				m2_e_uart_ep: endpoint@0 {
+					reg = <0>;
+					remote-endpoint = <&uart2_ep>;
+				};
+			};
+		};
+	};
+};
+
+&ethernet0 {
+	phy-handle = <&hsgmii_phy0>;
+	phy-mode = "2500base-x";
+
+	pinctrl-0 = <&ethernet0_default>;
+	pinctrl-names = "default";
+
+	snps,mtl-rx-config = <&mtl_rx_setup>;
+	snps,mtl-tx-config = <&mtl_tx_setup>;
+
+	nvmem-cells = <&mac_addr0>;
+	nvmem-cell-names = "mac-address";
+
+	status = "okay";
+
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hsgmii_phy0: ethernet-phy@1c {
+			compatible = "ethernet-phy-id004d.d101";
+			reg = <0x1c>;
+			reset-gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <11000>;
+			reset-deassert-us = <70000>;
+		};
+	};
+
+	mtl_rx_setup: rx-queues-config {
+		snps,rx-queues-to-use = <4>;
+		snps,rx-sched-sp;
+
+		queue0 {
+			snps,dcb-algorithm;
+			snps,map-to-dma-channel = <0x0>;
+			snps,route-up;
+			snps,priority = <0x1>;
+		};
+
+		queue1 {
+			snps,dcb-algorithm;
+			snps,map-to-dma-channel = <0x1>;
+			snps,route-ptp;
+		};
+
+		queue2 {
+			snps,avb-algorithm;
+			snps,map-to-dma-channel = <0x2>;
+			snps,route-avcp;
+		};
+
+		queue3 {
+			snps,avb-algorithm;
+			snps,map-to-dma-channel = <0x3>;
+			snps,priority = <0xc>;
+		};
+	};
+
+	mtl_tx_setup: tx-queues-config {
+		snps,tx-queues-to-use = <4>;
+
+		queue0 {
+			snps,dcb-algorithm;
+		};
+
+		queue1 {
+			snps,dcb-algorithm;
+		};
+
+		queue2 {
+			snps,avb-algorithm;
+			snps,send_slope = <0x1000>;
+			snps,idle_slope = <0x1000>;
+			snps,high_credit = <0x3e800>;
+			snps,low_credit = <0xffc18000>;
+		};
+
+		queue3 {
+			snps,avb-algorithm;
+			snps,send_slope = <0x1000>;
+			snps,idle_slope = <0x1000>;
+			snps,high_credit = <0x3e800>;
+			snps,low_credit = <0xffc18000>;
+		};
+	};
+};
+
+&i2c13 {
+	status = "okay";
+
+	fan_controller: fan@1a {
+		compatible = "ti,amc6821";
+		reg = <0x1a>;
+		#pwm-cells = <2>;
+
+		fan {
+			pwms = <&fan_controller 40000 PWM_POLARITY_INVERTED>;
+		};
+	};
+};
+
+&i2c14 {
+	status = "okay";
+
+	expander0: gpio@20 {
+		compatible = "kinetic,kts1622", "ti,tcal6416";
+		reg = <0x20>;
+		#gpio-cells = <2>;
+		gpio-controller;
+	};
+
+	expander1: gpio@21 {
+		compatible = "kinetic,kts1622", "ti,tcal6416";
+		reg = <0x21>;
+		#gpio-cells = <2>;
+		gpio-controller;
+	};
+
+	expander2: gpio@22 {
+		compatible = "kinetic,kts1622", "ti,tcal6416";
+		reg = <0x22>;
+		#gpio-cells = <2>;
+		gpio-controller;
+	};
+
+	expander3: gpio@23 {
+		compatible = "kinetic,kts1622", "ti,tcal6416";
+		reg = <0x23>;
+		#gpio-cells = <2>;
+		gpio-controller;
+
+		pwr-en0-hog {
+			gpio-hog;
+			gpios = <0 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "pwr_en0";
+		};
+
+		pwr-en1-hog {
+			gpio-hog;
+			gpios = <1 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "pwr_en1";
+		};
+
+		pwr-en4-hog {
+			gpio-hog;
+			gpios = <4 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "pwr_en4";
+		};
+
+		pwr-en6-hog {
+			gpio-hog;
+			gpios = <6 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "pwr_en6";
+		};
+
+		pwr-en8-hog {
+			gpio-hog;
+			gpios = <8 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "pwr_en8";
+		};
+
+		keye-pwr-en1-hog {
+			gpio-hog;
+			gpios = <9 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "keye_pwr_en1";
+		};
+
+		keye-pwr-en2-hog {
+			gpio-hog;
+			gpios = <10 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "keye_pwr_en2";
+		};
+	};
+};
+
+&i2c15 {
+	status = "okay";
+
+	expander4: gpio@38 {
+		compatible = "ti,tca9538";
+		reg = <0x38>;
+		#gpio-cells = <2>;
+		gpio-controller;
+	};
+
+	expander5: gpio@3c {
+		compatible = "ti,tca9538";
+		reg = <0x3c>;
+		#gpio-cells = <2>;
+		gpio-controller;
+	};
+
+	eeprom@50 {
+		compatible = "giantec,gt24c256c", "atmel,24c256";
+		reg = <0x50>;
+		pagesize = <64>;
+
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			mac_addr0: mac-addr@0 {
+				reg = <0x0 0x6>;
+			};
+		};
+	};
+};
+
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
+	pinctrl-0 = <&dp_hot_plug_det>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+	remote-endpoint = <&dp0_connector_in>;
+};
+
+&pcie0 {
+	perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;
+	pinctrl-0 = <&pcie0_default_state>;
+	pinctrl-names = "default";
+
+	iommu-map = <0x0 &pcie_smmu 0x0 0x0 0x1>,
+		    <0x100 &pcie_smmu 0x1 0x0 0x1>,
+		    <0x208 &pcie_smmu 0x2 0x0 0x1>,
+		    <0x210 &pcie_smmu 0x3 0x0 0x1>,
+		    <0x218 &pcie_smmu 0x4 0x0 0x1>,
+		    <0x300 &pcie_smmu 0x5 0x0 0x1>,
+		    <0x400 &pcie_smmu 0x6 0x0 0x1>,
+		    <0x500 &pcie_smmu 0x7 0x0 0x1>,
+		    <0x501 &pcie_smmu 0x8 0x0 0x1>;
+
+	status = "okay";
+};
+
+&pcie1 {
+	perst-gpios = <&tlmm 23 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
+	pinctrl-0 = <&pcie1_default_state>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcieport0 {
+	#address-cells = <3>;
+	#size-cells = <2>;
+
+	pcie@0,0 {
+		compatible = "pci1179,0623";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+		#address-cells = <3>;
+		#size-cells = <2>;
+		device_type = "pci";
+		ranges;
+		bus-range = <0x2 0xff>;
+
+		vddc-supply = <&vreg_0p9>;
+		vdd18-supply = <&vreg_1p8>;
+		vdd09-supply = <&vreg_0p9>;
+		vddio1-supply = <&vreg_1p8>;
+		vddio2-supply = <&vreg_1p8>;
+		vddio18-supply = <&vreg_1p8>;
+		i2c-parent = <&i2c15 0x77>;
+		resx-gpios = <&tlmm 96 GPIO_ACTIVE_LOW>;
+		pinctrl-0 = <&tc9563_resx_n>;
+		pinctrl-names = "default";
+
+		pcie@1,0 {
+			reg = <0x20800 0x0 0x0 0x0 0x0>;
+			#address-cells = <3>;
+			#size-cells = <2>;
+			device_type = "pci";
+			ranges;
+			bus-range = <0x3 0xff>;
+
+			port {
+				tc9563_pcie1_ep: endpoint {
+					remote-endpoint = <&m2_e_pcie_ep>;
+				};
+			};
+		};
+
+		pcie@2,0 {
+			reg = <0x21000 0x0 0x0 0x0 0x0>;
+			#address-cells = <3>;
+			#size-cells = <2>;
+			device_type = "pci";
+			ranges;
+			bus-range = <0x4 0xff>;
+		};
+
+		pcie@3,0 {
+			reg = <0x21800 0x0 0x0 0x0 0x0>;
+			#address-cells = <3>;
+			#size-cells = <2>;
+			device_type = "pci";
+			ranges;
+			bus-range = <0x5 0xff>;
+
+			pcie@0,0 {
+				reg = <0x50000 0x0 0x0 0x0 0x0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				device_type = "pci";
+				ranges;
+			};
+
+			pcie@0,1 {
+				reg = <0x50100 0x0 0x0 0x0 0x0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				device_type = "pci";
+				ranges;
+			};
+		};
+	};
+};
+
+&qup_i2c13_data_clk {
+	drive-strength = <6>;
+	bias-pull-up;
+};
+
+&spi10 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};
+
+&tlmm {
+	bt_en: bt-en-state {
+		pins = "gpio55";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
+	ethernet0_default: ethernet0-default-state {
+		ethernet0_mdc: ethernet0-mdc-pins {
+			pins = "gpio5";
+			function = "emac0_mdc";
+			drive-strength = <16>;
+			bias-pull-up;
+		};
+
+		ethernet0_mdio: ethernet0-mdio-pins {
+			pins = "gpio6";
+			function = "emac0_mdio";
+			drive-strength = <16>;
+			bias-pull-up;
+		};
+	};
+
+	pcie0_default_state: pcie0-default-state {
+		clkreq-pins {
+			pins = "gpio1";
+			function = "pcie0_clkreq";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-pins {
+			pins = "gpio2";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		wake-pins {
+			pins = "gpio0";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	pcie1_default_state: pcie1-default-state {
+		clkreq-pins {
+			pins = "gpio22";
+			function = "pcie1_clkreq";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-pins {
+			pins = "gpio23";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		wake-pins {
+			pins = "gpio21";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	tc9563_resx_n: tc9563-resx-state {
+		pins = "gpio96";
+		function = "gpio";
+		bias-disable;
+		output-high;
+	};
+};
+
+&uart2 {
+	status = "okay";
+
+	port {
+		uart2_ep: endpoint {
+			remote-endpoint = <&m2_e_uart_ep>;
+		};
+	};
+};

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM
  2026-11-17  2:42 ` [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM Faruque Ansari
@ 2026-11-18  2:48   ` sashiko-bot
  0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-11-18  2:48 UTC (permalink / raw)
  To: Faruque Ansari; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: monaco-draco-ac-som: invalid PCIe PHY
  supply properties
--

commit c00686d30929a8eca1aceca9e9e89e0a90a7e47e
Author: Faruque Ansari <faruque.ansari@oss.qualcomm.com>

arm64: dts: qcom: add Monaco Draco AC SoM

This commit adds the initial device tree include for the QCS8300-based
Monaco Draco AC SoM, configuring PMM8654AU RPMH regulators, remoteprocs,
storage, USB, GPU, and PCIe/DisplayPort PHYs.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi b/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi
> new file mode 100644
> index 0000000000000..294ed0b6f8987
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/monaco-draco-ac-som.dtsi

[ ... ]

> +&pcie0_phy {
> +	vdda-phy-supply = <&vreg_l6a>;
> +	vdda-pll-supply = <&vreg_l5a>;
> +	vdda-qref-supply = <&vreg_l4a>;
> +	vdda-refgen-supply = <&vreg_l7a>;
> +
> +	status = "okay";
> +};
> +
> +&pcie1_phy {
> +	vdda-phy-supply = <&vreg_l6a>;
> +	vdda-pll-supply = <&vreg_l5a>;
> +	vdda-qref-supply = <&vreg_l4a>;
> +	vdda-refgen-supply = <&vreg_l7a>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Should vdda-refgen-supply and vdda-qref-supply be dropped from pcie0_phy
and pcie1_phy?

In monaco.dtsi, pcie0_phy uses compatible qcom,qcs8300-qmp-gen4x2-pcie-phy
and pcie1_phy uses qcom,sa8775p-qmp-gen4x4-pcie-phy.  The binding
Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml sets
additionalProperties: false and does not define vdda-refgen-supply, which
causes dtbs_check validation to fail for boards including this SoM dtsi.

In addition, qcs8300_qmp_gen4x2_pciephy_cfg and
sa8775p_qmp_gen4x4_pciephy_cfg in drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
both use qmp_phy_vreg_l, which only requests vdda-phy and vdda-pll, so
neither vdda-qref-supply nor vdda-refgen-supply is enabled by the driver.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-monaco-draco-v1-0-e42d1673148d@oss.qualcomm.com?part=2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board
  2026-11-17  2:42 ` [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board Faruque Ansari
@ 2026-11-18  2:48   ` sashiko-bot
  0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-11-18  2:48 UTC (permalink / raw)
  To: Faruque Ansari; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 6 potential
issues to consider:
- [High] arm64: dts: qcom: non-routable hostname email in Signed-off-by
  trailer
- [High] arm64: dts: qcom: missing enable-active-high on vreg_dp0_pwr
  regulator
- [High] arm64: dts: qcom: misplaced PCIe PERST#/WAKE# GPIOs and wrong
  WAKE# polarity
- [High] arm64: dts: qcom: missing pciclass,0604 compatible on TC9563
  port pcie@1,0
- [Medium] arm64: dts: qcom: TC9563 Ethernet endpoints modeled as PCI
  bridges
- [Low] arm64: dts: qcom: commit message mismatch for uart2 and pcie1
  topology
--

commit 6997fa812fd3a9900d7e8a3fd80ef7fb41e46e05
Author: Faruque Ansari <faruque.ansari@oss.qualcomm.com>

> arm64: dts: qcom: add Monaco Draco EVK board
> 
> The Monaco Draco EVK pairs the Monaco Draco AC SoM with the Draco
> carrier board. Add its device tree, describing the board-specific
> peripherals layered on top of the SoM:
> 
>  - I2C GPIO expanders: 4x KTS1622 on i2c14 and 2x TCA9538 on i2c15
>  - EEPROM with a MAC-address nvmem layout on i2c15
>  - Native DisplayPort output (DP0)
>  - Gigabit Ethernet (ethernet0, 2500base-x) over an HSGMII PHY, with
>    the MAC address sourced from the EEPROM
>  - Dual PCIe (pcie0/pcie1) behind an on-board TC9563 PCIe switch
>  - ST33HTPM TPM over spi10
>  - AMC6821 fan controller on i2c13
>  - M.2 E-key slot connector and carrier debug UART (uart2)
> 
> Also hook the board dtb into the Makefile, together with an EL2
> overlay variant that boots the kernel at EL2 for KVM.
> 
> Co-developed-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Co-developed-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Co-developed-by: Dipa Mantre <dipa.mantre@oss.qualcomm.com>
> Signed-off-by: Dipa Mantre <dipa.mantre@oss.qualcomm.com>
> Co-developed-by: Sravani Tella <tella@hu-tella-hyd.qualcomm.com>
> Signed-off-by: Sravani Tella <tella@hu-tella-hyd.qualcomm.com>
> Co-developed-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> Co-developed-by: Ajinkya Inchure <ainchure@qti.qualcomm.com>
> Signed-off-by: Ajinkya Inchure <ainchure@qti.qualcomm.com>
> Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>

[Severity: High]
The Co-developed-by and Signed-off-by trailers for Sravani Tella use an
internal workstation hostname (tella@hu-tella-hyd.qualcomm.com) rather than
a routable email address.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts
> new file mode 100644
> index 0000000000000..ad416f586514f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts
> @@ -0,0 +1,546 @@

[ ... ]

> +	vreg_dp0_pwr: regulator-dp0-pwr {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VREG_DP0_PWR_3P3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&expander1 7 GPIO_ACTIVE_HIGH>;
> +	};

[Severity: High]
Is vreg_dp0_pwr missing enable-active-high?

For regulator-fixed nodes, of_gpio_quirk_polarity() ignores the phandle
flags in gpio and forces OF_GPIO_ACTIVE_LOW unless enable-active-high is
present, which will invert the DisplayPort 3.3V power enable line.

[ ... ]

> +&pcie0 {
> +	perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
> +	wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;
> +	pinctrl-0 = <&pcie0_default_state>;
> +	pinctrl-names = "default";
> +
> +	iommu-map = <0x0 &pcie_smmu 0x0 0x0 0x1>,
> +		    <0x100 &pcie_smmu 0x1 0x0 0x1>,
> +		    <0x208 &pcie_smmu 0x2 0x0 0x1>,
> +		    <0x210 &pcie_smmu 0x3 0x0 0x1>,
> +		    <0x218 &pcie_smmu 0x4 0x0 0x1>,
> +		    <0x300 &pcie_smmu 0x5 0x0 0x1>,
> +		    <0x400 &pcie_smmu 0x6 0x0 0x1>,
> +		    <0x500 &pcie_smmu 0x7 0x0 0x1>,
> +		    <0x501 &pcie_smmu 0x8 0x0 0x1>;
> +
> +	status = "okay";
> +};
> +
> +&pcie1 {
> +	perst-gpios = <&tlmm 23 GPIO_ACTIVE_LOW>;
> +	wake-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> +	pinctrl-0 = <&pcie1_default_state>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +};

[Severity: High]
Should reset-gpios and wake-gpios be placed on &pcieport0 and &pcieport1
with GPIO_ACTIVE_LOW for wake-gpios instead of on &pcie0 and &pcie1?

pci_configure_of_wake_gpio() looks up wake-gpios on the Root Port PCI
device node rather than the host bridge node, so wake-gpios on &pcie0 and
&pcie1 is never read; in addition, the pulled-up PCIe WAKE# line is
active-low (see 04bc4263d8b7 ("arm64: dts: qcom: monaco: Fix PCIe WAKE#
GPIO polarity")), so GPIO_ACTIVE_HIGH would configure a level-high
interrupt on a line that idles high.  Placing perst-gpios on the host
bridge node when Root Port child nodes exist also triggers a warning in
qcom_pcie_parse_perst() and registers duplicate PERST# descriptors for
each child PCI bridge node.

> +
> +&pcieport0 {
> +	#address-cells = <3>;
> +	#size-cells = <2>;
> +
> +	pcie@0,0 {

[ ... ]

> +		pcie@1,0 {
> +			reg = <0x20800 0x0 0x0 0x0 0x0>;
> +			#address-cells = <3>;
> +			#size-cells = <2>;
> +			device_type = "pci";
> +			ranges;
> +			bus-range = <0x3 0xff>;
> +
> +			port {
> +				tc9563_pcie1_ep: endpoint {
> +					remote-endpoint = <&m2_e_pcie_ep>;
> +				};
> +			};
> +		};

[Severity: High]
Does pcie@1,0 need compatible = "pciclass,0604"?

pci_pwrctrl_is_required() returns false for any bridge node without a
compatible string starting with "pci", and slot_pwrctrl_driver matches
"pciclass,0604".  Without it, no pwrctrl device is created for pcie@1,0 and
the M.2 Key E connector's PCIe power sequence (enabling vpcie3v3-supply) is
never run before PCIe enumeration.

> +
> +		pcie@2,0 {
> +			reg = <0x21000 0x0 0x0 0x0 0x0>;
> +			#address-cells = <3>;
> +			#size-cells = <2>;
> +			device_type = "pci";
> +			ranges;
> +			bus-range = <0x4 0xff>;
> +		};
> +
> +		pcie@3,0 {
> +			reg = <0x21800 0x0 0x0 0x0 0x0>;
> +			#address-cells = <3>;
> +			#size-cells = <2>;
> +			device_type = "pci";
> +			ranges;
> +			bus-range = <0x5 0xff>;
> +
> +			pcie@0,0 {
> +				reg = <0x50000 0x0 0x0 0x0 0x0>;
> +				#address-cells = <3>;
> +				#size-cells = <2>;
> +				device_type = "pci";
> +				ranges;
> +			};
> +
> +			pcie@0,1 {
> +				reg = <0x50100 0x0 0x0 0x0 0x0>;
> +				#address-cells = <3>;
> +				#size-cells = <2>;
> +				device_type = "pci";
> +				ranges;
> +			};
> +		};

[Severity: Medium]
Should the two child nodes under pcie@3,0 be ethernet@0,0 and ethernet@0,1
endpoint nodes rather than PCI bridges?

Under toshiba,tc9563.yaml, pcie@3,0 only permits ^ethernet@0,[0-1]$ child
nodes for the switch's integrated Ethernet MAC endpoints.  Defining them
as pcie@0,0 and pcie@0,1 with device_type = "pci", #address-cells,
#size-cells, and ranges fails dtbs_check and causes PCI bridge walkers
such as qcom_pcie_parse_perst() to treat the endpoints as PCI-to-PCI
bridges.

[ ... ]

> +&uart2 {
> +	status = "okay";
> +
> +	port {
> +		uart2_ep: endpoint {
> +			remote-endpoint = <&m2_e_uart_ep>;
> +		};
> +	};
> +};

[Severity: Low]
The commit message describes uart2 as the "carrier debug UART (uart2)",
whereas here uart2 is wired to the Bluetooth UART port (port@3) of
wifi-bt-connector (and debug console is uart7 in monaco-draco-ac-som.dtsi).
Similarly, the commit message says "Dual PCIe (pcie0/pcie1) behind an
on-board TC9563 PCIe switch", while only pcie0 is connected to the TC9563
switch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-monaco-draco-v1-0-e42d1673148d@oss.qualcomm.com?part=3

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-18  2:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  2:42 [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support Faruque Ansari
2026-11-17  2:42 ` [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board Faruque Ansari
2026-11-17  2:42 ` [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM Faruque Ansari
2026-11-18  2:48   ` sashiko-bot
2026-11-17  2:42 ` [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board Faruque Ansari
2026-11-18  2:48   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox