* [PATCH 0/2] arm64: dts: qcom: Enable WCN7850 on Maili MTP
@ 2026-11-18 3:33 Yijie Yang
2026-11-18 3:33 ` [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support Yijie Yang
2026-11-18 3:33 ` [PATCH 2/2] arm64: dts: qcom: maili-mtp: Add WCN7850 Bluetooth support Yijie Yang
0 siblings, 2 replies; 4+ messages in thread
From: Yijie Yang @ 2026-11-18 3:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, Yijie Yang
Enable WLAN and Bluetooth support for the WCN7850 on the Maili MTP
reworked with the Hamilton module.
Patch 1 describes the shared PMU and PCIe WLAN function. Patch 2 adds
the Bluetooth enable resources and UART connection.
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
---
Yijie Yang (2):
arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support
arm64: dts: qcom: maili-mtp: Add WCN7850 Bluetooth support
arch/arm64/boot/dts/qcom/maili-mtp.dts | 121 +++++++++++++++++++++++++++++++++
1 file changed, 121 insertions(+)
---
base-commit: 7cfbf79c66c63e807ea452abf0546e6f6d6833a6
change-id: 20261023-wlan-bt-52fae6bc38fa
Best regards,
--
Yijie Yang <yijie.yang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support
2026-11-18 3:33 [PATCH 0/2] arm64: dts: qcom: Enable WCN7850 on Maili MTP Yijie Yang
@ 2026-11-18 3:33 ` Yijie Yang
2026-11-18 3:53 ` sashiko-bot
2026-11-18 3:33 ` [PATCH 2/2] arm64: dts: qcom: maili-mtp: Add WCN7850 Bluetooth support Yijie Yang
1 sibling, 1 reply; 4+ messages in thread
From: Yijie Yang @ 2026-11-18 3:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, Yijie Yang
Enable WCN785x Wi-Fi on Maili MTP board.
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/maili-mtp.dts | 88 ++++++++++++++++++++++++++++++++++
1 file changed, 88 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/maili-mtp.dts b/arch/arm64/boot/dts/qcom/maili-mtp.dts
index 5409d0a7ec2e0..a3c2016eb9053 100644
--- a/arch/arm64/boot/dts/qcom/maili-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/maili-mtp.dts
@@ -142,6 +142,63 @@ sdcard_vdd_3p0: sdcard-vdd-3p0 {
vin-supply = <&vreg_bob1>;
};
+
+ wcn7850-pmu {
+ compatible = "qcom,wcn7850-pmu";
+
+ pinctrl-0 = <&wlan_en>, <&sw_ctrl_default>;
+ pinctrl-names = "default";
+
+ wlan-enable-gpios = <&pmh0104_c_e0_gpios 7 GPIO_ACTIVE_HIGH>;
+
+ vdd-supply = <&vreg_s1j_0p8>;
+ vddio-supply = <&vreg_l2d_1p8>;
+ vddio1p2-supply = <&vreg_l4g_1p2>;
+ vddaon-supply = <&vreg_s9d_1p0>;
+ vdddig-supply = <&vreg_s3c_1p2>;
+ vddrfa1p2-supply = <&vreg_s9d_1p0>;
+ vddrfa1p8-supply = <&vreg_s7g_1p2>;
+
+ clocks = <&rpmhcc RPMH_RF_CLK1>;
+
+ regulators {
+ vreg_pmu_rfa_cmn: ldo0 {
+ regulator-name = "vreg_pmu_rfa_cmn";
+ };
+
+ vreg_pmu_aon_0p59: ldo1 {
+ regulator-name = "vreg_pmu_aon_0p59";
+ };
+
+ vreg_pmu_wlcx_0p8: ldo2 {
+ regulator-name = "vreg_pmu_wlcx_0p8";
+ };
+
+ vreg_pmu_wlmx_0p85: ldo3 {
+ regulator-name = "vreg_pmu_wlmx_0p85";
+ };
+
+ vreg_pmu_rfa_0p8: ldo5 {
+ regulator-name = "vreg_pmu_rfa_0p8";
+ };
+
+ vreg_pmu_rfa_1p2: ldo6 {
+ regulator-name = "vreg_pmu_rfa_1p2";
+ };
+
+ vreg_pmu_rfa_1p8: ldo7 {
+ regulator-name = "vreg_pmu_rfa_1p8";
+ };
+
+ vreg_pmu_pcie_0p9: ldo8 {
+ regulator-name = "vreg_pmu_pcie_0p9";
+ };
+
+ vreg_pmu_pcie_1p8: ldo9 {
+ regulator-name = "vreg_pmu_pcie_1p8";
+ };
+ };
+ };
};
&apps_rsc {
@@ -757,6 +814,21 @@ &pcie0_phy {
&pcie_port0 {
wake-gpios = <&tlmm 104 GPIO_ACTIVE_LOW>;
reset-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
+
+ wifi@0 {
+ compatible = "pci17cb,1107";
+ reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+ vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
+ vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
+ vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
+ };
};
&pcie1 {
@@ -800,6 +872,16 @@ led-1 {
};
&pmh0104_c_e0_gpios {
+ wlan_en: wlan-en-state {
+ pins = "gpio7";
+ function = "normal";
+ input-disable;
+ output-enable;
+ output-low;
+ bias-disable;
+ power-source = <1>;
+ };
+
sd_card_eldo_en: sd-card-eldo-en-state {
pins = "gpio5";
function = "normal";
@@ -906,6 +988,12 @@ &tlmm {
<119 2>, /* SoCCP */
<144 2>, /* CXM UART */
<211 1>; /* NFC Secure IO */
+
+ sw_ctrl_default: sw-ctrl-default-state {
+ pins = "gpio18";
+ function = "gpio";
+ bias-pull-down;
+ };
};
&uart7 {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: maili-mtp: Add WCN7850 Bluetooth support
2026-11-18 3:33 [PATCH 0/2] arm64: dts: qcom: Enable WCN7850 on Maili MTP Yijie Yang
2026-11-18 3:33 ` [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support Yijie Yang
@ 2026-11-18 3:33 ` Yijie Yang
1 sibling, 0 replies; 4+ messages in thread
From: Yijie Yang @ 2026-11-18 3:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, Yijie Yang
Enable WCN785x Bluetooth on Maili MTP board.
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/maili-mtp.dts | 35 +++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/maili-mtp.dts b/arch/arm64/boot/dts/qcom/maili-mtp.dts
index a3c2016eb9053..49fccc43c9828 100644
--- a/arch/arm64/boot/dts/qcom/maili-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/maili-mtp.dts
@@ -146,9 +146,10 @@ sdcard_vdd_3p0: sdcard-vdd-3p0 {
wcn7850-pmu {
compatible = "qcom,wcn7850-pmu";
- pinctrl-0 = <&wlan_en>, <&sw_ctrl_default>;
+ pinctrl-0 = <&bt_default>, <&wlan_en>, <&sw_ctrl_default>;
pinctrl-names = "default";
+ bt-enable-gpios = <&pmh0104_c_e0_gpios 6 GPIO_ACTIVE_HIGH>;
wlan-enable-gpios = <&pmh0104_c_e0_gpios 7 GPIO_ACTIVE_HIGH>;
vdd-supply = <&vreg_s1j_0p8>;
@@ -178,6 +179,10 @@ vreg_pmu_wlmx_0p85: ldo3 {
regulator-name = "vreg_pmu_wlmx_0p85";
};
+ vreg_pmu_btcmx_0p85: ldo4 {
+ regulator-name = "vreg_pmu_btcmx_0p85";
+ };
+
vreg_pmu_rfa_0p8: ldo5 {
regulator-name = "vreg_pmu_rfa_0p8";
};
@@ -872,6 +877,16 @@ led-1 {
};
&pmh0104_c_e0_gpios {
+ bt_default: bt-default-state {
+ pins = "gpio6";
+ function = "normal";
+ input-disable;
+ output-enable;
+ output-low;
+ bias-disable;
+ power-source = <1>;
+ };
+
wlan_en: wlan-en-state {
pins = "gpio7";
function = "normal";
@@ -996,6 +1011,24 @@ sw_ctrl_default: sw-ctrl-default-state {
};
};
+&uart18 {
+ status = "okay";
+
+ bluetooth {
+ compatible = "qcom,wcn7850-bt";
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+ vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
+
+ max-speed = <3200000>;
+ };
+};
+
&uart7 {
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support
2026-11-18 3:33 ` [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support Yijie Yang
@ 2026-11-18 3:53 ` sashiko-bot
0 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-18 3:53 UTC (permalink / raw)
To: Yijie Yang; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: maili-mtp: wrong vddrfa supplies in
wcn7850-pmu
--
commit 0117df6375848f6603dc465badcac7a530d4ecbc
Author: Yijie Yang <yijie.yang@oss.qualcomm.com>
arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support
This commit adds the WCN7850 PMU node, PCIe Wi-Fi node, and associated
pinctrl configuration to enable WLAN on the Maili MTP board.
> diff --git a/arch/arm64/boot/dts/qcom/maili-mtp.dts b/arch/arm64/boot/dts/qcom/maili-mtp.dts
> index 5409d0a7ec2e0..a3c2016eb9053 100644
> --- a/arch/arm64/boot/dts/qcom/maili-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/maili-mtp.dts
> @@ -142,6 +142,63 @@ sdcard_vdd_3p0: sdcard-vdd-3p0 {
>
> vin-supply = <&vreg_bob1>;
> };
> +
> + wcn7850-pmu {
> + compatible = "qcom,wcn7850-pmu";
> +
> + pinctrl-0 = <&wlan_en>, <&sw_ctrl_default>;
> + pinctrl-names = "default";
> +
> + wlan-enable-gpios = <&pmh0104_c_e0_gpios 7 GPIO_ACTIVE_HIGH>;
> +
> + vdd-supply = <&vreg_s1j_0p8>;
> + vddio-supply = <&vreg_l2d_1p8>;
> + vddio1p2-supply = <&vreg_l4g_1p2>;
> + vddaon-supply = <&vreg_s9d_1p0>;
> + vdddig-supply = <&vreg_s3c_1p2>;
> + vddrfa1p2-supply = <&vreg_s9d_1p0>;
> + vddrfa1p8-supply = <&vreg_s7g_1p2>;
[Severity: High]
Are vddrfa1p2-supply and vddrfa1p8-supply shifted off by one rail here?
vddrfa1p2-supply is wired to the 1.0V vreg_s9d_1p0 rail (duplicating
vddaon-supply) instead of the 1.2V vreg_s7g_1p2 rail, while vddrfa1p8-supply
is wired to the 1.2V vreg_s7g_1p2 rail instead of the 1.8V vreg_s4c_1p8 rail
defined on pmh0104_c_e0:
arch/arm64/boot/dts/qcom/maili-mtp.dts:
vreg_s4c_1p8: smps4 {
regulator-name = "vreg_s4c_1p8";
regulator-min-microvolt = <1808000>;
regulator-max-microvolt = <2040000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
Because pwrseq_qcom_wcn_vregs_enable() only calls regulator_bulk_enable()
without setting voltages, the mismatch is not caught at probe time; instead,
vreg_s4c_1p8 is never enabled when powering on WCN7850 and can be disabled
as an unused rail by regulator_late_cleanup(), breaking WCN7850 bring-up.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-wlan-bt-v1-0-18bb1b059a17@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-18 3:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 3:33 [PATCH 0/2] arm64: dts: qcom: Enable WCN7850 on Maili MTP Yijie Yang
2026-11-18 3:33 ` [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support Yijie Yang
2026-11-18 3:53 ` sashiko-bot
2026-11-18 3:33 ` [PATCH 2/2] arm64: dts: qcom: maili-mtp: Add WCN7850 Bluetooth support Yijie Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox